freeradius: updated to 3.0.19

3.0.19:
FEATURE IMPROVEMENTS
Update dictionary.cisco.
Update sqlippool to allow for stored procedures with PostgreSQL. This increases performance substantially Patch from Nathan Ward.
Re-added "show client config" command to radmin.
Cleaned up mods-available/sql example so that it is easier to understand.
Added pfSense dictionary.
Update dictionary.h3c
Update elasticsearch/logstash config for v6.7.0.
EAP-PWD security fixes from Mathy Vanhoef. See http://freeradius.org/security/.

BUG FIXES
Update dynamic_client module and server core so that the functionality works. This has been broken since at least v2.
Fix crash in sqlippool due to escaping changes Patch from Nathan Ward.
Fix systemd notify, watchdog and unit files
Fix erroneous length check in EAP-FAST.
Update documentation to remove old "ignore_null" configuration.
Fix default POD port. Should be 3799.
Correctly encode vendor-specific "encrypted" attributes


3.0.18:
FEATURE IMPROVEMENTS
cleanup_delay can now be 30 seconds. This helps with proxies that have packet loss.
Do-Not-Respond policies can now be set in the "post-auth" section.
Encode / Decode ADSL Forum DHCP options.
Fix module ordering issues. e.g. when "sqlippool" needs "sql". See the "instantiate" section of radiusd.conf.
Add Big Switch dictionary.
Add sql_session_start policy (raddb/policy.d/accounting) This minimizes race conditions when using Simultaneous-Use Patch from Philippe Wooding.
For rlm_perl, all variables are now tainted by default. See raddb/mods-available/perl, and the "perl_flags" configuration item. This change should only affect people who are using variables in insecure ways.
Allow "sqlcounter" module to be listed in "post-auth".
Add support for IPv6 attributes in SQL.
The server is better at handling fail-over for outbound RadSec and TCP connections.
The server is now more aggressive about retrying failed outbound RadSec and TCP connections.
Add TLS-Session-Version and TLS-Session-Cipher-Suite to the "session_state" list.
Add expansion for Radsec connections. "%{listen:TLS-...}" for TLS-Client-Cert-* and TLS-Cert-* attributes.
Add notes on running "ldapsearch" using the parameters from the LDAP module.
"ipaddr" attributes can now be cast to "integer" type attributes in an "update" section.
Move main thread queue to using atomic queues. This should help with contention in high load scenarios.
Add "recv_buff" setting to listeners. For more details, see sites-available/default.
The sqlippool module can now use attributes other than "Pool-Name" to assign IP pools. The "Pool-Name" attribute is still the default.
The "unpack" expansion can now unpack substrings. See mods-available/unpack for documentation and examples.
The preprocess module now does "ciscvo_vsa_hack" for Eltex-AVPair. Vendors SHOULD NOT USE THAT KIND OF ATTRIBUTE.
Allow for <instance>-LDAP-UserDN. See mods-available/ldap for more information.
Add sanitizing of control list for moonshot.
Update rlm_sql_mysql to be compatible with MySQL 8 Fixes https://bugs.launchpad.net/bugs/1795310.
Allow logging of only Access-Accept or Access-Reject messages See radiusd.conf, "auth_accept" and "auth_reject".
Removed Connect-Rate comparison. It was unused and broken.
Add dictionary.infinera.
RPMs can now change raddb location with rpmbuild parameter --define '_sysconfdir /etc'.
OpenDirectory module now points to Apple documentation for help with build and configuration.
Use OpenSSL HMAC functions instead of local ones.
Some SQL modules can now use "auto_escape" to escape unsafe strings See mods-config/sql/main/mysql/queries.conf.
Add wispr2date conversion in mods-available/date.
Implement dictionary-based handling in rlm_python.
Add support for SKIP LOCKED in sqlippool. This can improve performance by an order of magnitude or more. See raddb/mods-config/sql/ippool/*/queries.conf
Updated Debian packages to allow for libssl1.1
Allow PSK and certificates at the same time Except for TLS 1.3 which does not support that.
Update Debian packages for newer releases
Update docker scripts.
Add crypt xlat.
MySQL connections can now skip verifying the server certificate.
Add better mechanism to detect MariaDB (Old MySQL).
Add RFC 7532 "bang path" support for realms
Update dictionary.ukerna documentation.
Add support for systemd service and watchdogs
Check for openss/rand.h, and allow building without OpenSSL engine.
The default PosgtreSQL queries now use "ON CONFLICT" to better deal with issues. This requires PostgreSQL 9.5 or later. Please use a recent version of PostgreSQL, or edit the default queries to remove "ON CONFLICT".

BUG FIXES
The session-state list is no longer cleaned in the inner-tunnel. This lets the outer Access-Reject section access session-state.
Fix typo in lock initialization for TLS sockets Found by Sergio NNX.
Add check for crash when home server down
Add username key for postauth table.
Better libpcap checks, when the header files or libraries are missing.
Allow building with old versions of OpenSSL
Allow non-FreeRADIUS State attributes to be used with the "session-state" list. i.e. State length != 16.
Be more aggressive about cleaning up zombie children when running in debug mode.
Use LTDL_DEEPBIND, which fixes issues with Oracle libraries exporting LDAP API functions.
unlock files when asked to unlock them.
return error instead of asserting in map code.
Don't write 0 bytes to SSL.
Remove "expiry_time IS NULL" from allocate_update query.
Various dictionary cleanups and consistency checks
rlm_python has stronger thread locking to prevent reported issues. Performance may be affected.
Don't allow Message-Authenticator to overflow past the end of a large packet.
Fix crash in sqlippool when SQL server goes away
Typos in man pages. Patch from Nikolai Kondrashov
Check for correct OpenSSL version in vulnerability list. Patch from Christian Hesse.
Fix crash with CoA packets/
Fix crash in rlm_exec with CoA.
Print errors while parsing the log config, and don't quit when deprecated log settings are found.
Fix DHCP encoder xlat so that it can be used with a list of attributes. It previously only encoded the first member of the list, and now encodes all members.
The "expr" module now skips more whitespace.
Remove internal FreeRADIUS-Response-Delay attributes from attr_filter Access-Reject.
Don't send junk to redis when maximum args reached.
Small updates to IPv6 for accounting schema
Fix OpenDirectory integration in rlm_mschap.
Fix slow memory leak with dynamic clients.
Don't artificially truncate debug output for long strings.
Fix memory leak in EAP-PWD.
Fix crash in "hints" file with Fall-Through = yes.
Fix crash / timer issues with many CoA packets.
Fix attr_filter so that it does not treat vendor attributes of number 26 as Vendor-Specific.
Fix reconnect correctly in rlm_sql_mysql.
Fix rlm_cache to properly use Cache-TTL < 0
Fix rare occurance of bad xlat expansion.
Check for rare race condition when a proxy reply arrives too late.

6 files changed, 44 insertions, 72 deletions

diff --git a/net/freeradius/Makefile b/net/freeradius/Makefile
index 1338fdbb2d6..6c3e8951363 100644
--- a/net/freeradius/Makefile
+++ b/net/freeradius/Makefile
@@ -1,9 +1,9 @@
-# $NetBSD: Makefile,v 1.99 2018/10/08 15:50:39 jperkin Exp $
+# $NetBSD: Makefile,v 1.100 2019/07/04 07:44:52 adam Exp $
 
 .include "Makefile.common"
 
-PKGNAME=		${DISTNAME:S/-server//}
-COMMENT=		Free RADIUS server implementation
+PKGNAME=	${DISTNAME:S/-server//}
+COMMENT=	Free RADIUS server implementation
 
 BUILD_DEFS+=		VARBASE
 CONFIGURE_ARGS+=	--localstatedir=${VARBASE}
@@ -42,14 +42,8 @@ OWN_DIRS_PERMS+=	${VARBASE}/run/radiusd \
 
 PKG_SYSCONFSUBDIR=	raddb
 
-OPSYSVARS+=		SOEXT
-SOEXT.Darwin=		dylib
-SOEXT.*=		so
-PLIST_SUBST+=		SOEXT=${SOEXT}
-PRINT_PLIST_AWK+=	{gsub(/\.${SOEXT}$$/, ".$${SOEXT}");}
-
 FILES_SUBST+=		RADIUS_USER=${RADIUS_USER} RADIUS_GROUP=${RADIUS_GROUP}
-MESSAGE_SUBST+=		BOOTSTRAP=${PKG_SYSCONFDIR:Q}/certs/bootstrap
+MESSAGE_SUBST+=		BOOTSTRAP=${PKG_SYSCONFDIR}/certs/bootstrap
 
 EGDIR=			${PREFIX}/share/examples/freeradius
 
@@ -181,7 +175,7 @@ EGFILES=		certs/ca.cnf certs/client.cnf certs/inner-server.cnf \
 			sites-available/virtual.example.com \
 			users templates.conf trigger.conf
 
-EGDIRS= 		certs mods-available mods-config mods-config/attr_filter mods-config/files \
+EGDIRS=			certs mods-available mods-config mods-config/attr_filter mods-config/files \
 			mods-config/perl mods-config/preprocess mods-config/sql mods-config/sql/counter  \
 			mods-config/sql/counter/mysql mods-config/sql/counter/postgresql  \
 			mods-config/sql/counter/sqlite mods-config/sql/cui mods-config/sql/cui/mysql  \
diff --git a/net/freeradius/Makefile.common b/net/freeradius/Makefile.common
index ff414adef04..e8a109d2da9 100644
--- a/net/freeradius/Makefile.common
+++ b/net/freeradius/Makefile.common
@@ -1,19 +1,18 @@
-# $NetBSD: Makefile.common,v 1.4 2018/10/08 15:50:39 jperkin Exp $
+# $NetBSD: Makefile.common,v 1.5 2019/07/04 07:44:52 adam Exp $
 # used by net/freeradius/Makefile.module
 
-DISTNAME=		freeradius-server-3.0.17
-CATEGORIES=		net
-MASTER_SITES=		ftp://ftp.freeradius.org/pub/freeradius/
-EXTRACT_SUFX=		.tar.bz2
+DISTNAME=	freeradius-server-3.0.19
+CATEGORIES=	net
+MASTER_SITES=	ftp://ftp.freeradius.org/pub/freeradius/
+EXTRACT_SUFX=	.tar.bz2
 
-MAINTAINER=		pkgsrc-users@NetBSD.org
-HOMEPAGE=		http://www.freeradius.org/
-LICENSE=		gnu-gpl-v2
+MAINTAINER=	pkgsrc-users@NetBSD.org
+HOMEPAGE=	http://www.freeradius.org/
+LICENSE=	gnu-gpl-v2
 
-GNU_CONFIGURE=		yes
-USE_TOOLS+=		gmake perl
 USE_LANGUAGES+=		c c++
-
+USE_TOOLS+=		gmake perl
+GNU_CONFIGURE=		yes
 CONFIGURE_ARGS+=	--with-openssl-include-dir=${BUILDLINK_PREFIX.openssl}/include
 CONFIGURE_ARGS+=	--with-openssl-lib-dir=${BUILDLINK_PREFIX.openssl}/lib
 CONFIGURE_ARGS+=	--without-rlm_yubikey
@@ -26,6 +25,12 @@ MAKE_ENV+=		PACKAGE=yes
 
 INSTALLATION_DIRS+=	lib
 
+OPSYSVARS+=		SOEXT
+SOEXT.Darwin=		dylib
+SOEXT.*=		so
+PLIST_SUBST+=		SOEXT=${SOEXT}
+PRINT_PLIST_AWK+=	{gsub(/\.${SOEXT}$$/, ".$${SOEXT}");}
+
 .include "../../databases/gdbm/buildlink3.mk"
 .include "../../devel/talloc/buildlink3.mk"
 .include "../../net/libpcap/buildlink3.mk"
diff --git a/net/freeradius/PLIST b/net/freeradius/PLIST
index 56d4a502700..d931ae262a5 100644
--- a/net/freeradius/PLIST
+++ b/net/freeradius/PLIST
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.30 2018/09/25 12:16:36 jperkin Exp $
+@comment $NetBSD: PLIST,v 1.31 2019/07/04 07:44:52 adam Exp $
 bin/dhcpclient
 bin/map_unit
 bin/rad_counter
@@ -15,6 +15,7 @@ bin/radzap
 bin/rlm_ippool_tool
 bin/smbencrypt
 include/freeradius/attributes.h
+include/freeradius/autoconf.h
 include/freeradius/base64.h
 include/freeradius/build.h
 include/freeradius/conf.h
@@ -39,6 +40,7 @@ include/freeradius/radiusd.h
 include/freeradius/radpaths.h
 include/freeradius/radutmp.h
 include/freeradius/realms.h
+include/freeradius/regex.h
 include/freeradius/rfc2865.h
 include/freeradius/rfc2866.h
 include/freeradius/rfc2867.h
@@ -71,9 +73,13 @@ include/freeradius/rfc7155.h
 include/freeradius/rfc7268.h
 include/freeradius/rfc7499.h
 include/freeradius/rfc7930.h
+include/freeradius/rfc8045.h
+include/freeradius/rfc8559.h
 include/freeradius/sha1.h
 include/freeradius/stats.h
 include/freeradius/sysutmp.h
+include/freeradius/tcp.h
+include/freeradius/threads.h
 include/freeradius/tls.h
 include/freeradius/token.h
 include/freeradius/udpfromto.h
@@ -439,6 +445,7 @@ share/examples/freeradius/mods-config/sql/ippool/mysql/schema.sql
 share/examples/freeradius/mods-config/sql/ippool/oracle/procedures.sql
 share/examples/freeradius/mods-config/sql/ippool/oracle/queries.conf
 share/examples/freeradius/mods-config/sql/ippool/oracle/schema.sql
+share/examples/freeradius/mods-config/sql/ippool/postgresql/procedure.sql
 share/examples/freeradius/mods-config/sql/ippool/postgresql/queries.conf
 share/examples/freeradius/mods-config/sql/ippool/postgresql/schema.sql
 share/examples/freeradius/mods-config/sql/ippool/sqlite/queries.conf
@@ -511,6 +518,7 @@ share/examples/freeradius/policy.d/eap
 share/examples/freeradius/policy.d/filter
 share/examples/freeradius/policy.d/moonshot-targeted-ids
 share/examples/freeradius/policy.d/operator-name
+share/examples/freeradius/policy.d/rfc7542
 share/examples/freeradius/proxy.conf
 share/examples/freeradius/radiusd.conf
 share/examples/freeradius/sites-available/README
@@ -574,6 +582,7 @@ share/freeradius/dictionary.audiocodes
 share/freeradius/dictionary.avaya
 share/freeradius/dictionary.azaire
 share/freeradius/dictionary.bay
+share/freeradius/dictionary.bigswitch
 share/freeradius/dictionary.bintec
 share/freeradius/dictionary.bluecoat
 share/freeradius/dictionary.boingo
@@ -632,6 +641,7 @@ share/freeradius/dictionary.hp
 share/freeradius/dictionary.huawei
 share/freeradius/dictionary.iana
 share/freeradius/dictionary.iea
+share/freeradius/dictionary.infinera
 share/freeradius/dictionary.infoblox
 share/freeradius/dictionary.infonet
 share/freeradius/dictionary.ipunplugged
@@ -671,6 +681,7 @@ share/freeradius/dictionary.packeteer
 share/freeradius/dictionary.paloalto
 share/freeradius/dictionary.patton
 share/freeradius/dictionary.perle
+share/freeradius/dictionary.pfsense
 share/freeradius/dictionary.propel
 share/freeradius/dictionary.prosoft
 share/freeradius/dictionary.proxim
@@ -710,6 +721,8 @@ share/freeradius/dictionary.rfc7155
 share/freeradius/dictionary.rfc7268
 share/freeradius/dictionary.rfc7499
 share/freeradius/dictionary.rfc7930
+share/freeradius/dictionary.rfc8045
+share/freeradius/dictionary.rfc8559
 share/freeradius/dictionary.riverbed
 share/freeradius/dictionary.riverstone
 share/freeradius/dictionary.roaringpenguin
@@ -742,6 +755,7 @@ share/freeradius/dictionary.usr
 share/freeradius/dictionary.usr.illegal
 share/freeradius/dictionary.utstarcom
 share/freeradius/dictionary.valemount
+share/freeradius/dictionary.verizon
 share/freeradius/dictionary.versanet
 share/freeradius/dictionary.vqp
 share/freeradius/dictionary.walabi
diff --git a/net/freeradius/distinfo b/net/freeradius/distinfo
index ad10f95a7eb..dc676d1ee59 100644
--- a/net/freeradius/distinfo
+++ b/net/freeradius/distinfo
@@ -1,12 +1,11 @@
-$NetBSD: distinfo,v 1.37 2018/12/19 22:52:32 manu Exp $
+$NetBSD: distinfo,v 1.38 2019/07/04 07:44:52 adam Exp $
 
-SHA1 (freeradius-server-3.0.17.tar.bz2) = a0d4372ee124cbee6b90a4463ff068afe70e06ca
-RMD160 (freeradius-server-3.0.17.tar.bz2) = c335fe2ef39ca2311ac85b2ec3d5941bbbb5e6e6
-SHA512 (freeradius-server-3.0.17.tar.bz2) = f4510d8e77eb7c72a21fbfad851f13460ff4b5a35f0b7bea6102076ceb71188a63b277fb7e4fcd9c3033b396b63e1bf0e455cc03608d7ab1380d1662407cb399
-Size (freeradius-server-3.0.17.tar.bz2) = 3075724 bytes
+SHA1 (freeradius-server-3.0.19.tar.bz2) = 6bb57e634ad6e85f6c324f851296c688edbc3b11
+RMD160 (freeradius-server-3.0.19.tar.bz2) = 753b89e13b80312131149cdaf26b944bc802e338
+SHA512 (freeradius-server-3.0.19.tar.bz2) = 9bb3401a52288de541a2272149f4341840dc1df7203583746bef46c0b1b1f2b8886931c9f6f9ce3d92951e271ab5a84a50a8587a3acd69cc20bc86f5817d28e1
+Size (freeradius-server-3.0.19.tar.bz2) = 3127564 bytes
 SHA1 (patch-ai) = e32ffd24b93e2cef2e72ef9a8ea59d49e1571dc0
 SHA1 (patch-configure.ac) = ffec1f851d23f560797c12eba5092f2940e4d662
 SHA1 (patch-main_command.c) = 1c79b29eb13df341906c710c8dd41860a27473dd
-SHA1 (patch-main_util.c) = b9cefdb9bc30df0906184e8c0bb883e5258767c3
-SHA1 (patch-src_lib_debug.c) = 7547fdd6abf1048cb1ca846900fc9e4d734f8b8a
+SHA1 (patch-main_util.c) = e8814255c32c8469e81d62f2c7092e8d42744e85
 SHA1 (patch-src_lib_udpfromto.c) = 2457f0a7223b1f3ef86d0af020290b26380e6319
diff --git a/net/freeradius/patches/patch-main_util.c b/net/freeradius/patches/patch-main_util.c
index 64f86ec342c..21cb9e3600b 100644
--- a/net/freeradius/patches/patch-main_util.c
+++ b/net/freeradius/patches/patch-main_util.c
@@ -1,4 +1,5 @@
-$NetBSD: patch-main_util.c,v 1.1 2017/08/26 10:07:28 fhajny Exp $
+$NetBSD: patch-main_util.c,v 1.2 2019/07/04 07:44:52 adam Exp $
+
 O_DIRECTORY to open(2) is a Linuxism.
 
 --- src/main/util.c.orig	2016-09-29 15:19:48.000000000 +0000
diff --git a/net/freeradius/patches/patch-src_lib_debug.c b/net/freeradius/patches/patch-src_lib_debug.c
deleted file mode 100644
index bcf2d5dfe06..00000000000
--- a/net/freeradius/patches/patch-src_lib_debug.c
+++ /dev/null
@@ -1,41 +0,0 @@
-$NetBSD: patch-src_lib_debug.c,v 1.1 2018/12/19 22:52:32 manu Exp $
-
-Fix startup crash when running outside of gdb on BSD systems.
-
-From upstream https://github.com/FreeRADIUS/freeradius-server/commit/1f8cd27b78c011826bc0744debb4ed60b3f0584a
-
---- src/lib//debug.c.orig	2018-12-16 03:31:31.909930476 +0100
-+++ src/lib//debug.c	2018-12-19 10:05:49.848809433 +0100
-@@ -105,13 +105,21 @@
- 
- static TALLOC_CTX *talloc_null_ctx;
- static TALLOC_CTX *talloc_autofree_ctx;
- 
-+/*
-+ * On BSD systems, ptrace(PT_DETACH) uses a third argument for
-+ * resume address, with the magic value (void *)1 to resume where
-+ * process stopped. Specifying NULL there leads to a crash because
-+ * process resumes at address 0.
-+ */  
- #ifdef HAVE_SYS_PTRACE_H
- #  ifdef __linux__
- #    define _PTRACE(_x, _y) ptrace(_x, _y, NULL, NULL)
-+#    define _PTRACE_DETACH(_x) ptrace(PT_DETACH, _x, NULL, NULL)
- #  else
- #    define _PTRACE(_x, _y) ptrace(_x, _y, NULL, 0)
-+#    define _PTRACE_DETACH(_x) ptrace(PT_DETACH, _x, (void *)1, NULL)
- #  endif
- 
- #  ifdef HAVE_CAPABILITY_H
- #    include <sys/capability.h>
-@@ -205,9 +213,9 @@
- 				fprintf(stderr, "Writing ptrace status to parent failed: %s", fr_syserror(errno));
- 			}
- 
- 			/* Detach */
--			_PTRACE(PT_DETACH, ppid);
-+			_PTRACE_DETACH(ppid);
- 			exit(0);
- 		}
- 
- 		ret = DEBUG_STATE_ATTACHED;