summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint/files/textproc
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2019-03-10 19:01:50 +0000
committerrillig <rillig@pkgsrc.org>2019-03-10 19:01:50 +0000
commit1a353ea4eceb65b1a01e10e3d93ceec432295415 (patch)
tree36ba46b3523986b5c416549295ef05841d7a470b /pkgtools/pkglint/files/textproc
parent0e81c7a00d92f6a32b2d176f0cbd0bcc295234f8 (diff)
downloadpkgsrc-1a353ea4eceb65b1a01e10e3d93ceec432295415.tar.gz
pkgtools/pkglint: update to 5.7.2
Changes since 5.7.1: * Fixed detection of GNU_CONFIGURE=yes combined with USE_LANGUAGES missing c. This combination tends to fail in the configure phase. * When the distinfo doesn't contain all hashes for the downloaded distfiles (typically SHA512 is missing) and the distfiles are actually downloaded to ${PKGSRCDIR}/distfiles, pkglint can now add the missing hashes. It only does this if there is at least one existing hash and if all existing hashes are correct. * The check for redundant variables has been improved considerably. Before there were several situations in which pkglint didn't get the redundant variable definitions right because its internal model only mimicked reality. The model has been improved and so have the diagnostics. * Pkglint only warns about wrong permissions (for defining or using a variable) when it knows the type of the variable and the permissions for the current file. Before, it had also warned if the permissions for the current file were not explicitly defined. * CFLAGS and LDFLAGS may be appended in buildlink3.mk files. This had been disallowed before, for no apparent reason. There are several places in pkgsrc where especially CFLAGS.${OPSYS} is appended to. * Cleaned up internal handling of relative paths. Previously pkglint sometimes resolved relative paths using the wrong base directory, which led to all kinds of wrong warnings and strange behavior. * Fixed lots of edge cases when parsing Makefile lines. These cases don't occur often but experience tells that the most fundamental code must be as correct as possible (see the handling of relative paths above). * Lots of refactoring and housekeeping, as always.
Diffstat (limited to 'pkgtools/pkglint/files/textproc')
-rw-r--r--pkgtools/pkglint/files/textproc/lexer.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/pkgtools/pkglint/files/textproc/lexer.go b/pkgtools/pkglint/files/textproc/lexer.go
index 3d22338be95..9687e101bb2 100644
--- a/pkgtools/pkglint/files/textproc/lexer.go
+++ b/pkgtools/pkglint/files/textproc/lexer.go
@@ -226,6 +226,9 @@ func (l *Lexer) Copy() *Lexer { return &Lexer{l.rest} }
func (l *Lexer) Commit(other *Lexer) bool { l.rest = other.rest; return true }
// NewByteSet creates a bit mask out of a string like "0-9A-Za-z_".
+// To add an actual hyphen to the bit mask, write it as "---"
+// (a range from hyphen to hyphen).
+//
// The bit mask can be used with Lexer.NextBytesSet.
func NewByteSet(chars string) *ByteSet {
var set ByteSet