diff options
| author | rillig <rillig@pkgsrc.org> | 2006-06-06 07:04:56 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-06-06 07:04:56 +0000 |
| commit | 52f5108b7c25fa44087465874ad93d169a16c7dc (patch) | |
| tree | 09b2903c33ecf5c5d6147d2f48bebfd032c629ec /pkgtools/pkglint | |
| parent | cf96b37f1858a6739ce90eb3e1600dcb3fa77807 (diff) | |
| download | pkgsrc-52f5108b7c25fa44087465874ad93d169a16c7dc.tar.gz | |
Enumerations don't need the :Q operator.
Diffstat (limited to 'pkgtools/pkglint')
| -rw-r--r-- | pkgtools/pkglint/files/makevars.map | 4 | ||||
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
2 files changed, 6 insertions, 4 deletions
diff --git a/pkgtools/pkglint/files/makevars.map b/pkgtools/pkglint/files/makevars.map index 5a634d61e2c..625321969bd 100644 --- a/pkgtools/pkglint/files/makevars.map +++ b/pkgtools/pkglint/files/makevars.map @@ -1,4 +1,4 @@ -# $NetBSD: makevars.map,v 1.105 2006/06/06 06:48:16 rillig Exp $ +# $NetBSD: makevars.map,v 1.106 2006/06/06 07:04:56 rillig Exp $ # # This file contains the guessed type of some variables, according to @@ -420,7 +420,7 @@ PKGBASE Identifier [] PKGCONFIG_OVERRIDE List of Pathmask [m:as,c:a] PKGDIR RelativePkgDir PKGNAME PkgName [m:s,c:s,Makefile.*:ds,*:ds] -PKGNAME_NOREV Unchecked [] +PKGNAME_NOREV PkgName [] PKGREPOSITORY Unchecked [] PKGREVISION PkgRevision [m:s] PKGTOOLS_ENV List of ShellWord diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 95c9f2fc5a8..9e4347ad3a2 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.604 2006/06/06 06:48:16 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.605 2006/06/06 07:04:56 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2645,7 +2645,9 @@ sub variable_needs_quoting($$$) { return dont_know; } - if ($type->kind_of_list == LK_NONE && exists(safe_types->{$type->basic_type})) { + # Variables of certain predefined types, as well as all + # enumerations, are expected to not require the :Q operator. + if ($type->kind_of_list == LK_NONE && (ref($type->basic_type) eq "HASH" || exists(safe_types->{$type->basic_type}))) { return doesnt_matter; } |