summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2008-12-04 18:07:52 +0000
committerrillig <rillig@pkgsrc.org>2008-12-04 18:07:52 +0000
commit549bd2d94b3f20fe39711433265e48590048086f (patch)
tree2eaf4d1276da29caa9832914cfc371d3caad4bf0 /pkgtools/pkglint
parent7773839647861b8b2f0847d5fec298a877aa239d (diff)
downloadpkgsrc-549bd2d94b3f20fe39711433265e48590048086f.tar.gz
Added explicit checks for share/icons/hicolor directories in PLISTs, as
suggested by wiz.
Diffstat (limited to 'pkgtools/pkglint')
-rw-r--r--pkgtools/pkglint/files/pkglint.pl8
1 files changed, 7 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl
index 1be7ae76c36..b5fb833b3f4 100644
--- a/pkgtools/pkglint/files/pkglint.pl
+++ b/pkgtools/pkglint/files/pkglint.pl
@@ -1,5 +1,5 @@
#! @PERL@
-# $NetBSD: pkglint.pl,v 1.792 2008/12/02 09:00:28 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.793 2008/12/04 18:07:52 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@@ -7420,6 +7420,9 @@ sub checkfile_PLIST($) {
"created the directory.");
}
+ if ($pkgpath ne "graphics/hicolor-icon-theme" && $arg =~ m"^share/icons/hicolor(?:$|/)") {
+ $line->log_warning("Please .include \"../../graphics/hicolor-icon-theme/buildlink3.mk\" and remove this line.");
+ }
} elsif ($cmd eq "imake-man") {
my (@args) = split(/\s+/, $arg);
if (@args != 3) {
@@ -7567,6 +7570,9 @@ sub checkfile_PLIST($) {
} elsif (defined($effective_pkgbase) && $text =~ m"^share/\Q${effective_pkgbase}\E/") {
# Fine.
+ } elsif ($pkgpath ne "graphics/hicolor-icon-theme" && $text =~ m"^share/icons/hicolor/icon-theme\.cache") {
+ $line->log_error("Please .include \"../../graphics/hicolor-icon-theme/buildlink3.mk\" and remove this line.");
+
} elsif ($text =~ m"^share/info/") {
$line->log_warning("Info pages should be installed into info/, not share/info/.");
$line->explain_warning(