diff options
author | asau <asau@pkgsrc.org> | 2012-08-01 22:19:00 +0000 |
---|---|---|
committer | asau <asau@pkgsrc.org> | 2012-08-01 22:19:00 +0000 |
commit | bd8d1c0efb2db3f8dbf18d11031d2ad94c8e4b66 (patch) | |
tree | 881c35b7af530d58b69e9ea867c21fecde471822 /pkgtools/pkglint | |
parent | efafd5490e8c76651d72d15422625ccf496dddc8 (diff) | |
download | pkgsrc-bd8d1c0efb2db3f8dbf18d11031d2ad94c8e4b66.tar.gz |
Don't enforce purely aesthetic changes.
Diffstat (limited to 'pkgtools/pkglint')
-rw-r--r-- | pkgtools/pkglint/Makefile | 4 | ||||
-rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 13 |
2 files changed, 9 insertions, 8 deletions
diff --git a/pkgtools/pkglint/Makefile b/pkgtools/pkglint/Makefile index dc3b64f18f6..07489e04c4b 100644 --- a/pkgtools/pkglint/Makefile +++ b/pkgtools/pkglint/Makefile @@ -1,10 +1,10 @@ -# $NetBSD: Makefile,v 1.412 2012/07/22 01:01:40 dholland Exp $ +# $NetBSD: Makefile,v 1.413 2012/08/01 22:19:00 asau Exp $ # # Note: if you update the version number, please have a look at the # changes between the CVS tag "pkglint_current" and HEAD. # After updating, please re-set the CVS tag to HEAD. -DISTNAME= pkglint-4.120 +DISTNAME= pkglint-4.121 CATEGORIES= pkgtools MASTER_SITES= # none DISTFILES= # none diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 1cbcbdb6c68..bbab9707c3e 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.843 2012/07/27 20:54:02 wiz Exp $ +# $NetBSD: pkglint.pl,v 1.844 2012/08/01 22:19:01 asau Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -4030,12 +4030,13 @@ sub checkline_mk_text($$) { } } - $rest = $text; - while ($rest =~ s/(?:^|[^\$])\$\(([-A-Z0-9a-z_]+)(?::[^\}]+)?\)//) { - my ($varname) = ($1); + # Don't enforce purely aesthetic changes before more correct behaviour is implemented: + # $rest = $text; + # while ($rest =~ s/(?:^|[^\$])\$\(([-A-Z0-9a-z_]+)(?::[^\}]+)?\)//) { + # my ($varname) = ($1); - $line->log_warning("Please use \${${varname}\} instead of \$(${varname})."); - } + # $line->log_warning("Please use \${${varname}\} instead of \$(${varname})."); + # } } |