diff options
| author | rillig <rillig@pkgsrc.org> | 2006-01-02 10:09:03 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-01-02 10:09:03 +0000 |
| commit | 0ff3a148887c8f4f8c602bbd02b052a61814f644 (patch) | |
| tree | 1970a0aa97b544ca611cdeeb86ed60d9e60d4cbb /pkgtools | |
| parent | 862032689f4194d8e9e41ccf00396bb1311ac110 (diff) | |
| download | pkgsrc-0ff3a148887c8f4f8c602bbd02b052a61814f644.tar.gz | |
- For possibly misquoted variables the current shellword state is
printed (-vv only).
- TODO: Decide which variables may be used in which quoting states.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 930e1bd2451..3c435630bf5 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -w -# $NetBSD: pkglint.pl,v 1.448 2006/01/02 03:02:29 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.449 2006/01/02 10:09:03 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -1695,8 +1695,10 @@ sub checkline_mk_shellword($$$) { if ($rest =~ s/^\$\{(${regex_varname})(:[^\{]+)?\}//) { my ($varname, $mod) = ($1, $2); + # TODO: Make lists of variables that may appear + # in other quoting states than SWST_PLAIN. if ($opt_warn_extra && $state != SWST_PLAIN) { - $line->log_debug("Possibly misquoted make variable \"${varname}\"."); + $line->log_debug("Possibly misquoted make variable \"${varname}\" in " . statename->[$state] . "."); } } elsif ($state == SWST_PLAIN) { |