diff options
| author | rillig <rillig> | 2005-12-01 01:19:30 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2005-12-01 01:19:30 +0000 |
| commit | 2f2d3dae923e6ad797bd2f488d15dee3ce141aa3 (patch) | |
| tree | 834cf41720e4f25840584235f1ab14b98fda92ba /pkgtools | |
| parent | 6fd3336d315f7ee6cf59c997266c0619ba072462 (diff) | |
| download | pkgsrc-2f2d3dae923e6ad797bd2f488d15dee3ce141aa3.tar.gz | |
- Fixed a bug that had been introduced in revision 1.391, preventing
warnings that LIST+=FOO=${FOO} should rather be LIST+=FOO=${FOO:Q}.
The cause was that I had added a capturing group in a regular
expression that also contained a back reference (\2). Adjusted the
back reference to \3. (This is the only place in pkglint where such
back references are used, so I don't have much experience with them.)
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 8a039697f76..2d174298dcc 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -11,7 +11,7 @@ # Freely redistributable. Absolutely no warranty. # # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp -# $NetBSD: pkglint.pl,v 1.395 2005/11/30 20:16:15 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.396 2005/12/01 01:19:30 rillig Exp $ # # This version contains lots of changes necessary for NetBSD packages # done by: @@ -1966,7 +1966,7 @@ sub checkline_basic_vartype($$$$$) { } } elsif ($type eq "ShellWord") { - if ($value =~ qr"^([\w_]+)=(([\"']?)\$\{([\w_]+)\}\2)$") { + if ($value =~ qr"^([\w_]+)=(([\"']?)\$\{([\w_]+)\}\3)$") { my ($key, $vexpr, undef, $vname) = ($1, $2, $3, $4); my $mod = ($vname =~ regex_gnu_configure_volatile_vars) ? ":M*:Q" : ":Q"; my $fixed_vexpr = "\${${vname}${mod}}"; |