diff options
| author | rillig <rillig@pkgsrc.org> | 2006-02-11 20:58:08 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-02-11 20:58:08 +0000 |
| commit | 3575f7b1eb186edd50ecf07485932e64692630bd (patch) | |
| tree | 6a6a06c4cf6eff03ed2aefb093fe22d6b2670a4f /pkgtools | |
| parent | 7bb2853a77409b441f908ccbcd0b313ec5ad1435 (diff) | |
| download | pkgsrc-3575f7b1eb186edd50ecf07485932e64692630bd.tar.gz | |
- Changed the wording of the warning message for misquoted variables. The
wording had been completely mysterious. Now it gives a direct advise on
how to fix the problem.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 8561d773f69..ef76aaeb9db 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.510 2006/02/11 16:14:40 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.511 2006/02/11 20:58:08 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2348,9 +2348,11 @@ sub checkline_mk_shellword($$$) { "appropriate to remove the double quotes."); } elsif ($opt_warn_quoting) { - $line->log_warning("Possibly misquoted make variable ${varname} in " . user_statename->[$state] . "."); - if ($state == SWST_PLAIN && !defined($mod)) { + if ($state == SWST_PLAIN) { + $line->log_warning("Please use \${${varname}:Q} instead of \${${varname}}."); $line->replace("\${${varname}}", "\${${varname}:Q}"); + } else { + $line->log_warning("Please use \${${varname}:Q} instead of \${${varname}} and make sure the variable appears outside of any quoting characters."); } } |