summaryrefslogtreecommitdiff
path: root/pkgtools
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2006-01-07 23:29:23 +0000
committerrillig <rillig@pkgsrc.org>2006-01-07 23:29:23 +0000
commit4d0e36273890f2a8ccb2064273ab6a47fe08e874 (patch)
tree3e6fc601fd4dfbeaab069ab99df9bf952ad133b5 /pkgtools
parent1f20649016778e2bdeb3885c7e461b0238fd9d76 (diff)
downloadpkgsrc-4d0e36273890f2a8ccb2064273ab6a47fe08e874.tar.gz
- Enabled the quoting warning for SUBST_MESSAGE (this time the other
direction: it had been quoted too much in the past).
Diffstat (limited to 'pkgtools')
-rw-r--r--pkgtools/pkglint/files/pkglint.pl7
1 files changed, 1 insertions, 6 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl
index 425fb64e9aa..3e988977358 100644
--- a/pkgtools/pkglint/files/pkglint.pl
+++ b/pkgtools/pkglint/files/pkglint.pl
@@ -1,5 +1,5 @@
#! @PERL@ -w
-# $NetBSD: pkglint.pl,v 1.454 2006/01/07 20:00:00 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.455 2006/01/07 23:29:23 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@@ -2232,14 +2232,9 @@ sub checkline_mk_vartype_basic($$$$$) {
}
} elsif ($type eq "SubstMessage") {
-
-# TODO: Enable this code when there is a :Q operator on the statement
-# that prints the ${SUBST_MESSAGE} in subst.mk.
-if (false) {
if ($value =~ qr"^\".*\"$") {
$line->log_warning("${varname} should not be quoted.");
}
-}
} elsif ($type eq "Tool") {
if ($value =~ qr"^([-\w]+|\[)(?::(\w+))?$") {