diff options
author | rillig <rillig@pkgsrc.org> | 2005-05-25 00:53:35 +0000 |
---|---|---|
committer | rillig <rillig@pkgsrc.org> | 2005-05-25 00:53:35 +0000 |
commit | 673855c00ad049fd3fcf1f1a6e26af3317798139 (patch) | |
tree | 4c72657b9186d6efa441373a3ea336fb3109eda5 /pkgtools | |
parent | 3af1a0d7b78ebbf24ac25feca6eae0318dba0fc7 (diff) | |
download | pkgsrc-673855c00ad049fd3fcf1f1a6e26af3317798139.tar.gz |
In checklines_direct_tools, quote shell commands, too. Unquoted shell
commands are too hard to recognize.
Diffstat (limited to 'pkgtools')
-rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 5c72f3dab81..f67860b0e99 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -11,7 +11,7 @@ # Freely redistributable. Absolutely no warranty. # # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp -# $NetBSD: pkglint.pl,v 1.180 2005/05/25 00:00:24 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.181 2005/05/25 00:53:35 rillig Exp $ # # This version contains lots of changes necessary for NetBSD packages # done by: @@ -1293,7 +1293,7 @@ sub checklines_direct_tools($) { my ($shellcmd) = ($1); # process shell commands if ($shellcmd !~ $regex_ok_shellcmds) { - $line->log_warning("Possible direct use of \"${tool}\" in shell command ${shellcmd}. Please use \$\{$toolvar{$tool}\} instead."); + $line->log_warning("Possible direct use of \"${tool}\" in shell command \"${shellcmd}\". Please use \$\{$toolvar{$tool}\} instead."); } } elsif ($text =~ qr"^\.") { # skip processing directives |