diff options
| author | rillig <rillig@pkgsrc.org> | 2008-01-25 17:59:24 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2008-01-25 17:59:24 +0000 |
| commit | 9b69335976da206563cc413f20a531771891418b (patch) | |
| tree | 7faa20fd4bf57f5b8adf33e891a3def7ab22dbe2 /pkgtools | |
| parent | 02a29020271e93c9015f01cbbf2d82baa5d4db62 (diff) | |
| download | pkgsrc-9b69335976da206563cc413f20a531771891418b.tar.gz | |
Some commands like "mktexlsr" and "texconfig" must not be called from
package Makefiles.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 438e6c5e2fc..4dd2ded0b9a 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.756 2008/01/10 03:33:46 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.757 2008/01/25 17:59:24 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -4564,8 +4564,9 @@ sub checkline_mk_shelltext($$) { use constant forbidden_commands => array_to_hash(qw( ktrace + mktexlsr strace - truss + texconfig truss )); if ($text =~ qr"\$\{SED\}" && $text =~ qr"\$\{MV\}") { @@ -4655,8 +4656,12 @@ sub checkline_mk_shelltext($$) { if ($shellword eq "\${RUN}") { # Just skip this one. - } elsif (exists(forbidden_commands->{$shellword})) { - $line->log_error("${shellword} is forbidden and must not be used."); + } elsif (exists(forbidden_commands->{basename($shellword)})) { + $line->log_error("${shellword} must not be used in Makefiles."); + $line->explain_error( +"This command must appear in INSTALL scripts, not in the package", +"Makefile, so that the package also works if it is installed as a binary", +"package via pkg_add."); } elsif (exists(get_tool_names()->{$shellword})) { if (!exists($mkctx_tools->{$shellword})) { |