diff options
| author | rillig <rillig@pkgsrc.org> | 2006-02-15 17:00:02 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-02-15 17:00:02 +0000 |
| commit | dd5b0a6024f793ea36fa65dc6ae9994587e8dbe7 (patch) | |
| tree | 54b68dffffabe391624533a56b336447003b0df1 /pkgtools | |
| parent | 5a360e739c099b5e4ad0cb15f289ca299dc1b00b (diff) | |
| download | pkgsrc-dd5b0a6024f793ea36fa65dc6ae9994587e8dbe7.tar.gz | |
- Marked the latest :Q warning as experimental. It currently suggests to
quote even ${CC} and ${CXX}, which is wrong. The warning is not
printed for the other TOOLS, but that is only because the tool
variables have not been assigned proper types.
- Reduced the number of negations in a condition.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 9f2e23a441b..8a8b769d607 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.518 2006/02/15 16:10:49 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.519 2006/02/15 17:00:02 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2304,7 +2304,7 @@ sub checkline_mk_shellword($$$) { my $vartype = get_vartypes_map()->{$varname}; if ($vartype !~ qr"^List") { - $line->log_warning("Please use \${${varname}:Q} instead of \${${varname}}."); + $line->log_warning("[experimental] Please use \${${varname}:Q} instead of \${${varname}}."); } } else { $opt_debug and $line->log_warning("Not sure whether the variable ${varname} needs quoting."); @@ -2545,11 +2545,11 @@ sub checkline_mk_shelltext($$) { $line->log_debug("[" . scst_statename->[$state] . "] shellword=${shellword}"); - checkline_mk_shellword($line, $shellword, ( - $state != SCST_CASE - && $state != SCST_FOR_CONT - && $state != SCST_SET_CONT - && ($state != SCST_START || $shellword !~ regex_sh_varassign))); + checkline_mk_shellword($line, $shellword, !( + $state == SCST_CASE + || $state == SCST_FOR_CONT + || $state == SCST_SET_CONT + || ($state == SCST_START && $shellword =~ regex_sh_varassign))); # # Actions associated with the current state |