diff options
| author | rillig <rillig@pkgsrc.org> | 2007-06-18 09:35:59 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2007-06-18 09:35:59 +0000 |
| commit | ded0e22c1375cf53751654a0276df23160d9673b (patch) | |
| tree | 918426939c37d0fe418fa47268cba1893e8214e3 /pkgtools | |
| parent | bc4f17e5924a17268e1db9549cff95d18e3e8941 (diff) | |
| download | pkgsrc-ded0e22c1375cf53751654a0276df23160d9673b.tar.gz | |
Added an explanation to the "Don't add quotes around SUBST_MESSAGE" rule.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index d89243c50dc..4e6769f8e40 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.709 2007/06/03 18:38:14 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.710 2007/06/18 09:35:59 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -5055,6 +5055,14 @@ sub checkline_mk_vartype_basic($$$$$$$$) { } elsif ($type eq "Message") { if ($value =~ qr"^[\"'].*[\"']$") { $line->log_warning("${varname} should not be quoted."); + $line->explain_warning( +"The quoting is only needed for variables which are interpreted as", +"multiple words (or, generally speaking, a list of something). A single", +"text message does not belong to this class, since it is only printed", +"as a whole.", +"", +"On the other hand, PKG_FAIL_REASON is a _list_ of text messages, so in", +"that case, the quoting has to be done."); } } elsif ($type eq "Option") { |