factor out the common bits of the various mozilla binary packages into

mozilla-bin/Makefile.common and mozilla-bin-nightly/Makefile.common.

the result is much less duplication and more consistent installations.
tested on NetBSD-current only (for now).

9 files changed, 200 insertions, 122 deletions

diff --git a/www/mozilla-bin/MESSAGE.NetBSD b/www/mozilla-bin/MESSAGE.NetBSD
deleted file mode 100644
index f7382f472b9..00000000000
--- a/www/mozilla-bin/MESSAGE.NetBSD
+++ /dev/null
@@ -1,10 +0,0 @@
-===========================================================================
-$NetBSD: MESSAGE.NetBSD,v 1.1 2003/04/14 20:28:22 grant Exp $
-
-	Mozilla requires your kernel to include 'COMPAT_LINUX' (plus in
-	NetBSD systems before 1.5 'EXEC_ELF32').
-
-	Please note that if you have INET6 enabled in your kernel, you
-	will need to set net.inet6.ip6.v6only = 0, using sysctl(8).
-
-===========================================================================
diff --git a/www/mozilla-bin/MESSAGE.compat_linux b/www/mozilla-bin/MESSAGE.compat_linux
new file mode 100644
index 00000000000..f6e934bd8ca
--- /dev/null
+++ b/www/mozilla-bin/MESSAGE.compat_linux
@@ -0,0 +1,10 @@
+===========================================================================
+$NetBSD: MESSAGE.compat_linux,v 1.1 2004/01/04 05:01:02 grant Exp $
+
+	Mozilla Firebird requires your kernel to include 'COMPAT_LINUX'
+	(plus in NetBSD systems before 1.5 'EXEC_ELF32').
+
+	Please note that if you have INET6 enabled in your kernel, you
+	will need to set net.inet6.ip6.v6only=0, using sysctl(8).
+	
+===========================================================================
diff --git a/www/mozilla-bin/Makefile b/www/mozilla-bin/Makefile
index ee3b79a4c2f..e849c877659 100644
--- a/www/mozilla-bin/Makefile
+++ b/www/mozilla-bin/Makefile
@@ -1,74 +1,9 @@
-# $NetBSD: Makefile,v 1.12 2003/12/23 03:50:51 grant Exp $
-#
+# $NetBSD: Makefile,v 1.13 2004/01/04 05:01:02 grant Exp $
 
-DISTNAME=		# see Makefile.${OPSYS}.${ARCH}
-PKGNAME=		mozilla-bin-1.5
-WRKSRC=			${WRKDIR}/mozilla
-CATEGORIES=		www
+MOZILLA=	mozilla
+MOZ_VER=	1.5
 
-MAINTAINER=		grant@NetBSD.org
-HOMEPAGE=		http://www.mozilla.org/
-COMMENT=		Full featured gecko-based browser (binary pkg)
+ONLY_FOR_PLATFORM+=	Linux-*-i[3-6]86 NetBSD-*-i386
+ONLY_FOR_PLATFORM+=	SunOS-5.[789]*-sparc SunOS-5.[89]*-i386
 
-ONLY_FOR_PLATFORM=	Linux-*-i[3-6]86 NetBSD-*-i386 SunOS-5.[89]*-sparc
-
-CONFLICTS+=		mozilla-linux-[0-9]*
-
-NO_CONFIGURE=		# defined
-USE_PKGINSTALL=		YES
-
-.include "../../mk/bsd.prefs.mk"
-
-FILES_SUBST+=		PLATFORM=${PLATFORM}
-PLIST_SRC=		${WRKDIR}/PLIST_DYNAMIC
-
-do-build:
-
-post-build:
-	@${SED} ${FILES_SUBST_SED} ${FILESDIR}/mozilla.sh > \
-		${WRKDIR}/mozilla.sh
-
-do-install:
-	${INSTALL_DATA_DIR} ${MOZILLA_LIB}
-	cd ${WRKSRC} && ${PAX} -rw -pm . ${MOZILLA_LIB}
-	@${FIND} ${MOZILLA_LIB} -type f -print \
-		| ${XARGS} ${CHMOD} a+r
-	@${FIND} ${MOZILLA_LIB} \( -type f -o -perm -u+x \) -print \
-		| ${XARGS} ${CHMOD} a+rx
-	@${FIND} ${MOZILLA_LIB} -type d -print \
-		| ${XARGS} ${CHMOD} a+rx
-	${INSTALL_SCRIPT} ${WRKDIR}/mozilla.sh ${PREFIX}/bin/mozilla-${PLATFORM}
-
-post-install:
-# this build wants exactly 'libgtk-1.2.so.0', etc.
-.if ${OPSYS} == "SunOS" || ${OPSYS} == "Linux"
-	@cd ${MOZILLA_LIB} && \
-	${LN} -s ${PREFIX}/lib/libglib.*so* .;				\
-	${LN} -s ${PREFIX}/lib/libgmodule.*so* .;			\
-	${LN} -s ${X11PREFIX}/lib/libgdk.*so* .;			\
-	${LN} -s ${X11PREFIX}/lib/libgtk.*so* .;			\
-	${LN} -s libgtk.so libgtk-1.2.so.0;				\
-	${LN} -s libgdk.so libgdk-1.2.so.0;				\
-	${LN} -s libglib.so libglib-1.2.so.0;				\
-	${LN} -s libgmodule.so libgmodule-1.2.so.0
-.endif
-	@${CP} -f ${PKGDIR}/PLIST ${PLIST_SRC}
-	@${ECHO} bin/mozilla-${PLATFORM} >> ${PLIST_SRC}
-	@${FIND} ${MOZILLA_LIB} \( -type f -o -type l \) -print		\
-		| ${SORT} | ${SED} -e "s,${PREFIX}/,,g"			\
-		>> ${PLIST_SRC}
-	@${FIND} ${MOZILLA_LIB} -type d -print				\
-		| ${SORT} -r | ${SED} -e "s,${PREFIX}/,@dirrm ,g"	\
-		>> ${PLIST_SRC}
-
-.include "../../mk/bsd.prefs.mk"
-
-# everything specific to your OS/Arch goes into it's own Makefile
-# group together i386, i486, i586 and i686 (for Linux)
-ARCH=${MACHINE_ARCH:C/i[3-6]86/i386/g}
-
-.if exists(Makefile.${OPSYS}.${ARCH})
-.  include "Makefile.${OPSYS}.${ARCH}"
-.endif
-
-.include "../../mk/bsd.pkg.mk"
+.include "../../www/mozilla-bin/Makefile.common"
diff --git a/www/mozilla-bin/Makefile.Linux.i386 b/www/mozilla-bin/Makefile.Linux.i386
index d4775510a13..efc750fc081 100644
--- a/www/mozilla-bin/Makefile.Linux.i386
+++ b/www/mozilla-bin/Makefile.Linux.i386
@@ -1,10 +1,5 @@
-# $NetBSD: Makefile.Linux.i386,v 1.4 2003/11/27 16:07:46 grant Exp $
-#
+# $NetBSD: Makefile.Linux.i386,v 1.5 2004/01/04 05:01:02 grant Exp $
 
-DISTNAME=	mozilla-i686-pc-linux-gnu-1.5
-MASTER_SITES=	${MASTER_SITE_MOZILLA:=mozilla1.5/}
+DISTNAME=	mozilla-i686-pc-linux-gnu-${MOZ_VER}
 
-DEPENDS+=	gtk+>=1.2:../../x11/gtk
-
-PLATFORM=	linux
-MOZILLA_LIB=	${PREFIX}/lib/mozilla-${PLATFORM}
+MOZ_PLATFORM=	linux
diff --git a/www/mozilla-bin/Makefile.NetBSD.i386 b/www/mozilla-bin/Makefile.NetBSD.i386
index 402a00a59e4..c8c2b604b33 100644
--- a/www/mozilla-bin/Makefile.NetBSD.i386
+++ b/www/mozilla-bin/Makefile.NetBSD.i386
@@ -1,16 +1,5 @@
-# $NetBSD: Makefile.NetBSD.i386,v 1.5 2003/11/27 16:07:46 grant Exp $
-#
+# $NetBSD: Makefile.NetBSD.i386,v 1.6 2004/01/04 05:01:02 grant Exp $
 
-DISTNAME=	mozilla-i686-pc-linux-gnu-1.5
-MASTER_SITES=	${MASTER_SITE_MOZILLA:=mozilla1.5/}
+DISTNAME=	mozilla-i686-pc-linux-gnu-${MOZ_VER}
 
-PLATFORM=	linux
-MOZILLA_LIB=	${PREFIX}/lib/mozilla-${PLATFORM}
-
-DEPENDS+=	suse_compat>=7.3:../../emulators/${SUSE_DIR_PREFIX}_compat
-DEPENDS+=	suse_x11>=7.3:../../emulators/${SUSE_DIR_PREFIX}_x11
-DEPENDS+=	suse_gtk>=7.3:../../emulators/${SUSE_DIR_PREFIX}_gtk
-
-CONFLICTS+=	suse_libc5-[0-9]*
-
-.include "../../emulators/suse_linux/Makefile.application"
+MOZ_PLATFORM=	linux
diff --git a/www/mozilla-bin/Makefile.SunOS.i386 b/www/mozilla-bin/Makefile.SunOS.i386
index b60fcc6e5a7..399774e2f15 100644
--- a/www/mozilla-bin/Makefile.SunOS.i386
+++ b/www/mozilla-bin/Makefile.SunOS.i386
@@ -1,10 +1,5 @@
-# $NetBSD: Makefile.SunOS.i386,v 1.1 2003/11/27 16:07:46 grant Exp $
-#
+# $NetBSD: Makefile.SunOS.i386,v 1.2 2004/01/04 05:01:02 grant Exp $
 
-DISTNAME=	mozilla-i386-pc-solaris2.8-1.5
-MASTER_SITES=	${MASTER_SITE_MOZILLA:=mozilla1.5/contrib/}
+DISTNAME=	mozilla-i386-pc-solaris2.8-${MOZ_VER}
 
-DEPENDS+=	gtk+>=1.2:../../x11/gtk
-
-PLATFORM=	${LOWER_OPSYS}
-MOZILLA_LIB=	${PREFIX}/lib/mozilla-${PLATFORM}
+MOZ_PLATFORM=	solaris
diff --git a/www/mozilla-bin/Makefile.SunOS.sparc b/www/mozilla-bin/Makefile.SunOS.sparc
index 4ec31cd70d1..b7a643c648a 100644
--- a/www/mozilla-bin/Makefile.SunOS.sparc
+++ b/www/mozilla-bin/Makefile.SunOS.sparc
@@ -1,10 +1,5 @@
-# $NetBSD: Makefile.SunOS.sparc,v 1.3 2003/11/27 16:07:46 grant Exp $
-#
+# $NetBSD: Makefile.SunOS.sparc,v 1.4 2004/01/04 05:01:02 grant Exp $
 
-DISTNAME=	mozilla-sparc-sun-solaris2.8_1.5
-MASTER_SITES=	${MASTER_SITE_MOZILLA:=mozilla1.5/}
+DISTNAME=	mozilla-sparc-sun-solaris2.8_${MOZ_VER}
 
-DEPENDS+=	gtk+>=1.2:../../x11/gtk
-
-PLATFORM=	${LOWER_OPSYS}
-MOZILLA_LIB=	${PREFIX}/lib/mozilla-${PLATFORM}
+MOZ_PLATFORM=	solaris
diff --git a/www/mozilla-bin/Makefile.common b/www/mozilla-bin/Makefile.common
new file mode 100644
index 00000000000..907915ad006
--- /dev/null
+++ b/www/mozilla-bin/Makefile.common
@@ -0,0 +1,169 @@
+# $NetBSD: Makefile.common,v 1.1 2004/01/04 05:01:02 grant Exp $
+#
+
+DISTNAME=		# see Makefile.${OPSYS}.${ARCH}
+PKGNAME=		${MOZILLA}${MOZ_EXTRA}-bin-${MOZ_VER}
+WRKSRC=			${WRKDIR}/${MOZILLA}
+CATEGORIES=		www
+
+.if ${MOZILLA} == "MozillaFirebird"
+MOZILLA_SHORT=		firebird
+.else
+MOZILLA_SHORT=		${MOZILLA}
+.endif
+
+MASTER_SITES?=		http://ftp.mozilla.org/pub/${MOZILLA_SHORT}/releases/${MOZ_VER}/${MOZ_CONTRIB} \
+			ftp://ftp.mozilla.org/pub/${MOZILLA_SHORT}/releases/${MOZ_VER}/${MOZ_CONTRIB} \
+			http://public.planetmirror.com.au/pub/${MOZILLA_SHORT}/releases/${MOZ_VER}/${MOZ_CONTRIB} \
+			ftp://public.planetmirror.com.au/pub/${MOZILLA_SHORT}/releases/${MOZ_VER}/${MOZ_CONTRIB}
+
+MAINTAINER=		grant@NetBSD.org
+HOMEPAGE?=		http://www.mozilla.org/
+
+NO_CONFIGURE=		# defined
+
+FILESDIR=		${.CURDIR}/../../www/mozilla-bin/files
+
+USE_PKGINSTALL=		YES
+
+.include "../../mk/bsd.prefs.mk"
+
+# everything specific to your OS/Arch goes into it's own Makefile
+# group together i386, i486, i586 and i686 (for Linux)
+ARCH=${MACHINE_ARCH:C/i[3-6]86/i386/g}
+
+.if exists(${.CURDIR}/Makefile.${OPSYS}.${ARCH})
+.  include "${.CURDIR}/Makefile.${OPSYS}.${ARCH}"
+.endif
+
+# suffix gtk2 builds with -gtk2
+MOZ_EXTRA=	# empty
+.if defined(MOZ_GTK2) && ${MOZ_GTK2} == "YES"
+MOZ_EXTRA=	-gtk2
+.endif
+
+MOZILLA_LIB=	${PREFIX}/lib/${MOZILLA}${MOZ_EXTRA}-${MOZ_PLATFORM}
+
+FILES_SUBST+=	MOZILLA=${MOZILLA}
+FILES_SUBST+=	MOZ_EXTRA=${MOZ_EXTRA}
+FILES_SUBST+=	MOZ_PLATFORM=${MOZ_PLATFORM}
+PLIST_SRC=	${WRKDIR}/PLIST_DYNAMIC
+
+# protect against MOZ_PLATFORM being undefined so we don't bomb, but
+# instead use the result of ONLY_FOR_PLATFORM.
+.if defined(MOZ_PLATFORM)
+
+.  if ${OPSYS} == "NetBSD" && ${MOZ_PLATFORM} == "linux"
+MESSAGE_SRC+=	${.CURDIR}/../../www/mozilla-bin/MESSAGE.compat_linux
+.  endif
+
+# non-linux builds are "unofficial" and in contrib/
+MOZ_CONTRIB=	# empty
+.  if defined(MOZ_PLATFORM) && ${MOZ_PLATFORM} != "linux"
+MOZ_CONTRIB=	contrib/
+.  endif
+
+# Linux builds on NetBSD
+.  if ${OPSYS} == "NetBSD" && ${MOZ_PLATFORM} == "linux"
+.    include "../../emulators/suse_linux/Makefile.application"
+DEPENDS+=	suse_compat>=7.3:../../emulators/${SUSE_DIR_PREFIX}_compat
+DEPENDS+=	suse_x11>=7.3:../../emulators/${SUSE_DIR_PREFIX}_x11
+DEPENDS+=	suse_gtk>=7.3:../../emulators/${SUSE_DIR_PREFIX}_gtk
+CONFLICTS+=	suse_libc5-[0-9]*
+
+# NetBSD native builds are built with gtk-1.2.10nb5.
+.  elif ${OPSYS} == "NetBSD" && ${MOZ_PLATFORM} == "netbsd"
+DEPENDS+=	gtk+>=1.2.10nb5:../../x11/gtk
+
+# we need libstdc++.so.4 on -current.
+.    if !exists(/usr/lib/libstdc++.so.4)
+DEPENDS+=	compat16>=1.6.0:../../emulators/compat16
+_COMPAT16_LIBSTDCXX=	YES
+.    endif
+.  else
+
+# gtk2 builds.
+.    if defined(MOZ_GTK2) && ${MOZ_GTK2} == "YES"
+DEPENDS+=	gtk+>=2.2:../../x11/gtk2
+.    else
+
+# default to at least gtk-1.2.
+DEPENDS+=	gtk+>=1.2:../../x11/gtk
+.    endif
+.  endif
+
+.endif	# defined(MOZ_PLATFORM)
+
+# we don't want libnullplugin.
+post-extract:
+	@${RM} -f ${WRKSRC}/plugins/libnullplugin.so
+
+do-build:
+
+post-build:
+	@${SED} ${FILES_SUBST_SED} ${FILESDIR}/mozilla.sh > ${WRKDIR}/${MOZILLA}.sh
+
+do-install:
+	${INSTALL_DATA_DIR} ${MOZILLA_LIB}
+	cd ${WRKSRC} && ${PAX} -rw -pm . ${MOZILLA_LIB}
+	${INSTALL_SCRIPT} ${WRKDIR}/${MOZILLA}.sh ${PREFIX}/bin/${MOZILLA}${MOZ_EXTRA}-${MOZ_PLATFORM}
+	@${FIND} ${MOZILLA_LIB} -type f -print \
+		| ${XARGS} ${CHMOD} a+r
+	@${FIND} ${MOZILLA_LIB} \( -type f -o -perm -u+x \) -print \
+		| ${XARGS} ${CHMOD} a+rx
+	@${FIND} ${MOZILLA_LIB} -type d -print \
+		| ${XARGS} ${CHMOD} a+rx
+
+# builds typically want exactly 'libgtk-1.2.so.0', etc. symlink them
+# into the mozilla directory.
+post-install:
+.if ${OPSYS} != "NetBSD"
+.  if defined(MOZ_GTK2) && ${MOZ_GTK2} == "YES"
+	@cd ${MOZILLA_LIB} && \
+	${LN} -s ${PREFIX}/lib/libatk-1.0.*so* .;			\
+	${LN} -s ${X11PREFIX}/lib/libgdk-x11-2.0.*so* .;		\
+	${LN} -s ${PREFIX}/lib/libgdk_pixbuf-2.0.*so* .;		\
+	${LN} -s ${PREFIX}/lib/libglib-2.0.*so* .;			\
+	${LN} -s ${PREFIX}/lib/libgmodule-2.0.*so* .;			\
+	${LN} -s ${PREFIX}/lib/libgobject-2.0.*so* .;			\
+	${LN} -s ${X11PREFIX}/lib/libgtk-x11-2.0.*so* .;		\
+	${LN} -s ${PREFIX}/lib/libpango-1.0.*so* .;			\
+	${LN} -s ${PREFIX}/lib/libpangox-1.0.*so* .;			\
+	${LN} -s ${PREFIX}/lib/libpangoxft-1.0.*so* .;			\
+	\
+	${LN} -s libatk-1.0.so libatk-1.0.so.0;				\
+	${LN} -s libgdk-x11-2.0.so libgdk-x11-2.0.so.0;			\
+	${LN} -s libgdk_pixbuf-2.0.so libgdk_pixbuf-2.0.so.0;		\
+	${LN} -s libglib-2.0.so libglib-2.0.so.0;			\
+	${LN} -s libgmodule-2.0.so libgmodule-2.0.so.0;			\
+	${LN} -s libgobject-2.0.so libgobject-2.0.so.0;			\
+	${LN} -s libgtk-x11-2.0.so libgtk-x11-2.0.so.0;			\
+	${LN} -s libpango-1.0.so libpango-1.0.so.0;			\
+	${LN} -s libpangox-1.0.so libpangox-1.0.so.0;			\
+	${LN} -s libpangoxft-1.0.so libpangoxft-1.0.so.0
+.  else
+	@cd ${MOZILLA_LIB} && \
+	${LN} -s ${PREFIX}/lib/libglib.*so* .;				\
+	${LN} -s ${PREFIX}/lib/libgmodule.*so* .;			\
+	${LN} -s ${X11PREFIX}/lib/libgdk.*so* .;			\
+	${LN} -s ${X11PREFIX}/lib/libgtk.*so* .;			\
+	${LN} -s libgtk.so libgtk-1.2.so.0;				\
+	${LN} -s libgdk.so libgdk-1.2.so.0;				\
+	${LN} -s libglib.so libglib-1.2.so.0;				\
+	${LN} -s libgmodule.so libgmodule-1.2.so.0
+.  endif
+.endif
+.if defined(_COMPAT16_LIBSTDCXX) && ${_COMPAT16_LIBSTDCXX} == "YES"
+	@cd ${MOZILLA_LIB} && \
+		${LN} -s ${PREFIX}/emul/netbsd16/usr/lib/libstdc++.so* .
+.endif
+	@${CP} -f ${PKGDIR}/PLIST ${PLIST_SRC}
+	@${ECHO} bin/${MOZILLA}-${MOZ_PLATFORM} >> ${PLIST_SRC}
+	@${FIND} ${MOZILLA_LIB} \( -type f -o -type l \) -print		\
+		| ${SORT} | ${SED} -e "s,${PREFIX}/,,g"			\
+		>> ${PLIST_SRC}
+	@${FIND} ${MOZILLA_LIB} -type d -print				\
+		| ${SORT} -r | ${SED} -e "s,${PREFIX}/,@dirrm ,g"	\
+		>> ${PLIST_SRC}
+
+.include "../../mk/bsd.pkg.mk"
diff --git a/www/mozilla-bin/files/mozilla.sh b/www/mozilla-bin/files/mozilla.sh
index 5c108800dd3..5b69d4f5e37 100644
--- a/www/mozilla-bin/files/mozilla.sh
+++ b/www/mozilla-bin/files/mozilla.sh
@@ -1,7 +1,7 @@
 #!@SH@
-# $NetBSD: mozilla.sh,v 1.3 2003/07/18 07:31:16 grant Exp $
+# $NetBSD: mozilla.sh,v 1.4 2004/01/04 05:01:03 grant Exp $
 
-LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:@PREFIX@/lib/mozilla-@PLATFORM@:@PREFIX@/lib"
+LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:@PREFIX@/lib/@MOZILLA@@MOZ_EXTRA@-@MOZ_PLATFORM@:@PREFIX@/lib"
 export LD_LIBRARY_PATH
 
-exec @PREFIX@/lib/mozilla-@PLATFORM@/mozilla "$@"
+exec @PREFIX@/lib/@MOZILLA@@MOZ_EXTRA@-@MOZ_PLATFORM@/@MOZILLA@ "$@"