summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint
AgeCommit message (Collapse)AuthorFilesLines
2013-10-24pkglint is written in perl; it should depend on perl and not just somedholland1-3/+3
perl modules. (fix USE_TOOLS to have perl:run instead of just perl)
2013-10-12- Added check for unused license filesrillig3-21/+30
- Improved allowed filenames for patches - Added license for pkglint itself - Cleaned up Makefile and TODO
2013-10-12The hicolor-icon-theme issue has been resolved.rillig1-12/+1
2013-09-12Use CATMAN_SECTION_SUFFIX in packages which perform their own catmanjperkin1-1/+5
page installation.
2013-09-01tell TOOL_DEPENDS, same as BUILD_DEPENDS.obache2-2/+4
2013-08-31- When the source line is logged (option -s), an empty line aboverillig3-9/+24
helps to see which source line belongs to which warning. - PKGSRCTOP is a known variable. It is used only in the top-level Makefile. - Arbitrary tool names may be added to TOOLS_NOOP. - In the top-level Makefile, the alphabetic order of the SUBDIRs may have a single exception.
2013-08-15- added type definitions for two variablesrillig2-4/+23
- improved wording of some warnings - added explanations to some common warnings
2013-08-15Recognize apache24. Noted by Patrick Welche.wiz2-6/+6
Bump version.
2013-07-30+ Warn about using REPLACE_PYTHON without including application.mk.wiz1-1/+5
2013-07-20Use Mt for email addresses.wiz1-2/+2
2013-07-15Bump version for deprecated USE_GNU_READLINE.wiz1-3/+2
2013-07-15Deprecate USE_GNU_READLINE.wiz2-3/+5
2013-05-31Bump all packages for perl-5.18, thatwiz1-1/+2
a) refer 'perl' in their Makefile, or b) have a directory name of p5-*, or c) have any dependency on any p5-* package Like last time, where this caused no complaints.
2013-05-26rillig clarified:wiz2-5/+4
"u" means "use at runtime", i.e. the variable may not be available during preprocessing. "t" wasn't used at all (my error -- wiz) Bump version.
2013-05-07Add EXTRACT_DIR.wiz1-1/+2
2013-05-06pkglint-4.129obache2-9/+23
* explain when desktop-file-utils is required. * error missing {hicolor,gnome}-icon-theme.
2013-03-26Respond to wiz's code review:schmonz2-5/+5
* In test, match the "make makesum" warning more loosely. * In test, find packages to run against in $PKGSRCDIR explicitly. * Bump version. This is the last commit in a set developed for my "Rehabilitating pkglint" talk at pkgsrcCon 2013. Reviewed-at-pkgsrcCon-and-approved-during-the-freeze-by: wiz
2013-03-26Excessive self-grepping causes bugginess. Don't!schmonz2-7/+4
This regex almost certainly didn't intend to match an occurrence of "ARRAY" in PkgLint::Line, but it did match.
2013-03-26Mechanically refactor vartype_basic to dispatch table.schmonz1-542/+605
Leave the silly self-grep in place, adjusting to also match the lines that initialize the dispatch table. The underlying code is better and the tests still pass. (No functional change intended.)
2013-03-26Bag-compare all vartypes_basictypes, not just two.schmonz2-6/+34
pkglint greps itself (really) to generate this list of types. Test exhaustively for all types in the list today, so that the tested code can become more civilized tomorrow. Adds a test-time dependency on Test::Deep for cmp_bag().
2013-03-26Declare package pkglint (not main) in pkglint.pl.schmonz2-12/+10
This is more correct and more polite. For instance, pkglint.t no longer needs to declare a package of its own just for tests.
2013-03-26Subst paths for both test and install.schmonz1-3/+8
In the configure stage, tell pkglint to find *.map in ${FILESDIR}. That lets tests run even when pkglint isn't installed (which means it also makes the tests less wrong when pkglint is installed!). In the install stage, tell pkglint to find *.map under ${PREFIX}, as before (no functional change to the installed package). Specify USE_TOOLS=perl to quell pkglint. :-)
2013-03-26Document the need for many more automated tests.schmonz2-2/+8
2013-03-26Extract PkgLint::* to files, then inline them.schmonz13-1058/+1108
These bits of non-main functionality are distracting to the casual reader, and also to your intrepid refactorer. Since we recently added some characterization tests that run the pkglint executable against real packages, we can safely extract bits of code to separate files and prove nothing broke in the move. Instead of installing the new Perl modules where pkglint can find them at runtime, I've added a build step to inline them right back where they used to be (same order and everything). This is a little annoying, but less annoying than suddenly needing to deal with Perl runtime paths just for these few tiny modules. Also, loading modules at runtime would affect pkglint's performance, and I don't yet have performance tests to prove that this would be fine (or not), so I can't safely do it. No functional change intended.
2013-03-26Sanity-check pkglint on some reference packages.schmonz1-5/+86
2013-03-26Give test_unit() better defaults for easier calling.schmonz1-3/+5
This is the first commit in a set developed for my "Rehabilitating pkglint" talk at pkgsrcCon 2013. Reviewed-at-pkgsrcCon-and-approved-during-the-freeze-by: wiz
2013-03-08tell UAC_REQD_EXECS pkglint.obache1-1/+2
2013-03-06tell Cygwin and Haiku to pkglint.obache1-3/+3
2013-03-04Add FLEX_REQD.wiz1-1/+2
2013-01-23Fix typo in variable name.wiz1-2/+2
2013-01-20Test a couple more error paths through main() -> checkitem(). Addschmonz1-3/+36
a couple tests for get_vartypes_map(). TODO: test and refactor checkline_mk_vartype_basic().
2013-01-20pkglint(1) determines its list of basic variable types by greppingschmonz2-13/+49
itself for certain if/elsif conditions. This combination of cleverness and large conditional block should be replaced with simple, table-driven code. But first we have to get the functionality under test, which I've begun to do here. Initialize a package global with the contents of $0, and override it in test (otherwise self-grepping breaks because $0 is the test script). Extract the dirty Test::Trap details to test_unit(). Test main() for a few common values of @ARGV. Notice the aforementioned cleverness because it broke an expected success, and fix it just enough to test get_vartypes_basictypes() for a couple expected types. No functional change intended. I've manually tested the small changes to pkglint.pl and have also verified that a couple packages lint the same as before.
2013-01-19Make it possible to easily write automated tests:schmonz3-5/+38
* minimally adapt pkglint(1) into a "modulino" for testability * verify it still runs normally as a program * create a test script with a few very simple test cases * hook it up to 'make test' * verify that the tests really fail if I go breaking the code under test Meta-addresses PR pkg/46570. New BUILD_DEPENDS, but no functional change, so no PKGREVISION bump. Approved by wiz@.
2012-12-11Update to 4.127ryoon2-6/+6
* Add sun-{jre,jdk}7 support
2012-11-20Add openjdk7 & openjdk7-bin to other JVM listsabs2-3/+4
2012-10-03Bump version for python25 removal changes.wiz1-3/+2
2012-10-03Update for python25 removal.wiz1-2/+2
2012-10-03Bump all packages that use perl, or depend on a p5-* package, orwiz1-1/+2
are called p5-*. I hope that's all of them.
2012-09-16Update documentation for {PYTHON,RUBY,PHP}_VERSION_REQD variables, move themcheusov2-3/+6
to "user variables" section. pkglint is now aware of them. Bump pkglint version. Oked by wiz@
2012-09-15Do not warn about setting PKG_DESTDIR_SUPPORT any longer, it is nowwiz3-11/+4
set by default by the infrastructure. Remove highly obsolete TODO entry about destdir. Bump version.
2012-09-11"user-destdir" is default these daysasau1-2/+1
2012-08-26Improve expand_permission some more. Should fix thewiz2-9/+9
Use of uninitialized value in concatenation (.) or string at /usr/pkg/bin/pkglint line 4777. warnings. Bump version.
2012-08-05If I get to fix the bugs, I might as well OWN it.wiz1-2/+2
2012-08-03Recognize make syntax (make variable) in one more place.asau2-4/+4
2012-08-01Don't enforce purely aesthetic changes.asau2-8/+9
2012-07-27Improve warning about gettext/msgfmt dependency.wiz1-2/+2
In another part pkglint already knows that BUILD_USES_MSGFMT is deprecated, so a second run would have provided the correct answer.
2012-07-22Recognize emacs24nox; bump version.dholland2-5/+5
2012-07-17Really bump version for comment-missing-error change.wiz1-2/+2
2012-07-17Make missing comments in patches an error. Bump version.wiz1-5/+5
The guide prescribes it for quite some time and it's common courtesy for packages modifying packages after you. ok gdt@
2012-07-15pkgtools/pkglint: Add "ada" as valid value for USE_LANGUAGESmarino2-4/+4
The mk/compiler/gcc.mk was recently updated to handle USE_LANGUAGES+= ada which requires the use of the lang/gcc-aux compiler.
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-24 08:25:17 +0000