summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint
AgeCommit message (Collapse)AuthorFilesLines
2006-06-14In pax(1) command lines, -pe is deprecated in favor of -pp.rillig1-1/+9
2006-06-10Minor typo.adrianp1-2/+2
2006-06-09- Added "read" to the list of allowed shell commands.rillig1-6/+54
- Added an explanation for the ${WRKSRC}/.. warning, since it is not documented anywhere else. - Improved two diagnostics for buildlink3.mk files. - Added a check to discover package name mismatches in BUILDLINK_{ABI,API}_DEPENDS, as well as the version numbers.
2006-06-09I prefer #none over #empty in USE_LANGUAGES.rillig1-2/+2
2006-06-09In the SCST_COND state, a shell command is expected, so check here forrillig1-3/+3
known and unknown commands, too.
2006-06-09Minor improvements.rillig1-9/+13
2006-06-08The old syntax for List+ and InternalList+ does not exist anymore.rillig1-5/+2
2006-06-08- Fixed a typo in a diagnostic message from the buildlink3.mk check.rillig1-9/+15
- Added a warning for "Preformatted manual page without unformatted one".
2006-06-08Contrary to my (and maybe to others') expectations, INFO_FILES doesrillig1-2/+2
_not_ have the data type "List of Pathname", but "Yes".
2006-06-08Renamed $plist, $descr and $message to $lines, as it already is in therillig1-26/+26
other checkfile_* subroutines.
2006-06-08Packages that install info files should set INFO_FILES.rillig1-1/+6
2006-06-08Added explanations for two issues Tron stumbled upon when fixing therillig1-4/+23
warnings in devel/glib. Also, made the diagnostics for buildlink3.mk files clearer.
2006-06-08The ">&" shell operator is recognized correctly. A warning is printedrillig2-8/+75
for every shell command that is not known in the tools framework.
2006-06-08Minor improvements.rillig1-2/+3
2006-06-08Some things from the TODO list have been done.rillig1-6/+1
2006-06-08Only adjust the directory depth if there are exactly two leading ".."rillig1-3/+3
path components. The old behavior has led to error messages while checking the files in mk/flavor/pkg.
2006-06-08PKGREVISION does not need the :Q operator. The various *_MSG shellrillig1-3/+16
commands may be hidden with "@".
2006-06-08Replaced the explicit permission [*:a] with [$list], which preventsrillig1-16/+17
buildlink3.mk and builtin.mk files from modifying these variables.
2006-06-06The .include lines in mk/tools/bsd.tools.mk changed, hence pkglintrillig1-2/+3
didn't know the tools from the TOOLS framework anymore. Fixed that and added some code that will detect such a change in the future.
2006-06-06Completed the recent change by Stoned, who overlooked a second instancerillig1-2/+2
of bsd.sites.mk in a comment.
2006-06-06A variable that appears as a whole shell word may either be used as arillig1-4/+8
list of shell words, or sometimes as a single shell word. Compare: ${LD} ${LDFLAGS} and ./configure -libs ${LDFLAGS:Q}. So in this case, the :Q operator cannot be checked reliably.
2006-06-06Some small refinements.rillig1-5/+5
2006-06-06The new avatar of pkgsrc/mk/bsd.sites.mk is named pkgsrc/mk/fetch/sites.mkseb1-2/+2
2006-06-06Added the proper types for many of the variables that have beenrillig1-40/+61
unchecked before (mainly because of limitations in earlier pkglint versions). Added ACL constants for user-defined, system-defined and command-line variables.
2006-06-06Enumerations don't need the :Q operator.rillig2-4/+6
2006-06-06Improved variable_needs_quoting.rillig2-8/+30
2006-06-06Updated pkglint to 4.64.rillig1-2/+2
Changes since 4.63: - Many diagnostics for the :Q operator have been wrong. They are currently left out, but will be re-added later. In the mean time, no diagnostics are better than wrong ones. - Made defining the permissions for variables easier by providing a way to define "permission constants".
2006-06-06When it is not clear whether the :Q operator should be used or not,rillig1-6/+3
return dont_know instead of true.
2006-06-05Added the command line argument -D{foo,bar,...} that enables or disablesrillig3-65/+134
certain categories of debugging output.
2006-06-05Minor corrections.rillig1-3/+3
2006-06-03Added an explanation for the warning that "Each sed command shouldrillig1-2/+10
appear in an assignment of its own", since it had been misunderstood at least once. Also, since the explanation is usually several lines long, it does not hurt to add two extra empty lines to separate the explanation from the actual warning.
2006-06-03In Makefile.common, the standard list variables may be set using "="rillig1-2/+5
instead of only appending with "+=".
2006-06-03Added the possibility of defining custom ACLs in the file makevars.map.rillig2-63/+109
2006-06-03Updated pkglint to 4.63.rillig1-2/+2
Changes since 4.62: - Improved checking of variable permissions. - Improved detection of unused variables, for spell checking. - Added warnings for variables that are used at load time but should not. - Much code cleanup.
2006-06-03Improved the variable specification in makevars.map. Code cleanup.rillig2-10/+22
2006-06-03Add a wish for PYTHON_VERSIONS_INCOMPATIBLE.joerg1-1/+3
2006-06-03Updated the TODO list.rillig2-23/+32
2006-06-02Run-time variables should not be used in load-time variables.rillig2-5/+27
2006-06-02MASTER_SITE* may be used at run-time. Various other small changes.rillig1-26/+31
2006-06-02Removed the subroutine type_should_be_quoted. In extract_used_variables,rillig1-21/+8
a "." is allowed in the variable name. Changed two instances of log_note to log_debug. Unmatched directives like .endif or .endfor are an error.
2006-05-31Using the := operator has subtle effects on the number of '$' charactersrillig1-2/+6
in strings. So don't use them.
2006-05-31Added a check for variables that are evaluated at load time. Especiallyrillig2-13/+58
for lists of something, this can lead to unexpected behavior. Currently, only the variables BUILDLINK_DEPENDS, BUILDLINK_PACKAGES and PKG_OPTIONS may be looked at during load time. This warning reveals the bad practice to "patch" CONFIGURE_ARGS at load time, for example: > CONFIGURE_ARGS:= ${CONFIGURE_ARGS:S/--disable-esd/--enable-esd/} WARN: audio/bmp-esound/Makefile:14: CONFIGURE_ARGS should not be evaluated at load time.
2006-05-31Fixed indentation level in checkline_mk_vartype.rillig1-29/+29
2006-05-31The checks for variable use and correct quoting have been concentratedrillig2-107/+298
into a single subroutine, checkline_mk_varuse, which replaces the various ad-hoc checks. Added the class PkgLint::VarUseContext that tries to model the context in which a make(1) variable can appear. The checks are much better now than before, but there's still work to do. Added a new type FileMode for file permissions. Currently no warnings are printed for untyped variables (that is, user-defined and not following the common naming schemes). This includes the iteration variables of .for loops. Since many of the warnings have been overly strict, this is not a big loss.
2006-05-31Some minor fixes and additions.rillig1-3/+5
2006-05-31SHLIB_HANDLING and USE_RMAN are deprecated.rillig1-1/+3
2006-05-23Moved the code that guesses the type of a variable based on its namerillig1-36/+40
into get_variable_type(). Added a new field PkgLint::Type::is_guessed that can be checked later.
2006-05-23Prevented warnings when defining the new FETCH_MESSAGE.rillig2-2/+5
2006-05-23- _FETCH_MESSAGE, BUILDLINK_RECOMMENDED.* and BUILDLINK_DEPENDS.* arerillig3-11/+26
deprecated. - CONFLICT is just a spelling mistake and therefore should not appear in the list of deprecated variables. - Made handling of parameterized variables more uniform.
2006-05-23The "future directions" chapter gives a vision of what pkglint may do ifrillig3-2/+53
I find too much time.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-31 00:12:52 +0000