1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
|
<!-- $NetBSD: infr.design.xml,v 1.10 2016/07/09 16:19:15 rillig Exp $ -->
<chapter id="infr.design"> <?dbhtml filename="infr.design.html"?>
<title>Design of the pkgsrc infrastructure</title>
<para>The pkgsrc infrastructure consists of many small Makefile
fragments. Each such fragment needs a properly specified
interface. This chapter explains how such an interface looks
like.</para>
<!--
<sect1 id="infr.intro">
<title>Introduction</title>
</sect1>
-->
<sect1 id="infr.vardef">
<title>The meaning of variable definitions</title>
<para>Whenever a variable is defined in the pkgsrc
infrastructure, the location and the way of definition provide
much information about the intended use of that variable.
Additionally, more documentation may be found in a header
comment or in this pkgsrc guide.</para>
<para>A special file is
<filename>mk/defaults/mk.conf</filename>, which lists all
variables that are intended to be user-defined. They are either
defined using the <literal>?=</literal> operator or they are
left undefined because defining them to anything would
effectively mean <quote>yes</quote>. All these variables may be
overridden by the pkgsrc user in the <varname>MAKECONF</varname>
file.</para>
<para>Outside this file, the following conventions apply:
Variables that are defined using the <literal>?=</literal>
operator may be overridden by a package.</para>
<para>Variables that are defined using the <literal>=</literal>
operator may be used read-only at run-time.</para>
<para>Variables whose name starts with an underscore must not be
accessed outside the pkgsrc infrastructure at all. They may
change without further notice.</para>
<note><para>These conventions are currently not applied
consistently to the complete pkgsrc
infrastructure.</para></note>
</sect1>
<sect1 id="infr.vardef.problems">
<title>Avoiding problems before they arise</title>
<para>All variables that contain lists of things should default
to being empty. Two examples that do not follow this rule are
<varname>USE_LANGUAGES</varname> and
<varname>DISTFILES</varname>. These variables cannot simply be
modified using the <literal>+=</literal> operator in package
<filename>Makefile</filename>s (or other files included by
them), since there is no guarantee whether the variable is
already set or not, and what its value is. In the case of
<varname>DISTFILES</varname>, the packages <quote>know</quote>
the default value and just define it as in the following
example.</para>
<programlisting>
DISTFILES= ${DISTNAME}${EXTRACT_SUFX} additional-files.tar.gz
</programlisting>
<para>Because of the selection of this default value, the same
value appears in many package Makefiles. Similarly for
<varname>USE_LANGUAGES</varname>, but in this case the default
value (<quote><literal>c</literal></quote>) is so short that it
doesn't stand out. Nevertheless it is mentioned in many
files.</para>
</sect1>
<sect1 id="infr.var">
<title>Variable evaluation</title>
<sect2 id="infr.var.load">
<title>At load time</title>
<para>Variable evaluation takes place either at load time or at
runtime, depending on the context in which they occur. The
contexts where variables are evaluated at load time are:</para>
<itemizedlist>
<listitem><para>The right hand side of the <literal>:=</literal>
and <literal>!=</literal> operators,</para></listitem>
<listitem><para>Make directives like <literal>.if</literal> or
<literal>.for</literal>,</para></listitem>
<listitem><para>Dependency lines.</para></listitem>
</itemizedlist>
<para>A special exception are references to the iteration
variables of <literal>.for</literal> loops, which are expanded
inline, no matter in which context they appear.</para>
<para>As the values of variables may change during load time,
care must be taken not to evaluate them by accident. Typical
examples for variables that should not be evaluated at load time
are <varname>DEPENDS</varname> and
<varname>CONFIGURE_ARGS</varname>. To make the effect more
clear, here is an example:</para>
<programlisting>
CONFIGURE_ARGS= # none
CFLAGS= -O
CONFIGURE_ARGS+= CFLAGS=${CFLAGS:Q}
CONFIGURE_ARGS:= ${CONFIGURE_ARGS}
CFLAGS+= -Wall
</programlisting>
<para>This code shows how the use of the <literal>:=</literal>
operator can quickly lead to unexpected results. The first
paragraph is fairly common code. The second paragraph evaluates
the <varname>CONFIGURE_ARGS</varname> variable, which results in
<literal>CFLAGS=-O</literal>. In the third paragraph, the
<literal>-Wall</literal> is appended to the
<varname>CFLAGS</varname>, but this addition will not appear in
<varname>CONFIGURE_ARGS</varname>. In actual code, the three
paragraphs from above typically occur in completely unrelated
files.</para>
</sect2>
<sect2 id="infr.var.run">
<title>At runtime</title>
<para>After all the files have been loaded, the values of the
variables cannot be changed anymore. Variables that are used in
the shell commands are expanded at this point.</para>
</sect2>
</sect1>
<sect1 id="infr.varspec">
<title>How can variables be specified?</title>
<para>There are many ways in which the definition and use of a
variable can be restricted in order to detect bugs and violations
of the (mostly unwritten) policies. A package can be checked with
<literal>pkglint -Wall</literal> to see whether it meets these
rules.</para>
</sect1>
<sect1 id="infr.design.intf">
<title>Designing interfaces for Makefile fragments</title>
<para>Most of the <filename>.mk</filename> files fall into one
of the following classes. Cases where a file falls into more
than one class should be avoided as it often leads to subtle
bugs.</para>
<sect2 id="infr.design.intf.proc">
<title>Procedures with parameters</title>
<para>In a traditional imperative programming language some of
the <filename>.mk</filename> files could be described as
procedures. They take some input parameters and—after
inclusion—provide a result in output parameters. Since all
variables in <filename>Makefile</filename>s have global scope
care must be taken not to use parameter names that have already
another meaning. For example, <varname>PKGNAME</varname> is a
bad choice for a parameter name.</para>
<para>Procedures are completely evaluated at preprocessing time.
That is, when calling a procedure all input parameters must be
completely resolvable. For example,
<varname>CONFIGURE_ARGS</varname> should never be an input
parameter since it is very likely that further text will be
added after calling the procedure, which would effectively apply
the procedure to only a part of the variable. Also, references
to other variables will be modified after calling the
procedure.</para>
<para>A procedure can declare its output parameters either as
suitable for use in preprocessing directives or as only
available at runtime. The latter alternative is for variables
that contain references to other runtime variables.</para>
<para>Procedures shall be written such that it is possible to
call the procedure more than once. That is, the file must not
contain multiple-inclusion guards.</para>
<para>Examples for procedures are
<filename>mk/bsd.options.mk</filename> and
<filename>mk/buildlink3/bsd.builtin.mk</filename>. To express
that the parameters are evaluated at load time, they should be
assigned using the <literal>:=</literal> operator, which should
be used only for this purpose.</para>
</sect2>
<sect2 id="infr.design.intf.action">
<title>Actions taken on behalf of parameters</title>
<para>Action files take some input parameters and may define
runtime variables. They shall not define loadtime variables.
There are action files that are included implicitly by the
pkgsrc infrastructure, while other must be included
explicitly.</para>
<para>An example for action files is
<filename>mk/subst.mk</filename>.</para>
</sect2>
</sect1>
<sect1 id="infr.order">
<title>The order in which files are loaded</title>
<para>Package <filename>Makefile</filename>s usually consist of
a set of variable definitions, and include the file
<filename>../../mk/bsd.pkg.mk</filename> in the very last line.
Before that, they may also include various other
<filename>*.mk</filename> files if they need to query the
availability of certain features like the type of compiler or
the X11 implementation. Due to the heavy use of preprocessor
directives like <literal>.if</literal> and
<literal>.for</literal>, the order in which the files are loaded
matters.</para>
<para>This section describes at which point the various files
are loaded and gives reasons for that order.</para>
<sect2 id="infr.order.prefs">
<title>The order in <filename>bsd.prefs.mk</filename></title>
<para>The very first action in <filename>bsd.prefs.mk</filename>
is to define some essential variables like
<varname>OPSYS</varname>, <varname>OS_VERSION</varname> and
<varname>MACHINE_ARCH</varname>.</para>
<para>Then, the user settings are loaded from the file specified
in <varname>MAKECONF</varname>, which is usually &mk.conf;.
After that, those variables
that have not been overridden by the user are loaded from
<filename>mk/defaults/mk.conf</filename>.</para>
<para>After the user settings, the system settings and platform
settings are loaded, which may override the user
settings.</para>
<para>Then, the tool definitions are loaded. The tool wrappers
are not yet in effect. This only happens when building a
package, so the proper variables must be used instead of the
direct tool names.</para>
<para>As the last steps, some essential variables from the
wrapper and the package system flavor are loaded, as well as the
variables that have been cached in earlier phases of a package
build.</para>
</sect2>
<sect2 id="infr.order.pkg">
<title>The order in <filename>bsd.pkg.mk</filename></title>
<para>First, <filename>bsd.prefs.mk</filename> is loaded.</para>
<para>Then, the various <filename>*-vars.mk</filename> files are
loaded, which fill default values for those variables that have
not been defined by the package. These variables may later
be used even in unrelated files.</para>
<para>Then, the file <filename>bsd.pkg.error.mk</filename>
provides the target <literal>error-check</literal> that is added
as a special dependency to all other targets that use
<varname>DELAYED_ERROR_MSG</varname> or
<varname>DELAYED_WARNING_MSG</varname>.</para>
<para>Then, the package-specific hacks from
<filename>hacks.mk</filename> are included.</para>
<!-- bsd.pkg.use.mk -->
<para>Then, various other files follow. Most of them don't have
any dependencies on what they need to have included before or
after them, though some do.</para>
<para>The code to check <varname>PKG_FAIL_REASON</varname> and
<varname>PKG_SKIP_REASON</varname> is then executed, which
restricts the use of these variables to all the files that have
been included before. Appearances in later files will be
silently ignored.</para>
<para>Then, the files for the main targets are included, in the
order of later execution, though the actual order should not
matter.</para>
<para>At last, some more files are included that don't set any
interesting variables but rather just define make targets to be
executed.</para>
</sect2>
</sect1>
</chapter>
|