1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
package pkglint
import "gopkg.in/check.v1"
func (s *Suite) Test_CheckFileAlternatives__empty(c *check.C) {
t := s.Init(c)
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES")
G.Pkg = NewPackage(".")
CheckFileAlternatives("ALTERNATIVES")
t.CheckOutputLines(
"ERROR: ALTERNATIVES: Must not be empty.")
}
func (s *Suite) Test_CheckFileAlternatives__ALTERNATIVES_SRC(c *check.C) {
t := s.Init(c)
// It's a strange situation, having an ALTERNATIVES file defined by
// the package but then referring to another package's file by means
// of ALTERNATIVES_SRC. As of February 2019 I don't remember if I
// really had this case in mind when I initially wrote the code in
// CheckFileAlternatives.
t.SetUpPackage("category/package",
"ALTERNATIVES_SRC=\talts")
t.CreateFileLines("category/package/ALTERNATIVES",
"bin/pgm @PREFIX@/bin/gnu-program",
"bin/pgm @PREFIX@/bin/nb-program")
t.FinishSetUp()
G.Check(t.File("category/package"))
// The ALTERNATIVES file in this package is not checked at all.
// If it were, there would be an error for the repeated bin/pgm.
t.CheckOutputEmpty()
}
func (s *Suite) Test_AlternativesChecker_Check__PLIST(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES",
"sbin/sendmail @PREFIX@/sbin/sendmail.postfix@POSTFIXVER@",
"sbin/sendmail @PREFIX@/sbin/sendmail.exim@EXIMVER@",
"bin/echo bin/gnu-echo",
"bin/editor bin/vim -e",
"invalid",
"bin/browser\t${PREFIX}/bin/firefox",
"highscores @VARBASE@/game/scores",
"sbin/init /sbin/init")
t.CreateFileLines("PLIST",
PlistCvsID,
"bin/echo",
"bin/vim",
"sbin/sendmail.exim${EXIMVER}")
t.FinishSetUp()
G.Check(".")
t.CheckOutputLines(
"ERROR: ALTERNATIVES:1: Alternative implementation \"@PREFIX@/sbin/sendmail.postfix@POSTFIXVER@\" "+
"must appear in the PLIST as \"sbin/sendmail.postfix${POSTFIXVER}\".",
"ERROR: ALTERNATIVES:3: Alternative wrapper \"bin/echo\" must not appear in the PLIST.",
"ERROR: ALTERNATIVES:3: Alternative implementation \"bin/gnu-echo\" must appear in the PLIST.",
"ERROR: ALTERNATIVES:3: Alternative implementation \"bin/gnu-echo\" must be an absolute path.",
"ERROR: ALTERNATIVES:4: Alternative implementation \"bin/vim\" must be an absolute path.",
"ERROR: ALTERNATIVES:5: Invalid line \"invalid\".",
"ERROR: ALTERNATIVES:6: Alternative implementation \"${PREFIX}/bin/firefox\" must appear in the PLIST.",
"ERROR: ALTERNATIVES:6: Alternative implementation \"${PREFIX}/bin/firefox\" must be an absolute path.",
"ERROR: ALTERNATIVES:7: Alternative implementation \"@VARBASE@/game/scores\" "+
"must appear in the PLIST as \"${VARBASE}/game/scores\".")
t.SetUpCommandLine("--autofix")
G.Check(".")
t.CheckOutputLines(
"AUTOFIX: ALTERNATIVES:3: Replacing \"bin/gnu-echo\" with \"@PREFIX@/bin/gnu-echo\".",
"AUTOFIX: ALTERNATIVES:4: Replacing \"bin/vim\" with \"@PREFIX@/bin/vim\".")
}
func (s *Suite) Test_AlternativesChecker_checkLine(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES",
"bin/no-args @PREFIX@/bin/echo",
"bin/with-args @PREFIX@/bin/echo hello,",
"bin/with-quoted-args @PREFIX@/bin/echo \"hello, world\" \\ cowboy",
"bin/trailing @PREFIX@/bin/echo spaces ", // TODO: warn about this
"/abs-echo @PREFIX@/bin/echo")
t.CreateFileLines("PLIST",
PlistCvsID,
"bin/echo")
t.FinishSetUp()
G.Check(".")
t.CheckOutputLines(
"ERROR: ALTERNATIVES:5: Alternative wrapper \"/abs-echo\" " +
"must be relative to PREFIX.")
}
func (s *Suite) Test_AlternativesChecker_checkWrapperAbs(c *check.C) {
t := s.Init(c)
t.CreateFileLines("ALTERNATIVES",
"relative @PREFIX@/bin/echo",
"/absolute @PREFIX@/bin/echo")
CheckFileAlternatives(t.File("ALTERNATIVES"))
t.CheckOutputLines(
"ERROR: ~/ALTERNATIVES:2: Alternative wrapper \"/absolute\" " +
"must be relative to PREFIX.")
}
func (s *Suite) Test_AlternativesChecker_checkWrapperPlist(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES",
"bin/echo @PREFIX@/bin/gnu-echo",
"bin/editor @PREFIX@/bin/vim -e")
t.CreateFileLines("PLIST",
PlistCvsID,
"bin/echo",
"bin/gnu-echo",
"bin/vim")
t.FinishSetUp()
G.Check(".")
t.CheckOutputLines(
"ERROR: ALTERNATIVES:1: Alternative wrapper \"bin/echo\" " +
"must not appear in the PLIST.")
}
func (s *Suite) Test_AlternativesChecker_checkAlternativeAbs(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES",
"bin/echo bin/gnu-echo",
"bin/editor bin/vim -e")
t.CreateFileLines("PLIST",
PlistCvsID,
"bin/echo",
"bin/gnu-echo",
"bin/vim")
t.FinishSetUp()
t.CheckOutputEmpty()
}
// A file that is mentioned in the ALTERNATIVES file must appear
// in the package's PLIST files. It may appear there conditionally,
// assuming that manual testing will reveal inconsistencies. Or
// that this scenario is an edge case anyway.
func (s *Suite) Test_AlternativesChecker_checkAlternativePlist__conditional(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Chdir("category/package")
t.CreateFileLines("ALTERNATIVES",
"bin/wrapper1 @PREFIX@/bin/always-exists",
"bin/wrapper2 @PREFIX@/bin/conditional",
"bin/wrapper3 @PREFIX@/bin/not-found")
t.CreateFileLines("PLIST",
PlistCvsID,
"bin/always-exists",
"${PLIST.cond}bin/conditional")
t.FinishSetUp()
G.Check(".")
t.CheckOutputLines(
"ERROR: ALTERNATIVES:3: Alternative implementation \"@PREFIX@/bin/not-found\" " +
"must appear in the PLIST as \"bin/not-found\".")
}
// When a man page is mentioned in the ALTERNATIVES file, it must use the
// PKGMANDIR variable. In the PLIST files though, there is some magic
// in the pkgsrc infrastructure that maps man/ to ${PKGMANDIR}, which
// leads to a bit less typing.
//
// Seen in graphics/py-blockdiag.
func (s *Suite) Test_AlternativesChecker_checkAlternativePlist__PKGMANDIR(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.CreateFileLines("category/package/ALTERNATIVES",
"@PKGMANDIR@/man1/blockdiag @PREFIX@/@PKGMANDIR@/man1/blockdiag-@PYVERSSUFFIX@.1")
t.CreateFileLines("category/package/PLIST",
PlistCvsID,
"man/man1/blockdiag-${PYVERSSUFFIX}.1")
t.FinishSetUp()
G.Check(t.File("category/package"))
t.CheckOutputEmpty()
}
|
