1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
|
package main
import "gopkg.in/check.v1"
func (s *Suite) Test_ChecklinesBuildlink3Mk(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"# XXX This file was created automatically using createbuildlink-@PKGVERSION@",
"",
"BUILDLINK_TREE+= Xbae",
"",
"BUILDLINK_DEPMETHOD.Xbae?=\tfull",
".if !defined(XBAE_BUILDLINK3_MK)",
"XBAE_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.Xbae+= Xbae>=4.8.4",
"BUILDLINK_ABI_DEPENDS.Xbae+= Xbae>=4.51.01nb2",
"BUILDLINK_PKGSRCDIR.Xbae?= ../../x11/Xbae",
"",
".include \"../../mk/motif.buildlink3.mk\"",
".endif # XBAE_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+= -Xbae")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"ERROR: buildlink3.mk:12: \"/x11/Xbae\" does not exist.",
"ERROR: buildlink3.mk:12: There is no package in \"x11/Xbae\".",
"ERROR: buildlink3.mk:14: \"/mk/motif.buildlink3.mk\" does not exist.",
"ERROR: buildlink3.mk:2: This comment indicates unfinished work (url2pkg).")
}
// Before version 5.3, pkglint wrongly warned here.
// The mk/haskell.mk file takes care of constructing the correct PKGNAME,
// but pkglint had not looked at that file.
func (s *Suite) Test_ChecklinesBuildlink3Mk_name_mismatch(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
G.Pkg = NewPackage("x11/hs-X11")
G.Pkg.EffectivePkgbase = "X11"
G.Pkg.EffectivePkgnameLine = t.NewMkLine("Makefile", 3, "DISTNAME=\tX11-1.0")
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\ths-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11>=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X11>=1.6.1.2nb2",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"ERROR: buildlink3.mk:3: Package name mismatch between \"hs-X11\" in this file and \"X11\" from Makefile:3.")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_name_mismatch_multiple_inclusion(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\tpkgbase1",
"",
".if !defined(PKGBASE2_BUILDLINK3_MK)",
"PKGBASE2_BUILDLINK3_MK:=",
"",
".endif",
"",
"BUILDLINK_TREE+=\t-pkgbase1")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"ERROR: buildlink3.mk:5: Package name mismatch between multiple-inclusion guard \"PKGBASE2\" (expected \"PKGBASE1\") and package name \"pkgbase1\" (from line 3).",
"WARN: buildlink3.mk:9: Definition of BUILDLINK_API_DEPENDS is missing.")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_name_mismatch_abi_api(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\ths-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11>=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X12>=1.6.1.2nb2",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:9: Package name mismatch between ABI \"hs-X12\" and API \"hs-X11\" (from line 8).")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_abi_api_versions(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\ths-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11>=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X11>=1.6.0",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:9: ABI version \"1.6.0\" should be at least API version \"1.6.1\" (see line 8).")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_no_BUILDLINK_TREE_at_beginning(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_DEPMETHOD.hs-X11?=\tfull",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11>=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X11>=1.6.1.2nb2",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:3: Expected a BUILDLINK_TREE line.")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_no_BUILDLINK_TREE_at_end(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_DEPMETHOD.hs-X11?=\tfull",
"",
"BUILDLINK_TREE+=\ths-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11>=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X11>=1.6.1.2nb2",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"# needless comment",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:3: This line belongs inside the .ifdef block.",
"WARN: buildlink3.mk:15: This line should contain the following text: BUILDLINK_TREE+=\t-hs-X11")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_multiple_inclusion_wrong(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\ths-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"UNRELATED_BUILDLINK3_MK:=")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:6: UNRELATED_BUILDLINK3_MK is defined but not used. Spelling mistake?",
"WARN: buildlink3.mk:6: This line should contain the following text: HS_X11_BUILDLINK3_MK:=")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_missing_endif(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\tpkgbase1",
"",
".if !defined(PKGBASE1_BUILDLINK3_MK)",
"PKGBASE1_BUILDLINK3_MK:=")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:EOF: Expected .endif")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_unknown_dependency_patterns(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+= hs-X11",
"",
".if !defined(HS_X11_BUILDLINK3_MK)",
"HS_X11_BUILDLINK3_MK:=",
"",
"BUILDLINK_DEPMETHOD.hs-X11?=\tfull",
"BUILDLINK_API_DEPENDS.hs-X11+=\ths-X11!=1.6.1",
"BUILDLINK_ABI_DEPENDS.hs-X11+=\ths-X11!=1.6.1.2nb2",
"",
".endif\t# HS_X11_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+=\t-hs-X11")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:9: Unknown dependency pattern \"hs-X11!=1.6.1\".",
"WARN: buildlink3.mk:10: Unknown dependency pattern \"hs-X11!=1.6.1.2nb2\".")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_PKGBASE_with_variable(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\t${PYPKGPREFIX}-wxWidgets",
"",
".if !defined(PY_WXWIDGETS_BUILDLINK3_MK)",
"PY_WXWIDGETS_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.${PYPKGPREFIX}-wxWidgets+=\t${PYPKGPREFIX}-wxWidgets>=2.6.1.0",
"BUILDLINK_ABI_DEPENDS.${PYPKGPREFIX}-wxWidgets+=\t${PYPKGPREFIX}-wxWidgets>=2.8.10.1nb26",
"",
".endif",
"",
"BUILDLINK_TREE+=\t-${PYPKGPREFIX}-wxWidgets")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:3: Please use \"py\" instead of \"${PYPKGPREFIX}\" (also in other variables in this file).")
}
func (s *Suite) Test_ChecklinesBuildlink3Mk_PKGBASE_with_unknown_variable(c *check.C) {
t := s.Init(c)
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
"BUILDLINK_TREE+=\t${LICENSE}-wxWidgets",
"",
".if !defined(LICENSE_BUILDLINK3_MK)",
"LICENSE_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.${LICENSE}-wxWidgets+=\t${PYPKGPREFIX}-wxWidgets>=2.6.1.0",
"BUILDLINK_ABI_DEPENDS.${LICENSE}-wxWidgets+=\t${PYPKGPREFIX}-wxWidgets>=2.8.10.1nb26",
"",
".endif",
"",
"BUILDLINK_TREE+=\t-${PYPKGPREFIX}-wxWidgets")
ChecklinesBuildlink3Mk(mklines)
t.CheckOutputLines(
"WARN: buildlink3.mk:3: Please replace \"${LICENSE}\" with a simple string (also in other variables in this file).",
"WARN: buildlink3.mk:13: This line should contain the following text: BUILDLINK_TREE+=\t-${LICENSE}-wxWidgets")
}
// Those .include lines that are not indented at all may stay as-is.
// This special exception might have been for backwards-compatibility,
// but ideally should be handled like everywhere else.
// See MkLineChecker.checkInclude.
func (s *Suite) Test_ChecklinesBuildlink3Mk_indentation(c *check.C) {
t := s.Init(c)
t.SetupCommandLine("-Wall")
G.globalData.InitVartypes()
mklines := t.NewMkLines("buildlink3.mk",
MkRcsId,
"",
".if ${VAAPI_AVAILABLE} == \"yes\"",
"",
"BUILDLINK_TREE+= libva",
"",
". if !defined(LIBVA_BUILDLINK3_MK)",
"LIBVA_BUILDLINK3_MK:=",
"",
"BUILDLINK_API_DEPENDS.libva+= libva>=1.0.6",
"BUILDLINK_PKGSRCDIR.libva?= ../../multimedia/libva",
"",
".include \"../../x11/libX11/buildlink3.mk\"",
"",
". endif # LIBVA_BUILDLINK3_MK",
"",
"BUILDLINK_TREE+= -libva",
"",
".endif # VAAPI_AVAILABLE")
ChecklinesBuildlink3Mk(mklines)
// No warning about the indentation of the .include lines.
t.CheckOutputLines(
"ERROR: buildlink3.mk:11: \"/multimedia/libva\" does not exist.",
"ERROR: buildlink3.mk:11: There is no package in \"multimedia/libva\".",
"ERROR: buildlink3.mk:13: \"/x11/libX11/buildlink3.mk\" does not exist.",
"WARN: buildlink3.mk:3: Expected a BUILDLINK_TREE line.")
}
|
