1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
|
package pkglint
import (
"gopkg.in/check.v1"
)
func (s *Suite) Test_convertToLogicalLines__no_continuation(c *check.C) {
rawText := "" +
"first line\n" +
"second line\n"
lines := convertToLogicalLines("filename", rawText, false)
c.Check(lines.Len(), equals, 2)
c.Check(lines.Lines[0].String(), equals, "filename:1: first line")
c.Check(lines.Lines[1].String(), equals, "filename:2: second line")
}
func (s *Suite) Test_convertToLogicalLines__continuation(c *check.C) {
rawText := "" +
"first line, \\\n" +
"still first line\n" +
"second line\n"
lines := convertToLogicalLines("filename", rawText, true)
c.Check(lines.Len(), equals, 2)
c.Check(lines.Lines[0].String(), equals, "filename:1--2: first line, still first line")
c.Check(lines.Lines[1].String(), equals, "filename:3: second line")
}
func (s *Suite) Test_convertToLogicalLines__continuation_in_last_line(c *check.C) {
t := s.Init(c)
rawText := "" +
"last line\\\n"
lines := convertToLogicalLines("filename", rawText, true)
c.Check(lines.Len(), equals, 1)
c.Check(lines.Lines[0].String(), equals, "filename:1: last line\\")
t.CheckOutputEmpty()
}
// In Makefiles, comment lines can also have continuations.
// See devel/bmake/files/unit-tests/comment.mk
func (s *Suite) Test_convertToLogicalLines__comments(c *check.C) {
t := s.Init(c)
mklines := t.SetUpFileMkLines("comment.mk",
"# This is a comment",
"",
"#\\",
"\tMultiline comment",
"# Another escaped comment \\",
"that \\",
"goes \\",
"on and on",
"# This is NOT an escaped comment due to the double backslashes \\\\",
"VAR=\tThis is not a comment",
"",
"#\\",
"\tThis is a comment",
"#\\\\",
"\tThis is no comment",
"#\\\\\\",
"\tThis is a comment",
"#\\\\\\\\",
"\tThis is no comment",
"#\\\\\\\\\\",
"\tThis is a comment",
"#\\\\\\\\\\\\",
"\tThis is no comment")
var texts []string
for _, line := range mklines.lines.Lines {
texts = append(texts, line.Text)
}
c.Check(texts, deepEquals, []string{
"# This is a comment",
"",
"# Multiline comment",
"# Another escaped comment that goes on and on",
"# This is NOT an escaped comment due to the double backslashes \\",
"VAR=\tThis is not a comment",
"",
"# This is a comment",
"#\\",
"\tThis is no comment",
"#\\ This is a comment",
"#\\\\",
"\tThis is no comment",
"#\\\\ This is a comment",
"#\\\\\\",
"\tThis is no comment"})
t.CheckOutputEmpty()
}
func (s *Suite) Test_nextLogicalLine__commented_multi(c *check.C) {
t := s.Init(c)
mklines := t.SetUpFileMkLines("filename.mk",
"#COMMENTED= \\",
"#\tcontinuation 1 \\",
"#\tcontinuation 2")
mkline := mklines.mklines[0]
// The leading comments are stripped from the continuation lines as well.
t.Check(mkline.Value(), equals, "continuation 1 \tcontinuation 2")
t.Check(mkline.VarassignComment(), equals, "")
}
func (s *Suite) Test_convertToLogicalLines__missing_newline_at_eof(c *check.C) {
t := s.Init(c)
rawText := "" +
"The package description\n" +
"takes 2 lines"
lines := convertToLogicalLines("DESCR", rawText, true)
c.Check(lines.Len(), equals, 2)
c.Check(lines.Lines[1].String(), equals, "DESCR:2: takes 2 lines")
t.CheckOutputLines(
"ERROR: DESCR:2: File must end with a newline.")
}
func (s *Suite) Test_convertToLogicalLines__missing_newline_at_eof_in_continuation_line(c *check.C) {
t := s.Init(c)
rawText := "" +
"last line\\"
lines := convertToLogicalLines("filename", rawText, true)
c.Check(lines.Len(), equals, 1)
c.Check(lines.Lines[0].String(), equals, "filename:1: last line\\")
t.CheckOutputLines(
"ERROR: filename:1: File must end with a newline.")
}
func (s *Suite) Test_convertToLogicalLines__missing_newline_at_eof_with_source(c *check.C) {
t := s.Init(c)
t.SetUpCommandLine("-Wall", "--source")
rawText := "" +
"last line\\"
lines := convertToLogicalLines("filename", rawText, true)
c.Check(lines.Len(), equals, 1)
c.Check(lines.Lines[0].String(), equals, "filename:1: last line\\")
t.CheckOutputLines(
">\tlast line\\",
"ERROR: filename:1: File must end with a newline.")
}
func (s *Suite) Test_matchContinuationLine(c *check.C) {
leadingWhitespace, text, trailingWhitespace, continuation := matchContinuationLine("\n")
c.Check(leadingWhitespace, equals, "")
c.Check(text, equals, "")
c.Check(trailingWhitespace, equals, "")
c.Check(continuation, equals, "")
leadingWhitespace, text, trailingWhitespace, continuation = matchContinuationLine("\tword \\\n")
c.Check(leadingWhitespace, equals, "\t")
c.Check(text, equals, "word")
c.Check(trailingWhitespace, equals, " ")
c.Check(continuation, equals, "\\")
}
func (s *Suite) Test_Load__errors(c *check.C) {
t := s.Init(c)
t.CreateFileLines("empty")
t.ExpectFatal(
func() { Load(t.File("does-not-exist"), MustSucceed) },
"FATAL: ~/does-not-exist: Cannot be read.")
t.ExpectFatal(
func() { Load(t.File("empty"), MustSucceed|NotEmpty) },
"FATAL: ~/empty: Must not be empty.")
}
|
