summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint/files/line_test.go
blob: 8ec338757c393ff605012554d64b05407ea4818c (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
package main

import (
	check "gopkg.in/check.v1"
)

func (s *Suite) Test_Line_modifications(c *check.C) {
	s.Init(c)
	s.UseCommandLine("--show-autofix")

	line := NewLine("fname", 1, "dummy", s.NewRawLines(1, "original\n"))

	c.Check(line.changed, equals, false)
	c.Check(line.raw, check.DeepEquals, s.NewRawLines(1, "original\n"))

	line.AutofixReplaceRegexp(`(.)(.*)(.)`, "$3$2$1")

	c.Check(line.changed, equals, true)
	c.Check(line.raw, check.DeepEquals, s.NewRawLines(1, "original\n", "lriginao\n"))

	line.changed = false
	line.AutofixReplace("i", "u")

	c.Check(line.changed, equals, true)
	c.Check(line.raw, check.DeepEquals, s.NewRawLines(1, "original\n", "lruginao\n"))
	c.Check(line.raw[0].textnl, equals, "lruginao\n")

	line.changed = false
	line.AutofixReplace("lruginao", "middle")

	c.Check(line.changed, equals, true)
	c.Check(line.raw, check.DeepEquals, s.NewRawLines(1, "original\n", "middle\n"))
	c.Check(line.raw[0].textnl, equals, "middle\n")

	line.AutofixInsertBefore("before")
	line.AutofixInsertBefore("between before and middle")
	line.AutofixInsertAfter("between middle and after")
	line.AutofixInsertAfter("after")

	c.Check(line.modifiedLines(), check.DeepEquals, []string{
		"before\n",
		"between before and middle\n",
		"middle\n",
		"between middle and after\n",
		"after\n"})

	line.AutofixDelete()

	c.Check(line.modifiedLines(), check.DeepEquals, []string{
		"before\n",
		"between before and middle\n",
		"",
		"between middle and after\n",
		"after\n"})
}

func (s *Suite) Test_Line_CheckAbsolutePathname(c *check.C) {
	line := NewLine("Makefile", 1, "# dummy", nil)

	line.CheckAbsolutePathname("bindir=/bin")
	line.CheckAbsolutePathname("bindir=/../lib")

	c.Check(s.Output(), equals, "WARN: Makefile:1: Found absolute pathname: /bin\n")
}

func (s *Suite) Test_Line_show_autofix_AutofixReplace(c *check.C) {
	s.Init(c)
	s.UseCommandLine("--show-autofix", "--source")
	line := NewLineMulti("Makefile", 27, 29, "# old", s.NewRawLines(
		27, "before\n",
		28, "The old song\n",
		29, "after\n"))

	if !line.AutofixReplace("old", "new") {
		line.Warnf("Using \"old\" is deprecated.")
	}

	c.Check(s.Output(), equals, ""+
		"\n"+
		"> before\n"+
		"- The old song\n"+
		"+ The new song\n"+
		"> after\n"+
		"WARN: Makefile:27--29: Using \"old\" is deprecated.\n"+
		"AUTOFIX: Makefile:27--29: Replacing \"old\" with \"new\".\n")
}

func (s *Suite) Test_Line_show_autofix_AutofixInsertBefore(c *check.C) {
	s.Init(c)
	s.UseCommandLine("--show-autofix", "--source")
	line := NewLine("Makefile", 30, "original", s.NewRawLines(30, "original\n"))

	if !line.AutofixInsertBefore("inserted") {
		line.Warnf("Dummy")
	}

	c.Check(s.Output(), equals, ""+
		"\n"+
		"+ inserted\n"+
		"> original\n"+
		"WARN: Makefile:30: Dummy\n"+
		"AUTOFIX: Makefile:30: Inserting a line \"inserted\" before this line.\n")
}

func (s *Suite) Test_Line_show_autofix_AutofixDelete(c *check.C) {
	s.Init(c)
	s.UseCommandLine("--show-autofix", "--source")
	line := NewLine("Makefile", 30, "to be deleted", s.NewRawLines(30, "to be deleted\n"))

	if !line.AutofixDelete() {
		line.Warnf("Dummy")
	}

	c.Check(s.Output(), equals, ""+
		"\n"+
		"- to be deleted\n"+
		"WARN: Makefile:30: Dummy\n"+
		"AUTOFIX: Makefile:30: Deleting this line.\n")
}

func (s *Suite) Test_Line_CheckTrailingWhitespace(c *check.C) {
	line := NewLine("Makefile", 32, "The line must go on   ", nil)

	line.CheckTrailingWhitespace()

	c.Check(s.Output(), equals, "NOTE: Makefile:32: Trailing white-space.\n")
}

func (s *Suite) Test_Line_CheckRcsid(c *check.C) {
	lines := s.NewLines("fname",
		"$"+"NetBSD: dummy $",
		"$"+"NetBSD$",
		"$"+"Id: dummy $",
		"$"+"Id$",
		"$"+"FreeBSD$")

	for _, line := range lines {
		line.CheckRcsid(``, "")
	}

	c.Check(s.Output(), equals, ""+
		"ERROR: fname:3: Expected \"$"+"NetBSD$\".\n"+
		"ERROR: fname:4: Expected \"$"+"NetBSD$\".\n"+
		"ERROR: fname:5: Expected \"$"+"NetBSD$\".\n")
}