1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
|
package pkglint
import "gopkg.in/check.v1"
func (s *Suite) Test_VarTypeRegistry_compilerLanguages(c *check.C) {
t := s.Init(c)
G.Testing = false // Just for code coverage
t.CreateFileLines("mk/compiler.mk",
MkCvsID,
"",
"_CXX_STD_VERSIONS= gnu++14",
".for _version_ in ${_CXX_STD_VERSIONS}",
". if !empty(USE_LANGUAGES:M${_version_})",
"USE_LANGUAGES+= c++",
". endif",
".endfor",
"",
".if ${USE_LANGUAGES:Mexpr-lang} || !empty(USE_LANGUAGES:Mempty-lang)",
".endif",
"",
// Just for code coverage
".if ${OTHER} || ${USE_LANGUAGES} \\",
" || ${USE_LANGUAGES:O} || ${USE_LANGUAGES:Mc++-*}",
".endif")
reg := NewVarTypeRegistry()
compilerLanguages := reg.compilerLanguages(&G.Pkgsrc)
enumValues := compilerLanguages.AllowedEnums()
t.CheckEquals(enumValues, "empty-lang expr-lang gnu++14")
}
func (s *Suite) Test_VarTypeRegistry_enumFrom(c *check.C) {
t := s.Init(c)
t.CreateFileLines("editors/emacs/modules.mk",
MkCvsID,
"",
"_EMACS_VERSIONS_ALL= emacs31",
"_EMACS_VERSIONS_ALL+= emacs29")
t.CreateFileLines("mk/java-vm.mk",
MkCvsID,
"",
"_PKG_JVMS.8= openjdk8 oracle-jdk8",
"_PKG_JVMS.7= ${_PKG_JVMS.8} openjdk7 sun-jdk7",
"_PKG_JVMS.6= ${_PKG_JVMS.7} jdk16")
t.CreateFileLines("mk/compiler.mk",
MkCvsID,
"",
"_COMPILERS= gcc ido mipspro-ucode \\",
" sunpro",
"_PSEUDO_COMPILERS= ccache distcc f2c g95",
"",
"_CXX_STD_VERSIONS= gnu++14 c++14 gnu++11 c++11 gnu++0x c++0x gnu++03 c++03",
".for _version_ in ${_CXX_STD_VERSIONS}",
". if !empty(USE_LANGUAGES:M${_version_})",
"USE_LANGUAGES+= c++",
". endif",
".endfor",
"",
".if ${USE_LANGUAGES:Mexpr-lang} || !empty(USE_LANGUAGES:Mempty-lang)",
".endif")
t.SetUpVartypes()
test := func(varname, values string) {
vartype := G.Pkgsrc.VariableType(nil, varname).String()
t.CheckEquals(vartype, values)
}
test("EMACS_VERSIONS_ACCEPTED", "enum: emacs29 emacs31 (list, package-settable)")
test("PKG_JVM", "enum: jdk16 openjdk7 openjdk8 oracle-jdk8 sun-jdk7 (system-provided)")
test("USE_LANGUAGES", "enum: c++03 c++0x c++11 c++14 empty-lang expr-lang "+
"gnu++03 gnu++0x gnu++11 gnu++14 (list, package-settable)")
test("PKGSRC_COMPILER", "enum: ccache distcc f2c g95 gcc ido mipspro-ucode sunpro (list, user-settable)")
}
func (s *Suite) Test_VarTypeRegistry_enumFrom__no_tracing(c *check.C) {
t := s.Init(c)
t.CreateFileLines("mk/existing.mk",
MkCvsID,
"VAR=\tfirst second")
reg := NewVarTypeRegistry()
t.DisableTracing()
existingType := reg.enumFrom(&G.Pkgsrc, "mk/existing.mk", "defval", "VAR")
noAssignmentsType := reg.enumFrom(&G.Pkgsrc, "mk/existing.mk", "defval", "OTHER_VAR")
nonexistentType := reg.enumFrom(&G.Pkgsrc, "mk/nonexistent.mk", "defval", "VAR")
t.CheckEquals(existingType.AllowedEnums(), "first second")
t.CheckEquals(noAssignmentsType.AllowedEnums(), "defval")
t.CheckEquals(nonexistentType.AllowedEnums(), "defval")
}
func (s *Suite) Test_VarTypeRegistry_enumFromDirs(c *check.C) {
t := s.Init(c)
// To make the test useful, these directories must differ from the
// PYPKGPREFIX default value in vardefs.go.
t.CreateFileLines("lang/python28/Makefile", MkCvsID)
t.CreateFileLines("lang/python33/Makefile", MkCvsID)
t.SetUpVartypes()
test := func(varname, values string) {
vartype := G.Pkgsrc.VariableType(nil, varname).String()
t.CheckEquals(vartype, values)
}
test("PYPKGPREFIX", "enum: py28 py33 (system-provided)")
}
func (s *Suite) Test_VarTypeRegistry_enumFromFiles(c *check.C) {
t := s.Init(c)
t.CreateFileLines("mk/platform/NetBSD.mk")
t.CreateFileLines("mk/platform/README")
t.CreateFileLines("mk/platform/SunOS.mk")
t.CreateFileLines("mk/platform/SunOS.mk~")
t.SetUpVartypes()
test := func(varname, values string) {
vartype := G.Pkgsrc.VariableType(nil, varname).String()
t.CheckEquals(vartype, values)
}
test("OPSYS", "enum: NetBSD SunOS (system-provided)")
}
func (s *Suite) Test_VarTypeRegistry_Init(c *check.C) {
t := s.Init(c)
src := NewPkgsrc(t.File("."))
src.vartypes.Init(&src)
t.CheckEquals(src.vartypes.Canon("BSD_MAKE_ENV").basicType.name, "ShellWord")
t.CheckEquals(src.vartypes.Canon("USE_BUILTIN.*").basicType.name, "YesNoIndirectly")
}
func (s *Suite) Test_VarTypeRegistry_Init__LP64PLATFORMS(c *check.C) {
t := s.Init(c)
pkg := t.SetUpPackage("category/package",
"BROKEN_ON_PLATFORM=\t${LP64PLATFORMS}")
t.FinishSetUp()
G.Check(pkg)
// No warning about a missing :Q modifier.
t.CheckOutputLines(
"WARN: ~/category/package/Makefile:20: " +
"Setting variable BROKEN_ON_PLATFORM should have a rationale.")
}
func (s *Suite) Test_VarTypeRegistry_Init__no_tracing(c *check.C) {
t := s.Init(c)
t.CreateFileLines("editors/emacs/modules.mk",
MkCvsID,
"",
"_EMACS_VERSIONS_ALL= emacs31",
"_EMACS_VERSIONS_ALL+= emacs29")
t.DisableTracing()
t.SetUpVartypes() // Just for code coverage.
t.CheckOutputEmpty()
}
func (s *Suite) Test_VarTypeRegistry_Init__no_testing(c *check.C) {
t := s.Init(c)
t.SetUpPackage("category/package")
t.Remove("mk/fetch/sites.mk")
G.Testing = false
t.ExpectFatal(
t.FinishSetUp,
"FATAL: ~/editors/emacs/modules.mk: Cannot be read.")
}
func (s *Suite) Test_VarTypeRegistry_Init__MASTER_SITES(c *check.C) {
t := s.Init(c)
t.CreateFileLines("mk/fetch/sites.mk",
MkCvsID,
"",
"MASTER_SITE_GITHUB=\thttps://github.com/",
"",
"OTHER=\tvalue") // For branch coverage of hasPrefix.*MASTER_SITE_
t.SetUpVartypes()
vartype := G.Pkgsrc.VariableType(nil, "MASTER_SITE_GITHUB")
t.CheckEquals(vartype.String(), "FetchURL (list, system-provided)")
}
func (s *Suite) Test_VarTypeRegistry_parseACLEntries__invalid_arguments(c *check.C) {
t := s.Init(c)
reg := NewVarTypeRegistry()
parseACLEntries := reg.parseACLEntries
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "buildlink3.mk: *", "*: *") },
"Pkglint internal error: "+
"Invalid ACL permission \"*\" for \"VARNAME\" in \"buildlink3.mk\". "+
"Remaining parts are \"*\". "+
"Valid permissions are default, set, append, use, use-loadtime (in this order), or none.")
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "buildlink3.mk: use", "*: use") },
"Pkglint internal error: Repeated permissions \"use\" for \"VARNAME\".")
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "*.txt: use") },
"Pkglint internal error: Invalid ACL glob \"*.txt\" for \"VARNAME\".")
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "*.mk: use", "buildlink3.mk: append") },
"Pkglint internal error: Unreachable ACL pattern \"buildlink3.mk\" for \"VARNAME\".")
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "no colon") },
"Pkglint internal error: ACL entry \"no colon\" must have exactly 1 colon.")
t.ExpectPanic(
func() { parseACLEntries("VARNAME", "too: many: colons") },
"Pkglint internal error: ACL entry \"too: many: colons\" must have exactly 1 colon.")
t.ExpectAssert(func() { parseACLEntries("VAR") })
}
|
