diff options
author | Rob Pike <r@golang.org> | 2008-12-16 13:01:39 -0800 |
---|---|---|
committer | Rob Pike <r@golang.org> | 2008-12-16 13:01:39 -0800 |
commit | 202db70ccb3160957945a82c1e3c174a57e888db (patch) | |
tree | 6c3ea39f93c67c0a292b294c728066771b55cd64 /src/lib/io/bytebuffer.go | |
parent | 8188c6825515a5de35222ebe8b5bf15db99b301a (diff) | |
download | golang-202db70ccb3160957945a82c1e3c174a57e888db.tar.gz |
If ByteBuffer has never been used, b.buf is nil but Data() should still work.
Fix the bug using a (safe) shared global empty array.
R=rsc
DELTA=8 (8 added, 0 deleted, 0 changed)
OCL=21303
CL=21303
Diffstat (limited to 'src/lib/io/bytebuffer.go')
-rw-r--r-- | src/lib/io/bytebuffer.go | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/lib/io/bytebuffer.go b/src/lib/io/bytebuffer.go index 903536717..8af8a09aa 100644 --- a/src/lib/io/bytebuffer.go +++ b/src/lib/io/bytebuffer.go @@ -75,7 +75,15 @@ func (b *ByteBuffer) Len() int { return b.len } +// If the buffer is empty, Data() should still give a valid array. +// Use this variable as a surrogate. It's immutable (can't be +// grown, can't store any data) so it's safe to share. +var EmptyByteArray = new([]byte, 0) + func (b *ByteBuffer) Data() *[]byte { + if b.buf == nil { + return EmptyByteArray + } return b.buf[b.off:b.len] } |