summaryrefslogtreecommitdiff
path: root/spec/unit/pops/factory_spec.rb
AgeCommit message (Collapse)AuthorFilesLines
2013-12-05(maint) Remove unused cruft from pops modelHenrik Lindberg1-23/+0
This removes unused code from the pops model and related factory methods. Also removes some stale comments and commented out code.
2013-12-05(#22363) Refactor model of literalsHenrik Lindberg1-6/+6
There were several problems with the model of literals: * LiteralNumber had radix which is not applicable for floats * All LiteralValue used an inherited Object attribute which makes it difficult/impossible to correctly serialize literal values. The refactoring moves the value attribute to each subclass, adds LiteralInteger (with radix), and LiteralFloat as subclasses of LiteralNumber. LiteralRegexp required special handling since a regular expression must be serialized as a String. Now LiteralRegularExpression has two attributes 'pattern' (string), and 'value' (regexp). Setting either changes the other. When serialized, only the pattern is serialized (and the regexp value is reconstructed on de-serialization).
2013-04-05(Maint) Remove API and Impl distinctionsAndrew Parker1-0/+329
The API and Impl modules were an interesting idea that has just been leading to confusion about where things live. Moving forward the public vs. private distinction for API purposes should be handled with @api annotations in documentation and clear responsibilities of classes and modules.