1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
|
require 'spec_helper'
require 'puppet/file_system'
require 'puppet/module_tool/applications'
require 'puppet_spec/modules'
describe Puppet::ModuleTool::Applications::Builder do
include PuppetSpec::Files
let(:path) { tmpdir("working_dir") }
let(:module_name) { 'mymodule-mytarball' }
let(:version) { '0.0.1' }
let(:release_name) { "#{module_name}-#{version}" }
let(:tarball) { File.join(path, 'pkg', release_name) + ".tar.gz" }
let(:builder) { Puppet::ModuleTool::Applications::Builder.new(path) }
shared_examples "a packagable module" do
def target_exists?(file)
File.exist?(File.join(path, "pkg", "#{module_name}-#{version}", file))
end
def build
tarrer = mock('tarrer')
Puppet::ModuleTool::Tar.expects(:instance).returns(tarrer)
Dir.expects(:chdir).with(File.join(path, 'pkg')).yields
tarrer.expects(:pack).with(release_name, tarball)
builder.run
end
def create_regular_files
Puppet::FileSystem.touch(File.join(path, '.dotfile'))
Puppet::FileSystem.touch(File.join(path, 'file.foo'))
Puppet::FileSystem.touch(File.join(path, 'REVISION'))
Puppet::FileSystem.touch(File.join(path, '~file'))
Puppet::FileSystem.touch(File.join(path, '#file'))
Puppet::FileSystem.mkpath(File.join(path, 'pkg'))
Puppet::FileSystem.mkpath(File.join(path, 'coverage'))
Puppet::FileSystem.mkpath(File.join(path, 'sub'))
Puppet::FileSystem.touch(File.join(path, 'sub/.dotfile'))
Puppet::FileSystem.touch(File.join(path, 'sub/file.foo'))
Puppet::FileSystem.touch(File.join(path, 'sub/REVISION'))
Puppet::FileSystem.touch(File.join(path, 'sub/~file'))
Puppet::FileSystem.touch(File.join(path, 'sub/#file'))
Puppet::FileSystem.mkpath(File.join(path, 'sub/pkg'))
Puppet::FileSystem.mkpath(File.join(path, 'sub/coverage'))
end
def create_symlinks
Puppet::FileSystem.touch(File.join(path, 'symlinkedfile'))
Puppet::FileSystem.symlink(File.join(path, 'symlinkedfile'), File.join(path, 'symlinkfile'))
end
def create_ignored_files
Puppet::FileSystem.touch(File.join(path, 'gitignored.foo'))
Puppet::FileSystem.mkpath(File.join(path, 'gitdirectory/sub'))
Puppet::FileSystem.touch(File.join(path, 'gitdirectory/gitartifact'))
Puppet::FileSystem.touch(File.join(path, 'gitdirectory/gitimportantfile'))
Puppet::FileSystem.touch(File.join(path, 'gitdirectory/sub/artifact'))
Puppet::FileSystem.touch(File.join(path, 'pmtignored.foo'))
Puppet::FileSystem.mkpath(File.join(path, 'pmtdirectory/sub'))
Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/pmtimportantfile'))
Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/pmtartifact'))
Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/sub/artifact'))
end
def create_pmtignore_file
Puppet::FileSystem.open(File.join(path, '.pmtignore'), 0600, 'w') do |f|
f << <<-PMTIGNORE
pmtignored.*
pmtdirectory/sub/**
pmtdirectory/pmt*
!pmtimportantfile
PMTIGNORE
end
end
def create_gitignore_file
Puppet::FileSystem.open(File.join(path, '.gitignore'), 0600, 'w') do |f|
f << <<-GITIGNORE
gitignored.*
gitdirectory/sub/**
gitdirectory/git*
!gitimportantfile
GITIGNORE
end
end
def create_symlink_gitignore_file
Puppet::FileSystem.open(File.join(path, '.gitignore'), 0600, 'w') do |f|
f << <<-GITIGNORE
symlinkfile
GITIGNORE
end
end
shared_examples "regular files are present" do
it "has metadata" do
expect(target_exists?('metadata.json')).to eq true
end
it "has checksums" do
expect(target_exists?('checksums.json')).to eq true
end
it "copies regular files" do
expect(target_exists?('file.foo')).to eq true
end
end
shared_examples "default artifacts are removed in module dir but not in subdirs" do
it "ignores dotfiles" do
expect(target_exists?('.dotfile')).to eq false
expect(target_exists?('sub/.dotfile')).to eq true
end
it "does not have .gitignore" do
expect(target_exists?('.gitignore')).to eq false
end
it "does not have .pmtignore" do
expect(target_exists?('.pmtignore')).to eq false
end
it "does not have pkg" do
expect(target_exists?('pkg')).to eq false
expect(target_exists?('sub/pkg')).to eq true
end
it "does not have coverage" do
expect(target_exists?('coverage')).to eq false
expect(target_exists?('sub/coverage')).to eq true
end
it "does not have REVISION" do
expect(target_exists?('REVISION')).to eq false
expect(target_exists?('sub/REVISION')).to eq true
end
it "does not have ~files" do
expect(target_exists?('~file')).to eq false
expect(target_exists?('sub/~file')).to eq true
end
it "does not have #files" do
expect(target_exists?('#file')).to eq false
expect(target_exists?('sub/#file')).to eq true
end
end
shared_examples "gitignored files are present" do
it "leaves regular files" do
expect(target_exists?('gitignored.foo')).to eq true
end
it "leaves directories" do
expect(target_exists?('gitdirectory')).to eq true
end
it "leaves files in directories" do
expect(target_exists?('gitdirectory/gitartifact')).to eq true
end
it "leaves exceptional files" do
expect(target_exists?('gitdirectory/gitimportantfile')).to eq true
end
it "leaves subdirectories" do
expect(target_exists?('gitdirectory/sub')).to eq true
end
it "leaves files in subdirectories" do
expect(target_exists?('gitdirectory/sub/artifact')).to eq true
end
end
shared_examples "gitignored files are not present" do
it "ignores regular files" do
expect(target_exists?('gitignored.foo')).to eq false
end
it "ignores directories" do
expect(target_exists?('gitdirectory')).to eq true
end
it "ignores files in directories" do
expect(target_exists?('gitdirectory/gitartifact')).to eq false
end
it "copies exceptional files" do
expect(target_exists?('gitdirectory/gitimportantfile')).to eq true
end
it "ignores subdirectories" do
expect(target_exists?('gitdirectory/sub')).to eq false
end
it "ignores files in subdirectories" do
expect(target_exists?('gitdirectory/sub/artifact')).to eq false
end
end
shared_examples "pmtignored files are present" do
it "leaves regular files" do
expect(target_exists?('pmtignored.foo')).to eq true
end
it "leaves directories" do
expect(target_exists?('pmtdirectory')).to eq true
end
it "ignores files in directories" do
expect(target_exists?('pmtdirectory/pmtartifact')).to eq true
end
it "leaves exceptional files" do
expect(target_exists?('pmtdirectory/pmtimportantfile')).to eq true
end
it "leaves subdirectories" do
expect(target_exists?('pmtdirectory/sub')).to eq true
end
it "leaves files in subdirectories" do
expect(target_exists?('pmtdirectory/sub/artifact')).to eq true
end
end
shared_examples "pmtignored files are not present" do
it "ignores regular files" do
expect(target_exists?('pmtignored.foo')).to eq false
end
it "ignores directories" do
expect(target_exists?('pmtdirectory')).to eq true
end
it "copies exceptional files" do
expect(target_exists?('pmtdirectory/pmtimportantfile')).to eq true
end
it "ignores files in directories" do
expect(target_exists?('pmtdirectory/pmtartifact')).to eq false
end
it "ignores subdirectories" do
expect(target_exists?('pmtdirectory/sub')).to eq false
end
it "ignores files in subdirectories" do
expect(target_exists?('pmtdirectory/sub/artifact')).to eq false
end
end
context "with no ignore files" do
before :each do
create_regular_files
create_ignored_files
build
end
it_behaves_like "regular files are present"
it_behaves_like "default artifacts are removed in module dir but not in subdirs"
it_behaves_like "pmtignored files are present"
it_behaves_like "gitignored files are present"
end
context "with .gitignore file" do
before :each do
create_regular_files
create_ignored_files
create_gitignore_file
build
end
it_behaves_like "regular files are present"
it_behaves_like "default artifacts are removed in module dir but not in subdirs"
it_behaves_like "pmtignored files are present"
it_behaves_like "gitignored files are not present"
end
context "with .pmtignore file" do
before :each do
create_regular_files
create_ignored_files
create_pmtignore_file
build
end
it_behaves_like "regular files are present"
it_behaves_like "default artifacts are removed in module dir but not in subdirs"
it_behaves_like "gitignored files are present"
it_behaves_like "pmtignored files are not present"
end
context "with .pmtignore and .gitignore file" do
before :each do
create_regular_files
create_ignored_files
create_pmtignore_file
create_gitignore_file
build
end
it_behaves_like "regular files are present"
it_behaves_like "default artifacts are removed in module dir but not in subdirs"
it_behaves_like "gitignored files are present"
it_behaves_like "pmtignored files are not present"
end
context "with unignored symlinks", :if => Puppet.features.manages_symlinks? do
before :each do
create_regular_files
create_symlinks
create_ignored_files
end
it "give an error about symlinks" do
expect { builder.run }.to raise_error
end
end
context "with .gitignore file and ignored symlinks", :if => Puppet.features.manages_symlinks? do
before :each do
create_regular_files
create_symlinks
create_ignored_files
create_symlink_gitignore_file
end
it "does not give an error about symlinks" do
expect { build }.not_to raise_error
end
end
end
context 'with metadata.json' do
before :each do
File.open(File.join(path, 'metadata.json'), 'w') do |f|
f.puts({
"name" => "#{module_name}",
"version" => "#{version}",
"source" => "http://github.com/testing/#{module_name}",
"author" => "testing",
"license" => "Apache License Version 2.0",
"summary" => "Puppet testing module",
"description" => "This module can be used for basic testing",
"project_page" => "http://github.com/testing/#{module_name}"
}.to_json)
end
end
it_behaves_like "a packagable module"
it "does not package with a symlink", :if => Puppet.features.manages_symlinks? do
FileUtils.touch(File.join(path, 'tempfile'))
Puppet::FileSystem.symlink(File.join(path, 'tempfile'), File.join(path, 'tempfile2'))
expect {
builder.run
}.to raise_error Puppet::ModuleTool::Errors::ModuleToolError, /symlinks/i
end
it "does not package with a symlink in a subdir", :if => Puppet.features.manages_symlinks? do
FileUtils.mkdir(File.join(path, 'manifests'))
FileUtils.touch(File.join(path, 'manifests/tempfile.pp'))
Puppet::FileSystem.symlink(File.join(path, 'manifests/tempfile.pp'), File.join(path, 'manifests/tempfile2.pp'))
expect {
builder.run
}.to raise_error Puppet::ModuleTool::Errors::ModuleToolError, /symlinks/i
end
end
context 'with metadata.json containing checksums' do
before :each do
File.open(File.join(path, 'metadata.json'), 'w') do |f|
f.puts({
"name" => "#{module_name}",
"version" => "#{version}",
"source" => "http://github.com/testing/#{module_name}",
"author" => "testing",
"license" => "Apache License Version 2.0",
"summary" => "Puppet testing module",
"description" => "This module can be used for basic testing",
"project_page" => "http://github.com/testing/#{module_name}",
"checksums" => {"README.md" => "deadbeef"}
}.to_json)
end
end
it_behaves_like "a packagable module"
end
context 'with Modulefile' do
before :each do
File.open(File.join(path, 'Modulefile'), 'w') do |f|
f.write <<-MODULEFILE
name '#{module_name}'
version '#{version}'
source 'http://github.com/testing/#{module_name}'
author 'testing'
license 'Apache License Version 2.0'
summary 'Puppet testing module'
description 'This module can be used for basic testing'
project_page 'http://github.com/testing/#{module_name}'
MODULEFILE
end
end
it_behaves_like "a packagable module"
end
end
|