1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
|
#! /usr/bin/env ruby
# encoding: ASCII-8BIT
require 'spec_helper'
require 'puppet/ssl/certificate_authority'
describe Puppet::SSL::CertificateAuthority do
after do
Puppet::SSL::CertificateAuthority.instance_variable_set(:@singleton_instance, nil)
end
def stub_ca_host
@key = mock 'key'
@key.stubs(:content).returns "cakey"
@cacert = mock 'certificate'
@cacert.stubs(:content).returns "cacertificate"
@host = stub 'ssl_host', :key => @key, :certificate => @cacert, :name => Puppet::SSL::Host.ca_name
end
it "should have a class method for returning a singleton instance" do
Puppet::SSL::CertificateAuthority.should respond_to(:instance)
end
describe "when finding an existing instance" do
describe "and the host is a CA host and the run_mode is master" do
before do
Puppet[:ca] = true
Puppet.run_mode.stubs(:master?).returns true
@ca = mock('ca')
Puppet::SSL::CertificateAuthority.stubs(:new).returns @ca
end
it "should return an instance" do
Puppet::SSL::CertificateAuthority.instance.should equal(@ca)
end
it "should always return the same instance" do
Puppet::SSL::CertificateAuthority.instance.should equal(Puppet::SSL::CertificateAuthority.instance)
end
end
describe "and the host is not a CA host" do
it "should return nil" do
Puppet[:ca] = false
Puppet.run_mode.stubs(:master?).returns true
ca = mock('ca')
Puppet::SSL::CertificateAuthority.expects(:new).never
Puppet::SSL::CertificateAuthority.instance.should be_nil
end
end
describe "and the run_mode is not master" do
it "should return nil" do
Puppet[:ca] = true
Puppet.run_mode.stubs(:master?).returns false
ca = mock('ca')
Puppet::SSL::CertificateAuthority.expects(:new).never
Puppet::SSL::CertificateAuthority.instance.should be_nil
end
end
end
describe "when initializing" do
before do
Puppet.settings.stubs(:use)
Puppet::SSL::CertificateAuthority.any_instance.stubs(:setup)
end
it "should always set its name to the value of :certname" do
Puppet[:certname] = "ca_testing"
Puppet::SSL::CertificateAuthority.new.name.should == "ca_testing"
end
it "should create an SSL::Host instance whose name is the 'ca_name'" do
Puppet::SSL::Host.expects(:ca_name).returns "caname"
host = stub 'host'
Puppet::SSL::Host.expects(:new).with("caname").returns host
Puppet::SSL::CertificateAuthority.new
end
it "should use the :main, :ca, and :ssl settings sections" do
Puppet.settings.expects(:use).with(:main, :ssl, :ca)
Puppet::SSL::CertificateAuthority.new
end
it "should make sure the CA is set up" do
Puppet::SSL::CertificateAuthority.any_instance.expects(:setup)
Puppet::SSL::CertificateAuthority.new
end
end
describe "when setting itself up" do
it "should generate the CA certificate if it does not have one" do
Puppet.settings.stubs :use
host = stub 'host'
Puppet::SSL::Host.stubs(:new).returns host
host.expects(:certificate).returns nil
Puppet::SSL::CertificateAuthority.any_instance.expects(:generate_ca_certificate)
Puppet::SSL::CertificateAuthority.new
end
end
describe "when retrieving the certificate revocation list" do
before do
Puppet.settings.stubs(:use)
Puppet[:cacrl] = "/my/crl"
cert = stub("certificate", :content => "real_cert")
key = stub("key", :content => "real_key")
@host = stub 'host', :certificate => cert, :name => "hostname", :key => key
Puppet::SSL::CertificateAuthority.any_instance.stubs(:setup)
@ca = Puppet::SSL::CertificateAuthority.new
@ca.stubs(:host).returns @host
end
it "should return any found CRL instance" do
crl = mock 'crl'
Puppet::SSL::CertificateRevocationList.indirection.expects(:find).returns crl
@ca.crl.should equal(crl)
end
it "should create, generate, and save a new CRL instance of no CRL can be found" do
crl = Puppet::SSL::CertificateRevocationList.new("fakename")
Puppet::SSL::CertificateRevocationList.indirection.expects(:find).returns nil
Puppet::SSL::CertificateRevocationList.expects(:new).returns crl
crl.expects(:generate).with(@ca.host.certificate.content, @ca.host.key.content)
Puppet::SSL::CertificateRevocationList.indirection.expects(:save).with(crl)
@ca.crl.should equal(crl)
end
end
describe "when generating a self-signed CA certificate" do
before do
Puppet.settings.stubs(:use)
Puppet::SSL::CertificateAuthority.any_instance.stubs(:setup)
Puppet::SSL::CertificateAuthority.any_instance.stubs(:crl)
@ca = Puppet::SSL::CertificateAuthority.new
@host = stub 'host', :key => mock("key"), :name => "hostname", :certificate => mock('certificate')
Puppet::SSL::CertificateRequest.any_instance.stubs(:generate)
@ca.stubs(:host).returns @host
end
it "should create and store a password at :capass" do
Puppet[:capass] = File.expand_path("/path/to/pass")
Puppet::FileSystem.expects(:exist?).with(Puppet[:capass]).returns false
fh = StringIO.new
Puppet.settings.setting(:capass).expects(:open).with('w').yields fh
@ca.stubs(:sign)
@ca.generate_ca_certificate
expect(fh.string.length).to be > 18
end
it "should generate a key if one does not exist" do
@ca.stubs :generate_password
@ca.stubs :sign
@ca.host.expects(:key).returns nil
@ca.host.expects(:generate_key)
@ca.generate_ca_certificate
end
it "should create and sign a self-signed cert using the CA name" do
request = mock 'request'
Puppet::SSL::CertificateRequest.expects(:new).with(@ca.host.name).returns request
request.expects(:generate).with(@ca.host.key)
request.stubs(:request_extensions => [])
@ca.expects(:sign).with(@host.name, false, request)
@ca.stubs :generate_password
@ca.generate_ca_certificate
end
it "should generate its CRL" do
@ca.stubs :generate_password
@ca.stubs :sign
@ca.host.expects(:key).returns nil
@ca.host.expects(:generate_key)
@ca.expects(:crl)
@ca.generate_ca_certificate
end
end
describe "when signing" do
before do
Puppet.settings.stubs(:use)
Puppet::SSL::CertificateAuthority.any_instance.stubs(:password?).returns true
stub_ca_host
Puppet::SSL::Host.expects(:new).with(Puppet::SSL::Host.ca_name).returns @host
@ca = Puppet::SSL::CertificateAuthority.new
@name = "myhost"
@real_cert = stub 'realcert', :sign => nil
@cert = Puppet::SSL::Certificate.new(@name)
@cert.content = @real_cert
Puppet::SSL::Certificate.stubs(:new).returns @cert
Puppet::SSL::Certificate.indirection.stubs(:save)
# Stub out the factory
Puppet::SSL::CertificateFactory.stubs(:build).returns @cert.content
@request_content = stub "request content stub", :subject => OpenSSL::X509::Name.new([['CN', @name]]), :public_key => stub('public_key')
@request = stub 'request', :name => @name, :request_extensions => [], :subject_alt_names => [], :content => @request_content
@request_content.stubs(:verify).returns(true)
# And the inventory
@inventory = stub 'inventory', :add => nil
@ca.stubs(:inventory).returns @inventory
Puppet::SSL::CertificateRequest.indirection.stubs(:destroy)
end
describe "its own certificate" do
before do
@serial = 10
@ca.stubs(:next_serial).returns @serial
end
it "should not look up a certificate request for the host" do
Puppet::SSL::CertificateRequest.indirection.expects(:find).never
@ca.sign(@name, true, @request)
end
it "should use a certificate type of :ca" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[0].should == :ca
end.returns @cert.content
@ca.sign(@name, :ca, @request)
end
it "should pass the provided CSR as the CSR" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[1].should == @request
end.returns @cert.content
@ca.sign(@name, :ca, @request)
end
it "should use the provided CSR's content as the issuer" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[2].subject.to_s.should == "/CN=myhost"
end.returns @cert.content
@ca.sign(@name, :ca, @request)
end
it "should pass the next serial as the serial number" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[3].should == @serial
end.returns @cert.content
@ca.sign(@name, :ca, @request)
end
it "should sign the certificate request even if it contains alt names" do
@request.stubs(:subject_alt_names).returns %w[DNS:foo DNS:bar DNS:baz]
expect do
@ca.sign(@name, false, @request)
end.not_to raise_error
end
it "should save the resulting certificate" do
Puppet::SSL::Certificate.indirection.expects(:save).with(@cert)
@ca.sign(@name, :ca, @request)
end
end
describe "another host's certificate" do
before do
@serial = 10
@ca.stubs(:next_serial).returns @serial
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with(@name).returns @request
Puppet::SSL::CertificateRequest.indirection.stubs :save
end
it "should use a certificate type of :server" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[0] == :server
end.returns @cert.content
@ca.sign(@name)
end
it "should use look up a CSR for the host in the :ca_file terminus" do
Puppet::SSL::CertificateRequest.indirection.expects(:find).with(@name).returns @request
@ca.sign(@name)
end
it "should fail if no CSR can be found for the host" do
Puppet::SSL::CertificateRequest.indirection.expects(:find).with(@name).returns nil
expect { @ca.sign(@name) }.to raise_error(ArgumentError)
end
it "should fail if an unknown request extension is present" do
@request.stubs :request_extensions => [{ "oid" => "bananas",
"value" => "delicious" }]
expect {
@ca.sign(@name)
}.to raise_error(/CSR has request extensions that are not permitted/)
end
it "should fail if the CSR contains alt names and they are not expected" do
@request.stubs(:subject_alt_names).returns %w[DNS:foo DNS:bar DNS:baz]
expect do
@ca.sign(@name, false)
end.to raise_error(Puppet::SSL::CertificateAuthority::CertificateSigningError, /CSR '#{@name}' contains subject alternative names \(.*?\), which are disallowed. Use `puppet cert --allow-dns-alt-names sign #{@name}` to sign this request./)
end
it "should not fail if the CSR does not contain alt names and they are expected" do
@request.stubs(:subject_alt_names).returns []
expect { @ca.sign(@name, true) }.to_not raise_error
end
it "should reject alt names by default" do
@request.stubs(:subject_alt_names).returns %w[DNS:foo DNS:bar DNS:baz]
expect do
@ca.sign(@name)
end.to raise_error(Puppet::SSL::CertificateAuthority::CertificateSigningError, /CSR '#{@name}' contains subject alternative names \(.*?\), which are disallowed. Use `puppet cert --allow-dns-alt-names sign #{@name}` to sign this request./)
end
it "should use the CA certificate as the issuer" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[2] == @cacert.content
end.returns @cert.content
signed = @ca.sign(@name)
end
it "should pass the next serial as the serial number" do
Puppet::SSL::CertificateFactory.expects(:build).with do |*args|
args[3] == @serial
end.returns @cert.content
@ca.sign(@name)
end
it "should sign the resulting certificate using its real key and a digest" do
digest = mock 'digest'
OpenSSL::Digest::SHA256.expects(:new).returns digest
key = stub 'key', :content => "real_key"
@ca.host.stubs(:key).returns key
@cert.content.expects(:sign).with("real_key", digest)
@ca.sign(@name)
end
it "should save the resulting certificate" do
Puppet::SSL::Certificate.indirection.stubs(:save).with(@cert)
@ca.sign(@name)
end
it "should remove the host's certificate request" do
Puppet::SSL::CertificateRequest.indirection.expects(:destroy).with(@name)
@ca.sign(@name)
end
it "should check the internal signing policies" do
@ca.expects(:check_internal_signing_policies).returns true
@ca.sign(@name)
end
end
context "#check_internal_signing_policies" do
before do
@serial = 10
@ca.stubs(:next_serial).returns @serial
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with(@name).returns @request
@cert.stubs :save
end
it "should reject CSRs whose CN doesn't match the name for which we're signing them" do
# Shorten this so the test doesn't take too long
Puppet[:keylength] = 1024
key = Puppet::SSL::Key.new('the_certname')
key.generate
csr = Puppet::SSL::CertificateRequest.new('the_certname')
csr.generate(key)
expect do
@ca.check_internal_signing_policies('not_the_certname', csr, false)
end.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/common name "the_certname" does not match expected certname "not_the_certname"/
)
end
describe "when validating the CN" do
before :all do
Puppet[:keylength] = 1024
Puppet[:passfile] = '/f00'
@signing_key = Puppet::SSL::Key.new('my_signing_key')
@signing_key.generate
end
[
'completely_okay',
'sure, why not? :)',
'so+many(things)-are=allowed.',
'this"is#just&madness%you[see]',
'and even a (an?) \\!',
'waltz, nymph, for quick jigs vex bud.',
'{552c04ca-bb1b-11e1-874b-60334b04494e}'
].each do |name|
it "should accept #{name.inspect}" do
csr = Puppet::SSL::CertificateRequest.new(name)
csr.generate(@signing_key)
@ca.check_internal_signing_policies(name, csr, false)
end
end
[
'super/bad',
"not\neven\tkind\rof",
"ding\adong\a",
"hidden\b\b\b\b\b\bmessage",
"\xE2\x98\x83 :("
].each do |name|
it "should reject #{name.inspect}" do
# We aren't even allowed to make objects with these names, so let's
# stub that to simulate an invalid one coming from outside Puppet
Puppet::SSL::CertificateRequest.stubs(:validate_certname)
csr = Puppet::SSL::CertificateRequest.new(name)
csr.generate(@signing_key)
expect do
@ca.check_internal_signing_policies(name, csr, false)
end.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/subject contains unprintable or non-ASCII characters/
)
end
end
end
it "accepts numeric OIDs under the ppRegCertExt subtree" do
exts = [{ 'oid' => '1.3.6.1.4.1.34380.1.1.1',
'value' => '657e4780-4cf5-11e3-8f96-0800200c9a66'}]
@request.stubs(:request_extensions).returns exts
expect {
@ca.check_internal_signing_policies(@name, @request, false)
}.to_not raise_error
end
it "accepts short name OIDs under the ppRegCertExt subtree" do
exts = [{ 'oid' => 'pp_uuid',
'value' => '657e4780-4cf5-11e3-8f96-0800200c9a66'}]
@request.stubs(:request_extensions).returns exts
expect {
@ca.check_internal_signing_policies(@name, @request, false)
}.to_not raise_error
end
it "accepts OIDs under the ppPrivCertAttrs subtree" do
exts = [{ 'oid' => '1.3.6.1.4.1.34380.1.2.1',
'value' => 'private extension'}]
@request.stubs(:request_extensions).returns exts
expect {
@ca.check_internal_signing_policies(@name, @request, false)
}.to_not raise_error
end
it "should reject a critical extension that isn't on the whitelist" do
@request.stubs(:request_extensions).returns [{ "oid" => "banana",
"value" => "yumm",
"critical" => true }]
expect { @ca.check_internal_signing_policies(@name, @request, false) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/request extensions that are not permitted/
)
end
it "should reject a non-critical extension that isn't on the whitelist" do
@request.stubs(:request_extensions).returns [{ "oid" => "peach",
"value" => "meh",
"critical" => false }]
expect { @ca.check_internal_signing_policies(@name, @request, false) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/request extensions that are not permitted/
)
end
it "should reject non-whitelist extensions even if a valid extension is present" do
@request.stubs(:request_extensions).returns [{ "oid" => "peach",
"value" => "meh",
"critical" => false },
{ "oid" => "subjectAltName",
"value" => "DNS:foo",
"critical" => true }]
expect { @ca.check_internal_signing_policies(@name, @request, false) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/request extensions that are not permitted/
)
end
it "should reject a subjectAltName for a non-DNS value" do
@request.stubs(:subject_alt_names).returns ['DNS:foo', 'email:bar@example.com']
expect { @ca.check_internal_signing_policies(@name, @request, true) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/subjectAltName outside the DNS label space/
)
end
it "should reject a wildcard subject" do
@request.content.stubs(:subject).
returns(OpenSSL::X509::Name.new([["CN", "*.local"]]))
expect { @ca.check_internal_signing_policies('*.local', @request, false) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/subject contains a wildcard/
)
end
it "should reject a wildcard subjectAltName" do
@request.stubs(:subject_alt_names).returns ['DNS:foo', 'DNS:*.bar']
expect { @ca.check_internal_signing_policies(@name, @request, true) }.to raise_error(
Puppet::SSL::CertificateAuthority::CertificateSigningError,
/subjectAltName contains a wildcard/
)
end
end
it "should create a certificate instance with the content set to the newly signed x509 certificate" do
@serial = 10
@ca.stubs(:next_serial).returns @serial
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with(@name).returns @request
Puppet::SSL::Certificate.indirection.stubs :save
Puppet::SSL::Certificate.expects(:new).with(@name).returns @cert
@ca.sign(@name)
end
it "should return the certificate instance" do
@ca.stubs(:next_serial).returns @serial
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with(@name).returns @request
Puppet::SSL::Certificate.indirection.stubs :save
@ca.sign(@name).should equal(@cert)
end
it "should add the certificate to its inventory" do
@ca.stubs(:next_serial).returns @serial
@inventory.expects(:add).with(@cert)
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with(@name).returns @request
Puppet::SSL::Certificate.indirection.stubs :save
@ca.sign(@name)
end
it "should have a method for triggering autosigning of available CSRs" do
@ca.should respond_to(:autosign)
end
describe "when autosigning certificates" do
let(:csr) { Puppet::SSL::CertificateRequest.new("host") }
describe "using the autosign setting" do
let(:autosign) { File.expand_path("/auto/sign") }
it "should do nothing if autosign is disabled" do
Puppet[:autosign] = false
@ca.expects(:sign).never
@ca.autosign(csr)
end
it "should do nothing if no autosign.conf exists" do
Puppet[:autosign] = autosign
non_existent_file = Puppet::FileSystem::MemoryFile.a_missing_file(autosign)
Puppet::FileSystem.overlay(non_existent_file) do
@ca.expects(:sign).never
@ca.autosign(csr)
end
end
describe "and autosign is enabled and the autosign.conf file exists" do
let(:store) { stub 'store', :allow => nil, :allowed? => false }
before do
Puppet[:autosign] = autosign
end
describe "when creating the AuthStore instance to verify autosigning" do
it "should create an AuthStore with each line in the configuration file allowed to be autosigned" do
Puppet::FileSystem.overlay(Puppet::FileSystem::MemoryFile.a_regular_file_containing(autosign, "one\ntwo\n")) do
Puppet::Network::AuthStore.stubs(:new).returns store
store.expects(:allow).with("one")
store.expects(:allow).with("two")
@ca.autosign(csr)
end
end
it "should reparse the autosign configuration on each call" do
Puppet::FileSystem.overlay(Puppet::FileSystem::MemoryFile.a_regular_file_containing(autosign, "one")) do
Puppet::Network::AuthStore.stubs(:new).times(2).returns store
@ca.autosign(csr)
@ca.autosign(csr)
end
end
it "should ignore comments" do
Puppet::FileSystem.overlay(Puppet::FileSystem::MemoryFile.a_regular_file_containing(autosign, "one\n#two\n")) do
Puppet::Network::AuthStore.stubs(:new).returns store
store.expects(:allow).with("one")
@ca.autosign(csr)
end
end
it "should ignore blank lines" do
Puppet::FileSystem.overlay(Puppet::FileSystem::MemoryFile.a_regular_file_containing(autosign, "one\n\n")) do
Puppet::Network::AuthStore.stubs(:new).returns store
store.expects(:allow).with("one")
@ca.autosign(csr)
end
end
end
end
end
describe "using the autosign command setting" do
let(:cmd) { File.expand_path('/autosign_cmd') }
let(:autosign_cmd) { mock 'autosign_command' }
let(:autosign_executable) { Puppet::FileSystem::MemoryFile.an_executable(cmd) }
before do
Puppet[:autosign] = cmd
Puppet::SSL::CertificateAuthority::AutosignCommand.stubs(:new).returns autosign_cmd
end
it "autosigns the CSR if the autosign command returned true" do
Puppet::FileSystem.overlay(autosign_executable) do
autosign_cmd.expects(:allowed?).with(csr).returns true
@ca.expects(:sign).with('host')
@ca.autosign(csr)
end
end
it "doesn't autosign the CSR if the autosign_command returned false" do
Puppet::FileSystem.overlay(autosign_executable) do
autosign_cmd.expects(:allowed?).with(csr).returns false
@ca.expects(:sign).never
@ca.autosign(csr)
end
end
end
end
end
describe "when managing certificate clients" do
before do
Puppet.settings.stubs(:use)
Puppet::SSL::CertificateAuthority.any_instance.stubs(:password?).returns true
stub_ca_host
Puppet::SSL::Host.expects(:new).returns @host
Puppet::SSL::CertificateAuthority.any_instance.stubs(:host).returns @host
@cacert = mock 'certificate'
@cacert.stubs(:content).returns "cacertificate"
@ca = Puppet::SSL::CertificateAuthority.new
end
it "should be able to list waiting certificate requests" do
req1 = stub 'req1', :name => "one"
req2 = stub 'req2', :name => "two"
Puppet::SSL::CertificateRequest.indirection.expects(:search).with("*").returns [req1, req2]
@ca.waiting?.should == %w{one two}
end
it "should delegate removing hosts to the Host class" do
Puppet::SSL::Host.expects(:destroy).with("myhost")
@ca.destroy("myhost")
end
it "should be able to verify certificates" do
@ca.should respond_to(:verify)
end
it "should list certificates as the sorted list of all existing signed certificates" do
cert1 = stub 'cert1', :name => "cert1"
cert2 = stub 'cert2', :name => "cert2"
Puppet::SSL::Certificate.indirection.expects(:search).with("*").returns [cert1, cert2]
@ca.list.should == %w{cert1 cert2}
end
it "should list the full certificates" do
cert1 = stub 'cert1', :name => "cert1"
cert2 = stub 'cert2', :name => "cert2"
Puppet::SSL::Certificate.indirection.expects(:search).with("*").returns [cert1, cert2]
@ca.list_certificates.should == [cert1, cert2]
end
describe "and printing certificates" do
it "should return nil if the certificate cannot be found" do
Puppet::SSL::Certificate.indirection.expects(:find).with("myhost").returns nil
@ca.print("myhost").should be_nil
end
it "should print certificates by calling :to_text on the host's certificate" do
cert1 = stub 'cert1', :name => "cert1", :to_text => "mytext"
Puppet::SSL::Certificate.indirection.expects(:find).with("myhost").returns cert1
@ca.print("myhost").should == "mytext"
end
end
describe "and fingerprinting certificates" do
before :each do
@cert = stub 'cert', :name => "cert", :fingerprint => "DIGEST"
Puppet::SSL::Certificate.indirection.stubs(:find).with("myhost").returns @cert
Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("myhost")
end
it "should raise an error if the certificate or CSR cannot be found" do
Puppet::SSL::Certificate.indirection.expects(:find).with("myhost").returns nil
Puppet::SSL::CertificateRequest.indirection.expects(:find).with("myhost").returns nil
expect { @ca.fingerprint("myhost") }.to raise_error
end
it "should try to find a CSR if no certificate can be found" do
Puppet::SSL::Certificate.indirection.expects(:find).with("myhost").returns nil
Puppet::SSL::CertificateRequest.indirection.expects(:find).with("myhost").returns @cert
@cert.expects(:fingerprint)
@ca.fingerprint("myhost")
end
it "should delegate to the certificate fingerprinting" do
@cert.expects(:fingerprint)
@ca.fingerprint("myhost")
end
it "should propagate the digest algorithm to the certificate fingerprinting system" do
@cert.expects(:fingerprint).with(:digest)
@ca.fingerprint("myhost", :digest)
end
end
describe "and verifying certificates" do
let(:cacert) { File.expand_path("/ca/cert") }
before do
@store = stub 'store', :verify => true, :add_file => nil, :purpose= => nil, :add_crl => true, :flags= => nil
OpenSSL::X509::Store.stubs(:new).returns @store
@cert = stub 'cert', :content => "mycert"
Puppet::SSL::Certificate.indirection.stubs(:find).returns @cert
@crl = stub('crl', :content => "mycrl")
@ca.stubs(:crl).returns @crl
end
it "should fail if the host's certificate cannot be found" do
Puppet::SSL::Certificate.indirection.expects(:find).with("me").returns(nil)
expect { @ca.verify("me") }.to raise_error(ArgumentError)
end
it "should create an SSL Store to verify" do
OpenSSL::X509::Store.expects(:new).returns @store
@ca.verify("me")
end
it "should add the CA Certificate to the store" do
Puppet[:cacert] = cacert
@store.expects(:add_file).with cacert
@ca.verify("me")
end
it "should add the CRL to the store if the crl is enabled" do
@store.expects(:add_crl).with "mycrl"
@ca.verify("me")
end
it "should set the store purpose to OpenSSL::X509::PURPOSE_SSL_CLIENT" do
Puppet[:cacert] = cacert
@store.expects(:add_file).with cacert
@ca.verify("me")
end
it "should set the store flags to check the crl" do
@store.expects(:flags=).with OpenSSL::X509::V_FLAG_CRL_CHECK_ALL|OpenSSL::X509::V_FLAG_CRL_CHECK
@ca.verify("me")
end
it "should use the store to verify the certificate" do
@cert.expects(:content).returns "mycert"
@store.expects(:verify).with("mycert").returns true
@ca.verify("me")
end
it "should fail if the verification returns false" do
@cert.expects(:content).returns "mycert"
@store.expects(:verify).with("mycert").returns false
expect { @ca.verify("me") }.to raise_error
end
describe "certificate_is_alive?" do
it "should return false if verification fails" do
@cert.expects(:content).returns "mycert"
@store.expects(:verify).with("mycert").returns false
@ca.certificate_is_alive?(@cert).should be_false
end
it "should return true if verification passes" do
@cert.expects(:content).returns "mycert"
@store.expects(:verify).with("mycert").returns true
@ca.certificate_is_alive?(@cert).should be_true
end
it "should used a cached instance of the x509 store" do
OpenSSL::X509::Store.stubs(:new).returns(@store).once
@cert.expects(:content).returns "mycert"
@store.expects(:verify).with("mycert").returns true
@ca.certificate_is_alive?(@cert)
@ca.certificate_is_alive?(@cert)
end
end
end
describe "and revoking certificates" do
before do
@crl = mock 'crl'
@ca.stubs(:crl).returns @crl
@ca.stubs(:next_serial).returns 10
@real_cert = stub 'real_cert', :serial => 15
@cert = stub 'cert', :content => @real_cert
Puppet::SSL::Certificate.indirection.stubs(:find).returns @cert
end
it "should fail if the certificate revocation list is disabled" do
@ca.stubs(:crl).returns false
expect { @ca.revoke('ca_testing') }.to raise_error(ArgumentError)
end
it "should delegate the revocation to its CRL" do
@ca.crl.expects(:revoke)
@ca.revoke('host')
end
it "should get the serial number from the local certificate if it exists" do
@ca.crl.expects(:revoke).with { |serial, key| serial == 15 }
Puppet::SSL::Certificate.indirection.expects(:find).with("host").returns @cert
@ca.revoke('host')
end
it "should get the serial number from inventory if no local certificate exists" do
real_cert = stub 'real_cert', :serial => 15
cert = stub 'cert', :content => real_cert
Puppet::SSL::Certificate.indirection.expects(:find).with("host").returns nil
@ca.inventory.expects(:serials).with("host").returns [16]
@ca.crl.expects(:revoke).with { |serial, key| serial == 16 }
@ca.revoke('host')
end
it "should revoke all serials matching a name" do
real_cert = stub 'real_cert', :serial => 15
cert = stub 'cert', :content => real_cert
Puppet::SSL::Certificate.indirection.expects(:find).with("host").returns nil
@ca.inventory.expects(:serials).with("host").returns [16, 20, 25]
@ca.crl.expects(:revoke).with { |serial, key| serial == 16 }
@ca.crl.expects(:revoke).with { |serial, key| serial == 20 }
@ca.crl.expects(:revoke).with { |serial, key| serial == 25 }
@ca.revoke('host')
end
it "should raise an error if no certificate match" do
real_cert = stub 'real_cert', :serial => 15
cert = stub 'cert', :content => real_cert
Puppet::SSL::Certificate.indirection.expects(:find).with("host").returns nil
@ca.inventory.expects(:serials).with("host").returns []
@ca.crl.expects(:revoke).never
expect { @ca.revoke('host') }.to raise_error
end
context "revocation by serial number (#16798)" do
it "revokes when given a lower case hexadecimal formatted string" do
@ca.crl.expects(:revoke).with { |serial, key| serial == 15 }
Puppet::SSL::Certificate.indirection.expects(:find).with("0xf").returns nil
@ca.revoke('0xf')
end
it "revokes when given an upper case hexadecimal formatted string" do
@ca.crl.expects(:revoke).with { |serial, key| serial == 15 }
Puppet::SSL::Certificate.indirection.expects(:find).with("0xF").returns nil
@ca.revoke('0xF')
end
it "handles very large serial numbers" do
bighex = '0x4000000000000000000000000000000000000000'
bighex_int = 365375409332725729550921208179070754913983135744
@ca.crl.expects(:revoke).with(bighex_int, anything)
Puppet::SSL::Certificate.indirection.expects(:find).with(bighex).returns nil
@ca.revoke(bighex)
end
end
end
it "should be able to generate a complete new SSL host" do
@ca.should respond_to(:generate)
end
end
end
require 'puppet/indirector/memory'
module CertificateAuthorityGenerateSpecs
describe "CertificateAuthority.generate" do
def expect_to_increment_serial_file
Puppet.settings.setting(:serial).expects(:exclusive_open)
end
def expect_to_sign_a_cert
expect_to_increment_serial_file
end
def expect_to_write_the_ca_password
Puppet.settings.setting(:capass).expects(:open).with('w')
end
def expect_ca_initialization
expect_to_write_the_ca_password
expect_to_sign_a_cert
end
INDIRECTED_CLASSES = [
Puppet::SSL::Certificate,
Puppet::SSL::CertificateRequest,
Puppet::SSL::CertificateRevocationList,
Puppet::SSL::Key,
]
INDIRECTED_CLASSES.each do |const|
class const::Memory < Puppet::Indirector::Memory
# @return Array of all the indirector's values
#
# This mirrors Puppet::Indirector::SslFile#search which returns all files
# in the directory.
def search(request)
return @instances.values
end
end
end
before do
Puppet::SSL::Inventory.stubs(:new).returns(stub("Inventory", :add => nil))
INDIRECTED_CLASSES.each { |const| const.indirection.terminus_class = :memory }
end
after do
INDIRECTED_CLASSES.each do |const|
const.indirection.terminus_class = :file
const.indirection.termini.clear
end
end
describe "when generating certificates" do
let(:ca) { Puppet::SSL::CertificateAuthority.new }
before do
expect_ca_initialization
end
it "should fail if a certificate already exists for the host" do
cert = Puppet::SSL::Certificate.new('pre.existing')
Puppet::SSL::Certificate.indirection.save(cert)
expect { ca.generate(cert.name) }.to raise_error(ArgumentError, /a certificate already exists/i)
end
describe "that do not yet exist" do
let(:cn) { "new.host" }
def expect_cert_does_not_exist(cn)
expect( Puppet::SSL::Certificate.indirection.find(cn) ).to be_nil
end
before do
expect_to_sign_a_cert
expect_cert_does_not_exist(cn)
end
it "should return the created certificate" do
cert = ca.generate(cn)
expect( cert ).to be_kind_of(Puppet::SSL::Certificate)
expect( cert.name ).to eq(cn)
end
it "should not have any subject_alt_names by default" do
cert = ca.generate(cn)
expect( cert.subject_alt_names ).to be_empty
end
it "should have subject_alt_names if passed dns_alt_names" do
cert = ca.generate(cn, :dns_alt_names => 'foo,bar')
expect( cert.subject_alt_names ).to match_array(["DNS:#{cn}",'DNS:foo','DNS:bar'])
end
context "if autosign is false" do
before do
Puppet[:autosign] = false
end
it "should still generate and explicitly sign the request" do
cert = nil
cert = ca.generate(cn)
expect(cert.name).to eq(cn)
end
end
context "if autosign is true (Redmine #6112)" do
def run_mode_must_be_master_for_autosign_to_be_attempted
Puppet.stubs(:run_mode).returns(Puppet::Util::RunMode[:master])
end
before do
Puppet[:autosign] = true
run_mode_must_be_master_for_autosign_to_be_attempted
Puppet::Util::Log.level = :info
end
it "should generate a cert without attempting to sign again" do
cert = ca.generate(cn)
expect(cert.name).to eq(cn)
expect(@logs.map(&:message)).to include("Autosigning #{cn}")
end
end
end
end
end
end
|