diff options
| author | Julian Andres Klode <jak@debian.org> | 2013-10-23 20:01:59 +0200 |
|---|---|---|
| committer | Julian Andres Klode <jak@debian.org> | 2013-10-23 20:01:59 +0200 |
| commit | 617f32fabedbb91d8b4db7dfb5b36c07e5f64d73 (patch) | |
| tree | 34bed1f416eb3bf108b9b7087b035665615b9df6 | |
| parent | 9678770074e48ba947e69d9a9f2ef9688688c07f (diff) | |
| download | python-apt-617f32fabedbb91d8b4db7dfb5b36c07e5f64d73.tar.gz | |
python/progress.cc: (scan-build): Fix some uninitialized values
We need to set those pointers to NULL, as the functions that may write
to them do not always write to them and we would read garbage in such
a case.
| -rw-r--r-- | python/progress.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/python/progress.cc b/python/progress.cc index aedd7581..a7cf1afa 100644 --- a/python/progress.cc +++ b/python/progress.cc @@ -126,7 +126,7 @@ bool PyFetchProgress::MediaChange(std::string Media, std::string Drive) PyCbObj_END_ALLOW_THREADS //std::cout << "MediaChange" << std::endl; PyObject *arglist = Py_BuildValue("(ss)", Media.c_str(), Drive.c_str()); - PyObject *result; + PyObject *result = NULL; if(PyObject_HasAttrString(callbackInst, "mediaChange")) RunSimpleCallback("mediaChange", arglist, &result); @@ -440,7 +440,7 @@ void PyCdromProgress::Update(std::string text, int current) bool PyCdromProgress::ChangeCdrom() { PyObject *arglist = Py_BuildValue("()"); - PyObject *result; + PyObject *result = NULL; if (PyObject_HasAttrString(callbackInst, "changeCdrom")) RunSimpleCallback("changeCdrom", arglist, &result); else @@ -459,7 +459,7 @@ bool PyCdromProgress::AskCdromName(std::string &Name) PyObject *arglist = Py_BuildValue("()"); const char *new_name; bool res; - PyObject *result; + PyObject *result = NULL; // Old style: (True, name) on success, (False, name) on failure. if (PyObject_HasAttrString(callbackInst, "askAdromName")) { |
