summaryrefslogtreecommitdiff
path: root/apt/cache.py
diff options
context:
space:
mode:
authorJulian Andres Klode <jak@debian.org>2010-04-21 13:38:48 +0200
committerJulian Andres Klode <jak@debian.org>2010-04-21 13:38:48 +0200
commitc57524a3efe3f26bfc7aee7ca80bf6640b23cd02 (patch)
tree9cd4c8cff323add4063869f1bf94fd65ddcc258a /apt/cache.py
parent17b0dc6856855f2cd46d234357f0de584db2019e (diff)
downloadpython-apt-c57524a3efe3f26bfc7aee7ca80bf6640b23cd02.tar.gz
apt/cache.py: Make Cache.get_changes() much (~35x) faster (Closes: #578074).
This change consists of the following ideas: - Switch to the low-level API - Use 'not marked_keep()' to check if a package has been modified.
Diffstat (limited to 'apt/cache.py')
-rw-r--r--apt/cache.py12
1 files changed, 8 insertions, 4 deletions
diff --git a/apt/cache.py b/apt/cache.py
index cfe6bedc..3b0c5f7e 100644
--- a/apt/cache.py
+++ b/apt/cache.py
@@ -176,10 +176,14 @@ class Cache(object):
def get_changes(self):
""" Get the marked changes """
changes = []
- for pkg in self:
- if (pkg.marked_upgrade or pkg.marked_install or pkg.marked_delete
- or pkg.marked_downgrade or pkg.marked_reinstall):
- changes.append(pkg)
+ marked_keep = self._depcache.marked_keep
+ for pkg in self._cache.packages:
+ if not marked_keep(pkg):
+ try:
+ changes.append(self._weakref[pkg.name])
+ except KeyError:
+ package = self._weakref[pkg.name] = Package(self, pkg)
+ changes.append(package)
return changes
@deprecated_args