diff options
| author | Michael Vogt <michael.vogt@ubuntu.com> | 2008-08-15 10:02:54 +0200 |
|---|---|---|
| committer | Michael Vogt <michael.vogt@ubuntu.com> | 2008-08-15 10:02:54 +0200 |
| commit | 34503feab88a8aa72ef511f86375933a4d8707ef (patch) | |
| tree | 5759391d1f5fff4c60ce63a1f9a868f6924230d4 /python/progress.cc | |
| parent | 1d96f36591c56798021c4e33d01a781507592add (diff) | |
| download | python-apt-34503feab88a8aa72ef511f86375933a4d8707ef.tar.gz | |
* python/progress.cc:
- when pulse() does not return a boolean assume "true"
(thanks to Martin Pitt for telling me about the problem)
Diffstat (limited to 'python/progress.cc')
| -rw-r--r-- | python/progress.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/python/progress.cc b/python/progress.cc index 793265db..99ad0a25 100644 --- a/python/progress.cc +++ b/python/progress.cc @@ -185,8 +185,10 @@ bool PyFetchProgress::Pulse(pkgAcquire * Owner) bool res = true; if(!PyArg_Parse(result, "b", &res)) { - // mvo: this is harmless, we shouldn't print anything here - //std::cerr << "result could not be parsed" << std::endl; + // most of the time the user who subclasses the pulse() + // method forgot to add a return {True,False} so we just + // assume he wants a True + return true; } // fetching can be canceld by returning false |
