diff options
| author | Christian Ambach <ambi@samba.org> | 2014-11-04 23:51:23 +0100 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2014-12-18 20:50:08 +0100 |
| commit | 950506d158cf88c72d993cec2f199abc6e90d066 (patch) | |
| tree | 79dab96d6ddb5c14f083ab47677397ebc88aa169 /source3 | |
| parent | b18866b858a5ee75340d6f26e27f834db049c231 (diff) | |
| download | samba-950506d158cf88c72d993cec2f199abc6e90d066.tar.gz | |
s3:utils/profiles fix a use after free
path is a talloc-child of subkeys, so subkeys should not be freed before calling
verbose_output
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Wed Dec 3 00:43:19 CET 2014 on sn-devel-104
(cherry picked from commit 3b90bfb1089e6a4b7e05e7ed62bb642521f57917)
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/utils/profiles.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/source3/utils/profiles.c b/source3/utils/profiles.c index 30c6ad0a1f..a88469a919 100644 --- a/source3/utils/profiles.c +++ b/source3/utils/profiles.c @@ -182,12 +182,12 @@ static bool copy_registry_tree( REGF_FILE *infile, REGF_NK_REC *nk, } } - /* values is a talloc()'d child of subkeys here so just throw it all away */ - - TALLOC_FREE( subkeys ); verbose_output("[%s]\n", path); + /* values is a talloc()'d child of subkeys here so just throw it all away */ + TALLOC_FREE(subkeys); + return True; } |