diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2014-05-23 16:06:17 +1200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2014-07-15 12:46:15 +0200 |
| commit | f72899ec2bc0ad3f6cd1e3d586235543b51f7cd1 (patch) | |
| tree | 1a68b5d71b7db5f49ec832bf73ba46919e1d3c12 /source4/dsdb/schema/schema_init.c | |
| parent | 4730d74e38998aaeadbe13682cc6462c3ceb4766 (diff) | |
| download | samba-f72899ec2bc0ad3f6cd1e3d586235543b51f7cd1.tar.gz | |
dsdb: Do not store a struct ldb_dn in struct schema_data
The issue is that the DN contains a pointer to the ldb it belongs to,
and if this is not kept around long enough, we might reference memory
after it is de-allocated.
Andrew Bartlett
Change-Id: I040a6c37a3164b3309f370e32e598dd56b1a1bbb
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 8327321225251e312ccbd06bbefa5ebf98099f34)
Diffstat (limited to 'source4/dsdb/schema/schema_init.c')
| -rw-r--r-- | source4/dsdb/schema/schema_init.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/source4/dsdb/schema/schema_init.c b/source4/dsdb/schema/schema_init.c index efbd38a4ba..43a6a89b3c 100644 --- a/source4/dsdb/schema/schema_init.c +++ b/source4/dsdb/schema/schema_init.c @@ -58,12 +58,6 @@ struct dsdb_schema *dsdb_schema_copy_shallow(TALLOC_CTX *mem_ctx, return NULL; } - /* schema base_dn */ - schema_copy->base_dn = ldb_dn_copy(schema_copy, schema->base_dn); - if (!schema_copy->base_dn) { - goto failed; - } - /* copy prexiMap & schemaInfo */ schema_copy->prefixmap = dsdb_schema_pfm_copy_shallow(schema_copy, schema->prefixmap); @@ -931,8 +925,6 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb, false); } - schema->base_dn = talloc_steal(schema, schema_res->msgs[0]->dn); - prefix_val = ldb_msg_find_ldb_val(schema_res->msgs[0], "prefixMap"); if (!prefix_val) { *error_string = talloc_asprintf(mem_ctx, |