summaryrefslogtreecommitdiff
path: root/Notes
diff options
context:
space:
mode:
authorJohn Hodge (bugs) <tpg@mutabah.net>2017-05-14 12:01:45 +0800
committerJohn Hodge (bugs) <tpg@mutabah.net>2017-05-14 12:01:45 +0800
commit1d2fe7681219700998c8ecbdb8ed5acab66578df (patch)
tree0d38e8ab5fd80c890d3dec67a0596abfc7a4f0cd /Notes
parentc6fca061dd134068c831aefd88d9535a30f423ed (diff)
parentfde22b3f03d802231985b8ded567cba16cb5aa00 (diff)
downloadmrust-1d2fe7681219700998c8ecbdb8ed5acab66578df.tar.gz
Merge branch 'master' of https://github.com/thepowersgang/mrustc
# Conflicts: # src/common.hpp # src/hir/deserialise.cpp # src/hir_typeck/static.cpp # src/mir/from_hir.cpp # src/mir/from_hir.hpp # src/mir/from_hir_match.cpp # src/mir/helpers.hpp # src/mir/mir_builder.cpp
Diffstat (limited to 'Notes')
-rw-r--r--Notes/BigChanges/Variant.md70
-rw-r--r--Notes/BorrowChecker.md7
-rw-r--r--Notes/MIR-Match.md19
-rw-r--r--Notes/MIR-Validation.txt9
-rw-r--r--Notes/todo.txt6
5 files changed, 109 insertions, 2 deletions
diff --git a/Notes/BigChanges/Variant.md b/Notes/BigChanges/Variant.md
new file mode 100644
index 00000000..55bb3bb0
--- /dev/null
+++ b/Notes/BigChanges/Variant.md
@@ -0,0 +1,70 @@
+
+(the below is from @ubsan)
+
+```
+// one can define their own variant, but I'm lazy
+#include <variant>
+#include <type_traits>
+#include <iostream>
+
+template <typename F, typename T, typename Void = void>
+struct return_type {};
+
+template <typename F, typename T>
+struct return_type<T, F, std::void_t<
+ decltype(std::declval<F>()(std::declval<T>()))
+>> {
+ using type = decltype(std::declval<F>()(std::declval<T>()));
+};
+
+template <typename F, typename T>
+using return_type_t = typename return_type<T, F>::type;
+
+// not sure what to call this
+template <typename F, typename... Ts>
+struct common_return_type {
+ using type = std::common_type_t<return_type_t<F, Ts>...>;
+};
+
+template <typename F, typename... Ts>
+using common_return_type_t = typename common_return_type<F, Ts...>::type;
+
+template <typename F, typename... Ts>
+auto match(
+ std::variant<Ts...>& variant, F&& functor
+) -> common_return_type_t<F, Ts...> {
+ // you could also use static_assert to make it SFINAE-unfriendly
+ return std::visit(functor, variant);
+}
+
+template <typename... Fs>
+struct overloaded : Fs... {
+ using Fs::operator()...;
+ overloaded(Fs&&... fs) : Fs(std::forward<Fs>(fs))... { }
+};
+
+int main() {
+ auto var = std::variant<int, std::string>(0);
+ std::cout << match(var, overloaded(
+ [](int i) { return i; },
+ [](std::string s) { return 0; }
+ ));
+}
+```
+
+
+
+ALTERNATIVE
+===========
+
+Could just update TU to have:
+``
+stmt.if_let(
+stmt.match_def(
+stmt.match(
+ [](::MIR::LValue::Data_Assign& se) {
+ },
+ [](::MIR::LValue::Data_Drop& se) {
+ }
+ );
+```
diff --git a/Notes/BorrowChecker.md b/Notes/BorrowChecker.md
new file mode 100644
index 00000000..78b46ff5
--- /dev/null
+++ b/Notes/BorrowChecker.md
@@ -0,0 +1,7 @@
+- On borrow, calculate lifetime of asignment (using existing lifetime code)
+ - Ignore reborrows?
+- Visit all statements in that lifetime and locate places where the borrow is propagated/stored
+ - Requires lifetime parameters on functions/&-ptrs to be present
+- Assignment of the source value during the lifetime of the borrow is an error
+- Dropping of the source value is an error
+- Returning the borrow is an error
diff --git a/Notes/MIR-Match.md b/Notes/MIR-Match.md
index f47d2c88..cc95522c 100644
--- a/Notes/MIR-Match.md
+++ b/Notes/MIR-Match.md
@@ -20,3 +20,22 @@ For each index in the rule (all rules must be the same length)
- Ranges sort after?
+
+Alternative Generator 2
+=======================
+
+Maintains match ordering
+
+1. Calculate branch rulesets (as existing)
+1. While rules to process:
+ 1. Group based on shared values.
+ 1. Generate dispatch arm for each group
+ 1. Recurse into group, passing local _ as fallback (or parent _ if none)
+
+```
+
+for
+
+```
+
+
diff --git a/Notes/MIR-Validation.txt b/Notes/MIR-Validation.txt
new file mode 100644
index 00000000..337c65cd
--- /dev/null
+++ b/Notes/MIR-Validation.txt
@@ -0,0 +1,9 @@
+
+Requirements:
+- Know full state (and linked states) for each path through the function.
+
+
+Idea:
+- Lifetime calculations (existing code)
+ - Mask out known invalid values at loopback.
+
diff --git a/Notes/todo.txt b/Notes/todo.txt
index 35526889..54956718 100644
--- a/Notes/todo.txt
+++ b/Notes/todo.txt
@@ -19,5 +19,7 @@ TODO:
- Optimise typecheck.
-- MIR: Add a Parameter type that is either LValue, Constant
- > For any place a LValue is currently used, but a constant is valid
+- MIR: Unify Variable/Argument/Temporary LValue types
+ - This should reduce the amount of code needed for validation, but will be a
+ BIG change.
+