| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
mount does not parse parse offset= option if it is followed by other
options. In umount, the parsing is done with the get_value() function.
This patch moves get_value to fstab.c (with new name get_option_value())
and fixes mount to use the function.
[kzak@redhat.com: - rename to get_option_value()
- use fstab.c rather than sundries.c]
Novell bugzilla: #666150
Reported-by: Ludwig Nussel <ludwig.nussel@suse.de>
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
- replace mnt_ with libmnt_ prefix for types (the old prefix was too generic)
- remove typedef, use struct everywhere
- use shorter functions names (s/userspace/user/; s/mountflags/mflags/)
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
The mount.h file name is too generic.
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
I spent most of the day tracking down this subtle remount bug. I
think this is the correct solution but I'd appreciate some
double-checking. I suspect this bug will munge the mount options
whenever you remount a file system mounted on the same mountpoint as
another file system, using the mountpoint as the handle.
-VAL
commit c010b3a0783430e2b94f3b3dc0929ae299e383eb
Author: Valerie Aurora <vaurora@redhat.com>
Date: Tue Aug 3 16:32:52 2010 -0700
mount: get most recently mounted fs from /etc/mtab.
In mount, when using /etc/mtab to lookup a mount entry, get the most
recently mounted entry instead of the first mounted entry. You want
to manipulate the most recent mount, not a covered mount. See comment
to umount_one_bw().
This bug has been util-linux-ng since the first git checkin. It
finally showed up on my system with the change to stop using
SETLOOP_AUTOCLEAR if /etc/mtab is writable (commit af092544). If you
do a remount of a file system mounted on the same dir as another file
system, it will take the options from the first mount and write them
out to /etc/mtab as the options to the second mount - including, in
the case of a loop device, loop=/dev/loop0. Then when you umount the
second mount, it grabs the line from /etc/mtab and tries to tear down
the loop device, which complains because it is still in use by the
first mount.
Reproducible test case (on a system with writable /etc/mtab):
mount -o loop,ro /tmp/ro /mnt
mount -t tmpfs tmpfs /mnt
mount -o remount,ro /mnt
cat /etc/mtab | tail -2
Signed-off-by: Valerie Aurora <vaurora@redhat.com>
|
|
In repair mode the root filesystem is read-only and mtab file is not
up to date.
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=427183
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
fix:
- don't call canonicalize_spec() for LABELs/UUIDs
- simplify the code
- rename to getfs_by_devdir(), because we use it only for
device names and not for SPECes (see umount.c).
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
What the patch does is goes from the situation where:
1) If /etc/mtab doesn't exist and /etc is read-only, you get the
"can't create lock file" message and the mount fails
2) If /etc/mtab does exist and /etc is read-only,you get the same
message but the mount succeeds
Clearly, the failure to update /etc/mtab should either cause the mount
to fail or not ... sometimes causing it to fail, and sometimes not
(each with the same message) is not useful.
This patch sets the same behaviour for create and update mtab. In both
cases it prints error message and the mount succeeds.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
The automake stuff uses "-I.". as a default gcc option for includes. This is a
problem for source code where is local includes with a same name like system
includes (e.g. mntent.h, paths.h). Possible workaround is overwrite the
automake DEFAULT_INCLUDES variable. But this solution produces warnings. The
best way (this patch) is probably rename the files and remove DEFAULT_INCLUDES.
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
