diff options
| author | rillig <rillig> | 2006-06-18 08:43:35 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2006-06-18 08:43:35 +0000 |
| commit | 1f21b59bec16b4e2a880999d4a3a98cdcf442c22 (patch) | |
| tree | 48caae59535c2372080af105645bf2b4813d8eb0 | |
| parent | 79cd0ac89ae052fe81a99427656b6c983335b3a6 (diff) | |
| download | pkgsrc-1f21b59bec16b4e2a880999d4a3a98cdcf442c22.tar.gz | |
When checking a Pathlist, split $value instead of $value_novar. This avoids
many false positive warnings for paths like ${PREFIX}/foo.
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 4612c7015bd..d430a269a68 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.632 2006/06/18 08:20:19 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.633 2006/06/18 08:43:35 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -4185,7 +4185,9 @@ sub checkline_mk_vartype_basic($$$$$$$) { } } elsif ($type eq "Pathlist") { - my (@paths) = split(qr":", $value_novar); + # XXX: The splitting will fail if $value contains any + # variables with modifiers, for example :Q or :S/././. + my (@paths) = split(qr":", $value); foreach my $p (@paths) { checkline_mk_vartype_basic($line, $varname, "Pathname", $op, $p, $comment, false); |