summaryrefslogtreecommitdiff
path: root/source3/utils
AgeCommit message (Collapse)AuthorFilesLines
2014-12-18s3:utils/profiles fix a use after freeChristian Ambach1-3/+3
path is a talloc-child of subkeys, so subkeys should not be freed before calling verbose_output Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Wed Dec 3 00:43:19 CET 2014 on sn-devel-104 (cherry picked from commit 3b90bfb1089e6a4b7e05e7ed62bb642521f57917)
2014-12-04s3-smbstatus: Fix exit code of profile output.Andreas Schneider1-2/+5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10961 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-08-07s3: net time - fix usage and core dump.Jeremy Allison1-10/+20
Bug 10728 - 'net time system' segfaults https://bugzilla.samba.org/show_bug.cgi?id=10728 Signed-off-by: Jeremy Allison <jra@samba.org>
2014-06-10s3: client : Add extra return parameter to all client open calls.Jeremy Allison3-7/+9
Add a return parameter of struct smb_create_returns *cr to cli_ntcreate() cli_ntcreate_recv() cli_nttrans_create() cli_nttrans_create_recv() Always pass in NULL for now. This fixes the create API to always fully return the data the server has given back to us on the open file to the caller. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 69e24b4e8bc607806453ab137efda6d6bf74fb12)
2014-04-01s3:utils/smbfilter: use a local variable for the packet bufferStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3667a2eee388915fca2b894ae37375eeed46e941)
2014-03-11CVE-2013-6442: s3:smbcacls - ensure we don't lose an existing ACL when ↵Jeremy Allison1-1/+1
setting owner or group owner. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10327 Bug 10327 - CVE-2013-6442: smbcacls --chown | --chgrp dacl regression Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2014-02-05Stop use after freeAlistair Leslie-Hughes1-1/+5
Fixes bug #10087 Thanks to Man Min Yan for their analysis and providing a solution to the issue. Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Sep 27 14:29:46 CEST 2013 on sn-devel-104 (cherry picked from commit 6bf9a774718917c3429fa1492f5b0268ae5e01c3) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Feb 5 13:12:49 CET 2014 on sn-devel-104
2014-01-25s3: smbpasswd - fix crashes on invalid input.Jeremy Allison3-5/+28
get_pass can return NULL on error. Ensure that this is always the case and fix all callers to cope (some already did). Reported by Joonas Kuorilehto <joneskoo@codenomicon.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10320 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Dec 16 15:17:58 CET 2013 on sn-devel-104 (cherry picked from commit ef5a3bedab74420baf0c653cf8e304fe6c2a13b4) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Sat Jan 25 18:16:55 CET 2014 on sn-devel-104
2013-12-09Merge tag 'samba-4.1.3' into v4-1-testKarolin Seeger2-2/+54
samba: tag release samba-4.1.3
2013-12-05CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.Jeremy Allison1-1/+6
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2013-12-05CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.Jeremy Allison2-1/+48
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
2013-11-26s3-utils: Fix scanf format in sharesec.Andreas Schneider1-3/+3
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 278899f5a763af7e7603f05f07048b7d8d4e9972)
2013-11-26s3-utils: Fix scanf format in smbacls.Andreas Schneider1-3/+3
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 4c98b9ce8f8de5883796aa38f1193e04a0ee4e58)
2013-11-26s3-lib: Add grpname to talloc_sub_specified().Andreas Schneider1-0/+2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=2191 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 6366ebb79bb72d9dcb12f8fe8d6e35611fcff150)
2013-08-30s3:smbcacls: Add -m<MAX PROTOCOL> option to smbcacls.Jeremy Allison1-0/+4
https://bugzilla.samba.org/show_bug.cgi?id=9514 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit f6ce50a8aca9eb024af4eb5e3dd620fe5e04e913)
2013-07-15s3-smbstatus: display [u|g]id of -1 as "-1" in connection listBjörn Baumbach1-4/+20
In order to avoid displayed uid or gid of "4294967295" instead of "-1", we need to fetch the special case -1. The id can be -1 if we are reading e.g. incomplete session information. Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jul 10 01:18:30 CEST 2013 on sn-devel-104 (cherry picked from commit 577cef82c776759c9f3cad7d33057ac865c40769) The last 3 patches address bug #10003 - s3-lib:segmentation fault while reading incomplete session info.
2013-06-26sharesec: Implement --view-allVolker Lendecke1-1/+34
Listing individual shares can be quite slow when you have a lot of shares. This implements a --view-all option that prints something like [share1] REVISION:1 OWNER:(NULL SID) GROUP:(NULL SID) ACL:S-1-1-0:ALLOWED/0/FULL [share2] REVISION:1 OWNER:(NULL SID) GROUP:(NULL SID) ACL:S-1-1-0:ALLOWED/0/FULL Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-06-21s3:utils/net_sam make use of pdb_create_builtin helper functionChristian Ambach1-1/+1
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-06-21s3:utils/net_lookup fix a format-errorChristian Ambach1-1/+1
clang complains about short being used for unsigned as format-error Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-06-04smbcquotas.c: fix a bug of -tPeng Haitao1-1/+1
'r' should be replaced with 't'. Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Tue Jun 4 13:06:52 CEST 2013 on sn-devel-104
2013-05-28net: use smbconf_create_set_share() in "net conf import"Michael Adam1-47/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104
2013-05-22When message-type is drvupgrade, MSG_DEBUG should be replaced with ↵Peng Haitao1-1/+1
MSG_PRINTER_DRVUPGRADE. Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-05-22When '--policies-reset' is success, the exit code should be 0.Peng Haitao1-1/+1
Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-05-15source3/utils/ntlm_auth.c: Fix typo in debug message.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-06s3:utils fix wrong usage of PRIu64 in sscanfChristian Ambach1-1/+3
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Use color only when available.Andreas Schneider1-1/+8
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Apr 29 15:02:19 CEST 2013 on sn-devel-104
2013-04-29regedit: Improve the while loop.Andreas Schneider1-8/+7
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Remove talloc leak report.Andreas Schneider1-4/+0
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Mark string values if they contain unprintable chars.C. Davis3-3/+31
Also, edit the values in bin mode to avoid screen glitches. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Add an edit binary command.C. Davis3-12/+27
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Handle zero-length buffers better with hexedit.C. Davis2-2/+19
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Load values on startup.C. Davis1-4/+12
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Simplify the editor dialog input loop.C. Davis1-47/+56
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Fix white space and wrap long lines.C. Davis4-16/+25
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Add missing copyright headers to hexedit code.C. Davis2-0/+38
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Enable using tab to cycle thru dialog buttons.C. Davis1-13/+65
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Restore cursor position when user tabs to a field.C. Davis1-0/+5
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Add a general help section.C. Davis1-7/+16
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Print help on left side of screen instead of the right.C. Davis1-6/+5
This is little bit easier to read to my eye. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Reduce magic numbers in edit dialog, clean up edit dialog creation.C. Davis1-79/+183
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Add help msgs for key and value sections at bottom of screen.C. Davis1-2/+33
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Prefer copywin() over prefresh() for displaying path.C. Davis1-4/+5
copywin() works better with panels, dialogs, etc. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Cut off the front of the path when screen width is too small.C. Davis3-9/+24
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Uese a pad for path label.C. Davis2-16/+28
This makes it easier scale the label on resize. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Improve padding for value summary.C. Davis1-1/+1
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Update dialog position on screen resize.C. Davis4-73/+131
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Handle term resizes.C. Davis6-53/+116
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Create subkeys.C. Davis1-32/+64
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Delete and add keys.C. Davis3-13/+99
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-04-29regedit: Edit binary values with hexedit.C. Davis1-26/+117
Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>