summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2015-02-21s3-netlogon: Make sure we do not deference a NULL pointer.Andreas Schneider1-1/+6
This is an additional patch for CVE-2015-0240. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11077#c32 Pair-Programmed-With: Michael Adam <obnox@samba.org> Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2015-02-21CVE-2015-0240: s3: netlogon: Ensure we don't call talloc_free on an ↵Jeremy Allison1-1/+5
uninitialized pointer. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11077 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2015-01-11nsswitch: fix soname of linux nss_*.so.2 modulesStefan Metzmacher1-7/+0
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9299 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (similar to commit 575b093dac3c509b1bfaab0b4ad29b9b4214e487) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Sun Jan 11 16:15:06 CET 2015 on sn-devel-104
2015-01-11winbind: Retry after SESSION_EXPIRED error in ping-dcChristof Schmitt1-0/+8
Trying to establish a netlogon connection when the service ticket expires might fail with NT_STATUS_NETWORK_SESSION_EXPIRED. The underlying client code already marks the session as invalid, so retry the netlogon connect in this case. Signed-off-by: Christof Schmit <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jan 6 02:58:57 CET 2015 on sn-devel-104 (cherry picked from commit a2670f15dea27c10e3827216adf572f9c3894f85) BUG: https://bugzilla.samba.org/show_bug.cgi?id=11034
2015-01-11winbind: Retry LogonControl RPC in ping-dc after session expirationChristof Schmitt1-0/+10
When the underlying session expires, the LogonControl RPC call used in ping-dc returns NT_STATUS_IO_DEVICE_ERROR. Retry once in this case, instead of returning the error to the caller. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Dec 23 02:46:34 CET 2014 on sn-devel-104 (cherry picked from commit 2fdc55160309cec89aeb88243cb18d058c67e918) BUG: https://bugzilla.samba.org/show_bug.cgi?id=11034
2015-01-11idl:drsuapi: Manage all possible lengths of drsuapi_DsBindInfoSamuel Cabrero2-1/+24
Signed-off-by: Samuel Cabrero <scabrero@zentyal.com> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> (cherry picked from commit d747372d28273542298f86530e715e8faaf907f2)
2014-12-18s3:smb2_server: allow reauthentication without signingStefan Metzmacher2-5/+4
If signing is not required we should not require it for reauthentication. Windows clients would otherwise fail to reauthenticate. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10958 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 382019656ee164fd21455ed7d7b5e9e18bd0ca72)
2014-12-18s3:smb2_server: use the global signing key to check if signing is requiredStefan Metzmacher1-1/+1
If we have a channel session key, we also always have a global session key. For multi-channel it's possible that the channel session key is not in place yet, in that case the global session key needs to be used. In both cases (reauth or session bind) we session setup requests need to be signed. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 7e006d11134cdc37ea0fc13110fe5bbfb9de3f14)
2014-12-18s3:utils/profiles fix a use after freeChristian Ambach1-3/+3
path is a talloc-child of subkeys, so subkeys should not be freed before calling verbose_output Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Wed Dec 3 00:43:19 CET 2014 on sn-devel-104 (cherry picked from commit 3b90bfb1089e6a4b7e05e7ed62bb642521f57917)
2014-12-18s3:registry/regfio fix some valgrind warningsChristian Ambach1-2/+2
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 4b41489901b7f1a78ffd479128c3e0d309e53b53)
2014-12-18s3:registry/regfio read SD from the correct locationChristian Ambach1-2/+4
try to find the security descriptor at the data pointer, not at the beginning of the hbin Bug: https://bugzilla.samba.org/show_bug.cgi?id=9629 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 217a0189c15761f6c7b24c9d7bfdbccf85de8e1d)
2014-12-08s3: modules: Fix *allocate* calls to follow POSIX error return convention.Jeremy Allison3-13/+13
Fix up the ceph, time_audit and streams_xattr modules to follow the -1,errno convention for errors. Reported by Jones <jones.kstw@gmail.com> who provided the initial patch. This patch tested and confirmed working by him as well. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Mon Dec 8 12:29:00 CET 2014 on sn-devel-104
2014-12-08s3: smbd: Fix *allocate* calls to follow POSIX error return convention.Jeremy Allison1-11/+11
Fix vfs_allocate_file_space(), vfs_slow_fallocate(), vfs_fill_sparse() to follow the -1,errno convention for errors. Standardize on the -1,errno convention. Reported by Jones <jones.kstw@gmail.com> who provided the initial patch. This patch tested and confirmed working by him as well. https://bugzilla.samba.org/show_bug.cgi?id=10982 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de> (cherry picked from commit cc1f91cec627cb3e4fc89b96aae1e7e4c539cd1c)
2014-12-08s3: smbd: Fix *allocate* calls to follow POSIX error return convention.Jeremy Allison1-5/+12
vfswrap_fallocate() is broken in that it can call posix_fallocate() which returns an int error (and doesn't set errno) but can also call Linux fallocate() which returns -1 and sets errno. Standardize on the -1,errno convention. Reported by Jones <jones.kstw@gmail.com> who provided the initial patch. This patch tested and confirmed working by him as well. https://bugzilla.samba.org/show_bug.cgi?id=10982 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de> (cherry picked from commit c9235deee0fc49c99cfaf2329b7af526d9dd12d0)
2014-12-08s3-libsmb: Duplicate the memory before we free it.Andreas Schneider1-3/+6
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10279 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 8c41795c81d85114e383e694ba7421e95bacb912)
2014-12-08s3-libsmb: Set the netbios_name in use_ccache case too.Andreas Schneider1-0/+9
If we do not set the netbios_name we are not able to connect to a Windows DC. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10279 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 206f25d815024248214f076fd60c35862e9de8a1)
2014-12-08s3-lib: Do not require a password with --use-ccache.Andreas Schneider2-3/+4
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10279 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 1e148a91fd20053f823b57e19d757665fa30c53d)
2014-12-04libcli: SMB2: Pure SMB2-only negprot fix to make us behave as a Windows ↵Jeremy Allison1-0/+2
client does. Required as some servers return zero when asked for zero credits in an initial SMB2-only negprot. Back-port of c426f97238e4f664d1b13781101ca9c942aa7d0d from master. https://bugzilla.samba.org/show_bug.cgi?id=10966 Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Dec 4 21:55:16 CET 2014 on sn-devel-104
2014-12-04s3-smbstatus: Fix exit code of profile output.Andreas Schneider1-2/+5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10961 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-12-04s3-smbclient: Return success if we listed the shares.Andreas Schneider1-1/+1
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10960 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-11-24samba: pass down size_t instead of int to add_string_to_array().Günther Deschner8-10/+12
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Mon Nov 17 19:53:22 CET 2014 on sn-devel-104 The last 3 patches address BUG: https://bugzilla.samba.org/show_bug.cgi?id=10942 cleanup add_string_to_array and usage
2014-11-24s3-proto: remove duplicate proto for add_string_to_array().Günther Deschner1-3/+0
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2014-11-17s3:build: don't detect perl in source3/wscript again.Michael Adam1-1/+0
This is done in the top level now. Signed-off-by: Michael Adam <obnox@samba.org> (cherry picked from commit e7fc38a7df90e26a96ec5573042dccc1746e4f2c)
2014-11-17pdb_tdb: Fix a TALLOC/SAFE_FREE mixupVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10932 invalid free in pdb_tdb
2014-11-17s3-keytab: fix keytab array NULL termination.Matt Rogers1-2/+1
Signed-off-by: Matt Rogers <mrogers@redhat.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 0de6799996955fbf8e19ace8c4b7b61f5a262cb5) BUG: https://bugzilla.samba.org/show_bug.cgi?id=10933 net ads join -k can segfault with existing keytab entries
2014-11-17spoolss: remove unused fill_job_info3()David Disseldorp1-21/+0
This logic has been moved into the previous EnumJobs(level=3) caller. The info3 structure only contains two fields that are used, so it doesn't make sense to have a separate helper for it. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit d772b98283f289917a6a8370808d4d0912899384)
2014-11-17spoolss: fix jobid in level 3 EnumJobs responseDavid Disseldorp1-23/+33
Until now, these responses have incorrectly carried the printing backend job identifier (sysjob), rather than the one allocated and returned by Samba on job submission. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10905 Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 5e7ab3d2f4f7950099561eb22d6a9a1536297442)
2014-11-17spoolss: fix jobid in level 2 GetJob and EnumJobs responsesDavid Disseldorp1-14/+36
Until now, these responses have incorrectly carried the printing backend job identifier (sysjob), rather than the one allocated and returned by Samba on job submission. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10905 Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 45abaf81c67b62bab571df208931241afa660802)
2014-11-17spoolss: fix jobid in level 1 GetJob and EnumJobs responsesDavid Disseldorp1-12/+36
Until now, these responses have incorrectly carried the printing backend job identifier (sysjob), rather than the one allocated and returned by Samba on job submission. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10905 Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 4d7f5d2af6ef6960dccaccf89c6e88947e2591bf)
2014-11-17spoolss: fix GetJob jobid lookupsDavid Disseldorp1-5/+32
Clients issue GetJob requests using the jobid assigned by the spoolss server. The corresponding printing backend (sysjob) identifier needs to be resolved to locate the correct print queue entry. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10905 Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3a28ae56977235d3c9e3abcd1f24b220e536c50d)
2014-11-17printing: add jobid_to_sysjob helper functionDavid Disseldorp2-18/+53
Samba needs to deal with two types of print job identifiers, those allocated by the printing backend (sysjob ids), and those allocated by Samba's spoolss server (jobids). This change adds a helper function to map spoolss jobids to sysjob ids, to go alongside the corresponding sysjob to jobid mapping function. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 77b5be1742ee7aa2733a25bfa6a3af369f5c9401)
2014-11-09s3:smbd: fix file corruption using "write cache size != 0"Stefan Metzmacher1-0/+3
A client can: - open a handle (h1) - write some data to h1. - open a 2nd handle h2 (downgrades both handles to level II) - try to read the data on h2 (this gets old data) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10921 Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Sun Nov 9 22:57:54 CET 2014 on sn-devel-104
2014-11-09s3: nmbd: Ensure NetBIOS names are only 15 characters stored.Jeremy Allison1-1/+9
This screws up if the name is greater than MAX_NETBIOSNAME_LEN-1 in the unix charset, but less than or equal to MAX_NETBIOSNAME_LEN-1 in the DOS charset, but this is so old we have to live with that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10920 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 7467f6e72cba214eeca75c34e9d9fba354c7ef31) Signed-off-by: Andreas Schneider <asn@samba.org>
2014-11-09s3: libsmbclient - smb2. MacOSX 10 SMB2 server doesn't set ↵Jeremy Allison1-0/+14
STATUS_NO_MORE_FILES when handed a non-wildcard path. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Steve French <smfrench@gmail.com> Tested-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Steve French <sfrench@samba.org> Autobuild-Date(master): Thu Oct 23 20:44:31 CEST 2014 on sn-devel-104 (cherry picked from commit 95bf43bc6a0b6a4a47b8a556eee3b78446ea4123) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10904 smbclient loops doing a directory listing against Mac OS X 10 server with a non-wildcard path.
2014-11-09spoolss: fix handling of bad EnumJobs levelsDavid Disseldorp1-1/+6
Currently Samba is inconsistent when returning WERR_UNKNOWN_LEVEL errors for spoolss EnumJobs requests - if no print jobs are present, then WERR_OK will be returned, regardless of whether the EnumJobs level is supported or not. This change fixes this behaviour, by catching invalid or unsupported levels prior to the no-jobs response fast-path. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10898 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Oct 28 03:05:35 CET 2014 on sn-devel-104 (cherry picked from commit d4f233a746d89e13aae78008b499c71b695ff882)
2014-11-09s3-nmbd: Fix netbios name truncation.Jeremy Allison1-8/+68
Try and cope with truncation more intelligently. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10896 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 6adcc7bffd5e1474ecba04d2328955c0b208cabc) Signed-off-by: Andreas Schneider <asn@samba.org>
2014-11-09There are tests all over the SMB1 code to check that srv_send_smb fails, but ↵Richard Sharpe1-1/+1
it never returns false. Even if the write to the socket/fd fails, we never return false and will keep reading stuff off of the input buffer until it is exhausted and then we will exit. Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Sat Aug 3 17:41:22 CEST 2013 on sn-devel-104 (cherry picked from commit 852c9ac34dbef66d0b2619554c611157c2fab771) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10880 S3: source3/smbd/process.c::srv_send_smb() returns true on the error path.
2014-11-09s3: daemons - ensure nmbd and winbindd are consistent in command line ↵Jeremy Allison2-1/+3
processing by adding POPT_COMMON_DYNCONFIG. Bug #10711 - nmbd fails to accept --piddir option. https://bugzilla.samba.org/show_bug.cgi?id=10711 Signed-off-by: Jeremy Allison <jra@samba.org>
2014-10-26vfs_glusterfs: Remove "integer fd" code and store the glfs pointers.Jose A. Rivera1-90/+32
Change-Id: I74347199e54be0d1dc031985534da1e56fd3e280 Signed-off-by: Jose A. Rivera <jarrpa@redhat.com> Reviewed-by: Christopher R. Hertel <crh@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> The last 3 patches address bug #10889 (Backport remaining vfs_glusterfs patches in master/4.2 to 4.1). Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Sun Oct 26 23:51:26 CET 2014 on sn-devel-104
2014-10-26vfs_glusterfs: smb_stat_ex_from_stat commenting and cleanup.Christopher R. Hertel1-13/+8
Change-Id: If1b54e62b4fc2240aa17e5d1eae8f279f2fdfc42 Signed-off-by: Christopher R. Hertel <crh@samba.org> Reviewed-by: Jose A. Rivera <jarrpa@redhat.com> Reviewed-by: Ira Cooper <ira@samba.org>
2014-10-26vfs_glusterfs: Comment the top of the file.Christopher R. Hertel1-8/+18
Change-Id: I98b512da2e0e56f061247a7c48ce576287b43827 Signed-off-by: Christopher R. Hertel <crh@samba.org> Reviewed-by: Jose A. Rivera <jarrpa@redhat.com> Reviewed-by: Ira Cooper <ira@samba.org>
2014-10-19s3: nmbd: Ensure the main nmbd process doesn't create zombies.Jeremy Allison1-0/+3
Use the same mechanism as setup for smbd and winbindd. Fixes bug #10830 - nmbd can leave unreaped zombies. https://bugzilla.samba.org/show_bug.cgi?id=10830 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Sun Oct 19 23:19:38 CEST 2014 on sn-devel-104
2014-10-19pthreadpool: Slightly serialize jobsJeremy Allison1-3/+3
Using the new msg_source program with 1.500 instances against a single msg_sink I found the msg_source process to spawn two worker threads for synchronously sending the data towards the receiving socket. This should not happen: Per destination node we only create one queue. We strictly only add pthreadpool jobs one after the other, so a single helper thread should be perfectly sufficient. It turned out that under heavy overload the main sending thread was scheduled before the thread that just had finished its send() job. So the helper thread was not able to increment the pool->num_idle variable indicating that we don't have to create a new thread when the new job is added. This patch moves the signalling write under the mutex. This means that indicating readiness via the pipe and the pool->num_idle variable happen both under the same mutex lock and thus are atomic. No superfluous threads anymore. Back port of commit 1c4284c7395f23cefa61a407db74cf5067aee2aa that went into master. https://bugzilla.samba.org/show_bug.cgi?id=10779 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-10-19s3: lib: Signal handling - ensure smbrun and change password code save and ↵Jeremy Allison2-12/+15
restore existing SIGCHLD handlers. Bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc. https://bugzilla.samba.org/show_bug.cgi?id=10831 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2014-10-09s3-libads: Add all machine account principals to the keytab.Andreas Schneider1-22/+52
This adds all SPNs defined in the DC for the computer account to the keytab using 'net ads keytab create -P'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=9985 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 5d58b92f8fcbc509f4fe2bd3617bcaeada1806b6)
2014-10-09registry: Don't leave dangling transactionsVolker Lendecke1-1/+1
When a createkey fails due to access denied, we need to do a transaction_cancel. Otherwise the lock on the db will stay around. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=10860
2014-10-09s3-winbindd: Do not use domain SID from LookupSids for Sids2UnixIDs callChristof Schmitt1-3/+30
Create a new lsa_RefDomainList and populate it with the domain SID from the original query. That avoids the problem that for migrated objects, LookupSids returns the SID of the new domain, and combining that with the RID from the input results in an invalid SID. A better fix would be querying the RID of the user in the new domain, but the approach here at least avoids id mappings entries for invalid SIDs. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Sep 29 13:15:18 CEST 2014 on sn-devel-104 (cherry picked from commit 9c9216410faf707edc4ba05f2b715d45f7f51ca4) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10838 Invalid id mappings for users/groups migrated from another domain
2014-10-09s3: Move init_lsa_ref_domain_list to libChristof Schmitt5-48/+98
This will be used in the next patch in winbind. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 16594e7fc0a46249a48d0d0635de0c1050ecd340)
2014-10-09idmap_rfc2307: Fix a crash after connection problem to DCChristof Schmitt1-0/+1
When the connection to the DC has a problem, the code behind ads_do_search_retry closes the current connection and opens a new one. The new connection has a new struct LDAP to represent the connection. In this case, the LDAP pointer in the idmap_rfc2307_context becomes invalid. Fix this problem by updating the local pointer after calling ads_do_search_retry. Signed-off-by: Christof Schmitt <cs@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=10837 winbind crash in idmap_rfc2307 module
2014-10-09s3-libnet: Make sure we do not overwrite precreated SPNs.Günther Deschner1-3/+36
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9984 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Sep 26 08:22:45 CEST 2014 on sn-devel-104 (cherry picked from commit 0aacbe78bb40d76b65087c2a197c92b0101e625e)
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-22 22:39:06 +0000