summaryrefslogtreecommitdiff
path: root/dselect/methods/Dselect
AgeCommit message (Collapse)AuthorFilesLines
2017-09-24Dselect::Ftp: Avoid many function arguments in do_connect()Guillem Jover1-18/+20
Addresses: Subroutines::ProhibitManyArgs Warned-by: perlcritic
2015-09-14perl: Split overlong regexes into multiline extended regexesGuillem Jover1-2/+9
This should make the regular expressions easier to read and understand, and allows to add comments describing specific parts. Addresses RegularExpressions::RequireExtendedFormatting. Warned-by: perlcritic
2015-05-30scripts, dselsect/methods: Switch from `` to operator qx()Guillem Jover1-2/+2
2015-05-18dselect: Remove outdated local copy of the Debian README.mirrors.txt fileGuillem Jover1-7/+4
This file was a very outdated copy from before 2001, the user is better served by downloading it once they are doing the setup, in case they use Debian. There's no point in doing it ourselves, as the download methods need a major revamp anyway. Closes: #784966
2015-03-30perl: Rework use and exporter declarationsGuillem Jover1-4/+13
Place 'use' strict and warnings first, then Exporter 'our' declarations, then Test module imports, then system module imports, then Dpkg module imports, then 'use' parent and overload pragmas, separated by a blank line for each block. Split each exported symbol declaration into its own line to ease modifications.
2013-12-07Use https:// URLs instead of http:// when possibleGuillem Jover1-1/+1
2013-12-04perl: Surround FileHandles with braces in print callsGuillem Jover1-1/+1
Fixes InputOutput::RequireBracedFileHandleWithPrint. Warned-by: perlcritic
2013-12-04perl: Use croak instead of die on programming errors in modulesGuillem Jover1-1/+2
Addresses ErrorHandling::RequireCarping. Warned-by: perlcritic
2013-12-04perl: Switch to use low precedence boolean operators for error checksGuillem Jover1-5/+5
This will make it safe to remove parenthesis around builtins.
2013-11-24Consistently use regex instead of regexp when possibleGuillem Jover1-1/+1
All changed instances are documentation or private code interfaces. The only remaining variable instance with a regexp name is a publicly exposed variable, which will eventually disappear once it has gone through the deprecation process.
2013-11-24Dselect::Ftp: Uppercase public %config package variableGuillem Jover1-23/+24
This module has a problematic license, so there's no point in doing a more intrusive cleanup, just uppercase the variable and be done with it. Addresses Variables::ProhibitPackageVars. Warned-by: perlcritic
2013-11-23perl: Do not allow hard tabs anywhere other than leading positionGuillem Jover1-6/+8
Fixes CodeLayout::ProhibitHardTabs. Warned-by: perlcritic
2013-09-19Decapitalize error and warning messagesGuillem Jover1-6/+6
2013-06-22perl: Add a VERSION to all modulesGuillem Jover1-0/+2
Addresses Modules::RequireVersionVar.
2013-06-22perl: Place strict and warning pragma uses as the first thingGuillem Jover1-3/+3
2013-06-22perl: Decapitalize variable namesGuillem Jover1-5/+5
Addresses NamingConventions::Capitalization.
2013-05-08perl: Conditionally include modules with require instead of useGuillem Jover1-2/+2
Fixes Modules::ProhibitConditionalUseStatements. Warned-by: perlcritic
2013-05-08perl: Unify regex delimiters to //, {} or <>Guillem Jover1-1/+1
Fixes RegularExpressions::ProhibitUnusualDelimiters. Warned-by: perlcritic
2013-05-08perl: Remove unused variablesGuillem Jover1-1/+1
Fixes Variables::ProhibitUnusedVariables. Warned-by: perlcritic
2013-05-04Do not use double-quotes on strings that do not need interpolationGuillem Jover1-26/+26
Using double-quotes imposes a small performance penalty as the perl parser needs to check if any interpolation is needed. Use double-quotes only when the string contains single-quotes. Ideally we'd use double-quotes too for escaped meta-characters that might otherwise be confusing to immediately see if they need interpolation or not, but the policy does not (currently) allow to ignore these. Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
2013-04-30Do not quote simple identifier hash keys in element accessesGuillem Jover1-18/+20
Addresses ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
2013-04-28Use proper variables instead of barewords for filehandlesGuillem Jover1-6/+7
Fixes InputOutput::ProhibitBarewordFileHandles. Warned-by: perlcritic
2013-04-24Use three-argument form of open in perl codeGuillem Jover1-2/+4
Fixes InputOutput::ProhibitTwoArgOpen. Warned-by: perlcritic
2013-04-24dselect: Stop using 'use vars' in method scriptsGuillem Jover1-4/+4
This also fixes a typo ($VAL1 → $VAR1), and adds %config to the Dselect::Ftp module exported variables.
2013-04-24Dselect::Ftp: Inherit Exporter's import methodGuillem Jover1-1/+2
2013-04-23Debian::Dselect::Ftp: Move module to Dselect::FtpGuillem Jover1-0/+376
This gets rid of the need to hardcode the perl module path in the scripts. The Dselect methods are not really Debian specific anyway.
generated by cgit v1.2.3 (git 2.46.0) at 2025-12-26 11:42:07 +0000